Re: [PATCH v1 5/7] toradex: common: Add sysinfo driver

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 3245 bytes --]

On Wed, Feb 21, 2024 at 02:24:23PM +0000, Marcel Ziswiler wrote:
> Hi Tom
> 
> On Wed, 2024-02-21 at 08:10 -0500, Tom Rini wrote:
> > On Tue, Feb 20, 2024 at 07:51:35PM +0000, Marcel Ziswiler wrote:
> > > On Tue, 2024-02-20 at 21:14 +0200, Svyatoslav Ryhel wrote:
> > > > вт, 20 лют. 2024 р. о 20:29 Francesco Dolcini <francesco@dolcini.it> пише:
> > > > > 
> > > > > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> > > > > 
> > > > > This commit introduces support for the Toradex sysinfo driver in U-Boot,
> > > > > which uses information from Toradex config block to print correct
> > > > > board model.
> > > > > In case the Toradex config block is not present sysinfo prints the model
> > > > > of the board provided by device tree removing per board specific prints.
> > > > > 
> > > > > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > > > ---
> > > > >  arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi    |  6 +++
> > > > >  arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi  |  6 +++
> > > > >  .../dts/imx6dl-colibri-eval-v3-u-boot.dtsi    |  4 ++
> > > > >  arch/arm/dts/imx6q-apalis-eval-u-boot.dtsi    |  4 ++
> > > > >  .../dts/imx6ull-colibri-eval-v3-u-boot.dtsi   |  4 ++
> > > > >  .../arm/dts/imx7d-colibri-eval-v3-u-boot.dtsi |  4 ++
> > > > >  .../dts/imx8mm-verdin-wifi-dev-u-boot.dtsi    |  4 ++
> > > > >  .../dts/imx8mp-verdin-wifi-dev-u-boot.dtsi    |  4 ++
> > > > >  .../dts/k3-am625-verdin-wifi-dev-u-boot.dtsi  |  4 ++
> > > > >  arch/arm/dts/tegra124-apalis-u-boot.dtsi      | 12 +++++
> > > > >  arch/arm/dts/tegra20-colibri-u-boot.dtsi      | 12 +++++
> > > > >  arch/arm/dts/tegra30-apalis-u-boot.dtsi       | 12 +++++
> > > > >  arch/arm/dts/tegra30-colibri-u-boot.dtsi      | 12 +++++
> > > > >  .../arm/dts/vf610-colibri-eval-v3-u-boot.dtsi |  4 ++
> > > > >  board/toradex/common/Kconfig                  |  1 +
> > > > >  board/toradex/common/tdx-common.c             | 50 ++++++++++++++++---
> > > > >  16 files changed, 136 insertions(+), 7 deletions(-)
> > > > >  create mode 100644 arch/arm/dts/tegra124-apalis-u-boot.dtsi
> > > > >  create mode 100644 arch/arm/dts/tegra20-colibri-u-boot.dtsi
> > > > >  create mode 100644 arch/arm/dts/tegra30-apalis-u-boot.dtsi
> > > > >  create mode 100644 arch/arm/dts/tegra30-colibri-u-boot.dtsi
> > > > > 
> > > > 
> > > > Greetings! Thank you for contribution but may you at split patches
> > > > according to SoC vendor at least? For imx, tegra and ti since it
> > > > would be hard to both review and pick them to correct custodian
> > > > trees.
> > > 
> > > I would assume for those urgent fixes to go through Tom directly to master. Thanks!
> > 
> > So this is a series we need for v2024.04 then?
> 
> Yes, please. From the cover letter:
> 
> > This series fixes two regressions affecting multiple Toradex boards (i.MX, TI and TEGRA based) and targets
> the current master, e.g. v2024.04 release.

OK, thanks. I'll wait a bit more for further feedback on the contents
themselves.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]