Re: [PATCH v1 6/7] toradex: common: Use random mac address if toradex config block is missing

[Francesco Dolcini <francesco@dolcini.it>]

On Tue, Feb 20, 2024 at 07:29:25PM +0100, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> 
> Set CONFIG_NET_RANDOM_ETHADDR=y, which sets random eth address in
> case there is no toradex config block programmed.
> In case of missing toradex config block the generated mac address was
> always the same, linked to serial number 0.
> Use random generated mac address instead.
> 
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>  board/toradex/common/tdx-common.c      | 1 -
>  configs/apalis-imx8_defconfig          | 1 +
>  configs/apalis-tk1_defconfig           | 1 +
>  configs/apalis_imx6_defconfig          | 1 +
>  configs/apalis_t30_defconfig           | 1 +
>  configs/colibri-imx6ull-emmc_defconfig | 1 +
>  configs/colibri-imx6ull_defconfig      | 1 +
>  configs/colibri-imx8x_defconfig        | 1 +
>  configs/colibri_imx6_defconfig         | 1 +
>  configs/colibri_imx7_defconfig         | 1 +
>  configs/colibri_imx7_emmc_defconfig    | 1 +
>  configs/colibri_t20_defconfig          | 1 +
>  configs/colibri_t30_defconfig          | 1 +
>  configs/colibri_vf_defconfig           | 1 +
>  configs/verdin-am62_a53_defconfig      | 1 +
>  configs/verdin-am62_r5_defconfig       | 1 +
>  configs/verdin-imx8mm_defconfig        | 1 +
>  configs/verdin-imx8mp_defconfig        | 1 +
>  18 files changed, 17 insertions(+), 1 deletion(-)

...

> diff --git a/configs/verdin-am62_r5_defconfig b/configs/verdin-am62_r5_defconfig
> index a3febdcb6941..910340ea5a41 100644
> --- a/configs/verdin-am62_r5_defconfig
> +++ b/configs/verdin-am62_r5_defconfig
> @@ -65,6 +65,7 @@ CONFIG_SPL_OF_CONTROL=y
>  CONFIG_SPL_MULTI_DTB_FIT=y
>  CONFIG_SPL_MULTI_DTB_FIT_NO_COMPRESSION=y
>  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> +CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_SPL_DM=y
>  CONFIG_SPL_DM_SEQ_ALIAS=y
>  CONFIG_REGMAP=y

This change here is not required, it has no effect since there is no
network available on the verdin am62 r5, however it is just confusing to
have it enabled.

I will send a v2 with this removed.

Francesco