public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Jonathan Humphreys <j-humphreys@ti.com>
Cc: vigneshr@ti.com, u-boot@lists.denx.de
Subject: Re: [PATCH v2 2/2] arm: dts: k3-am642-evm/sk: Enable OSPI support in SPL
Date: Sat, 24 Feb 2024 08:59:59 -0500	[thread overview]
Message-ID: <20240224135959.GC3040305@bill-the-cat> (raw)
In-Reply-To: <20240224001702.2283727-3-j-humphreys@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

On Fri, Feb 23, 2024 at 06:17:02PM -0600, Jonathan Humphreys wrote:
> Add bootph DT tags to enable OSPI in SPL.
> Set OSPI regs for R5 SPL to address OSPI's boot region.
> 
> Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com>
> ---
>  arch/arm/dts/k3-am642-evm-u-boot.dtsi | 16 ++++++++++++++++
>  arch/arm/dts/k3-am642-r5-evm.dts      |  5 +++++
>  arch/arm/dts/k3-am642-r5-sk.dts       |  5 +++++
>  arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 16 ++++++++++++++++
>  4 files changed, 42 insertions(+)
> 
> diff --git a/arch/arm/dts/k3-am642-evm-u-boot.dtsi b/arch/arm/dts/k3-am642-evm-u-boot.dtsi
> index b843078243..60b219c0be 100644
> --- a/arch/arm/dts/k3-am642-evm-u-boot.dtsi
> +++ b/arch/arm/dts/k3-am642-evm-u-boot.dtsi
> @@ -182,3 +182,19 @@
>  &cpsw_port2 {
>  	status = "disabled";
>  };
> +
> +&ospi0_pins_default {
> +	bootph-all;
> +};
> +
> +&fss {
> +	bootph-all;
> +};
> +
> +&ospi0 {
> +	bootph-all;
> +
> +	flash@0 {
> +		bootph-all;
> +	};
> +};

So this gets back to what I was asking in the first series, is this
needed in SPL or full U-Boot as well? The bootph-* properties are
supposed to be transitive, but originally the tooling didn't handle this
and now the tooling handles SPL but not full U-Boot. Which also brings
back the is this _needed_ question and is bootph-all right, rather than
just the big hammer?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2024-02-24 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-24  0:17 [PATCH v2 0/2] enable OSPI support on AM64x Jonathan Humphreys
2024-02-24  0:17 ` [PATCH v2 1/2] configs: am64x_evm_*_defconfig: Enable OSPI support Jonathan Humphreys
2024-02-24  0:17 ` [PATCH v2 2/2] arm: dts: k3-am642-evm/sk: Enable OSPI support in SPL Jonathan Humphreys
2024-02-24 13:59   ` Tom Rini [this message]
2024-02-24 17:34     ` Jon Humphreys
2024-02-27 18:16       ` Tom Rini
2024-02-27 18:40         ` Jon Humphreys
2024-03-05 16:03 ` [PATCH v2 0/2] enable OSPI support on AM64x Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240224135959.GC3040305@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=j-humphreys@ti.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox