Re: [PATCH] arm: dts: k3-binman: Make optee optional as requirement

Neha Malcom Francis
2024-02-26T03:17:19Z

Hi Michael

+ Vignesh

On 25/02/24 23:08, Michael Trimarchi wrote:
> Boards can use the ti_spl_template but avoid to define a tee
> node to be loaded. This is true form board with 512Mb or less

s/form board/for boards? I am guessing that is what was meant. I am not really
understanding the commit message... does <512MB memory always mean no using
OPTEE? (AM62 SIP would be an exception) The commit message is putting out a
misleading reason why we don't need OPTEE in some cases, I don't think memory is
the primary reason.

> memory. We can limit this in configuation removing the tee

s/configuation/configuration

> node
>
> configurations {
> default = "conf-0";
>
> conf-0 {
> description = "k3-am62_ccm_m3";
> firmware = "atf";
> loadables = "dm", "spl";
> fdt = "fdt-0";
> };
> };
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> arch/arm/dts/k3-binman.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/dts/k3-binman.dtsi b/arch/arm/dts/k3-binman.dtsi
> index 758c8bf6ea..5ef5af315a 100644
> --- a/arch/arm/dts/k3-binman.dtsi
> +++ b/arch/arm/dts/k3-binman.dtsi
> @@ -293,6 +293,7 @@
> keyfile = "custMpk.pem";
> };
> tee: tee-os {
> + optional;
> };
> };
>
> @@ -360,6 +361,7 @@
> entry = <0x9e800000>;
> tee-os {
> filename = "tee-raw.bin";
> + optional;
> };
> };
>

The patch excluding the commit message LGTM.

--
Thanking You
Neha Malcom Francis