Re: [PATCH] configs: rockchip: rock3a: enable environment

Jonas Karlman
2024-03-05T10:02:10Z

Hi Trevor,

On 2024-03-05 03:10, Trevor Woerner wrote:
> Following the pattern of other Rockchip devices, enable the U-Boot
> environment to be stored in MMC. This patch specifically assumes the
> environment will be stored on the SDcard.

This board has SPI flash, so storing env in SPI flash is probably a
better default. However, preferably the env should be stored/loaded from
the same device that TPL/SPL was loaded from.

What is your use case for being able to store the env? Personally, I have
never had a need for storing an env and use ENV_IS_NOWHERE on my boards.

Regards,
Jonas

>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> configs/rock-3a-rk3568_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
> index 28d157dbd7a7..44158a4d34f1 100644
> --- a/configs/rock-3a-rk3568_defconfig
> +++ b/configs/rock-3a-rk3568_defconfig
> @@ -58,6 +58,8 @@ CONFIG_CMD_REGULATOR=y
> CONFIG_SPL_OF_CONTROL=y
> CONFIG_OF_LIVE=y
> CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
> +CONFIG_ENV_IS_IN_MMC=y
> +CONFIG_SYS_MMC_ENV_DEV=1
> CONFIG_SPL_DM_SEQ_ALIAS=y
> CONFIG_SPL_REGMAP=y
> CONFIG_SPL_SYSCON=y