From: Colin McAllister <colinmca242@gmail.com>
To: u-boot@lists.denx.de
Cc: Colin McAllister <colin.mcallister@garmin.com>,
JPEWhacker@gmail.com, sjg@chromium.org,
Sam Protsenko <semen.protsenko@linaro.org>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Igor Opaniuk <igor.opaniuk@gmail.com>,
Colin McAllister <colinmca242@gmail.com>
Subject: [PATCH v4 1/2] android_ab: Add missing semicolon
Date: Tue, 12 Mar 2024 07:57:28 -0500 [thread overview]
Message-ID: <20240312125729.82695-2-colinmca242@gmail.com> (raw)
In-Reply-To: <20240312125729.82695-1-colinmca242@gmail.com>
From: Colin McAllister <colin.mcallister@garmin.com>
Found a missing semicolon in code protected by a #if that will never
evaluate to true due to a separate issue. Fixing this issue before
addressing the #if.
Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message")
Signed-off-by: Colin McAllister <colin.mcallister@garmin.com>
Cc: Joshua Watt <JPEWhacker@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Colin McAllister <colinmca242@gmail.com>
---
v2: No changes
v3: Added "Fixes:" tag
v4: No changes
boot/android_ab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/android_ab.c b/boot/android_ab.c
index c9df6d2b4b..9a3d15ec60 100644
--- a/boot/android_ab.c
+++ b/boot/android_ab.c
@@ -221,7 +221,7 @@ int ab_select_slot(struct blk_desc *dev_desc, struct disk_partition *part_info,
#if ANDROID_AB_BACKUP_OFFSET
crc32_le = ab_control_compute_crc(backup_abc);
if (backup_abc->crc32_le != crc32_le) {
- log_err("ANDROID: Invalid backup CRC-32 ")
+ log_err("ANDROID: Invalid backup CRC-32 ");
log_err("expected %.8x, found %.8x),",
crc32_le, backup_abc->crc32_le);
#endif
--
2.34.1
next prev parent reply other threads:[~2024-03-12 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 12:57 [PATCH v4 0/2] Fix Android A/B backup Colin McAllister
2024-03-12 12:57 ` Colin McAllister [this message]
2024-03-12 15:12 ` [PATCH v4 1/2] android_ab: Add missing semicolon Mattijs Korpershoek
2024-03-13 17:18 ` Igor Opaniuk
2024-03-12 12:57 ` [PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET Colin McAllister
2024-03-12 15:19 ` Mattijs Korpershoek
2024-03-13 17:22 ` Igor Opaniuk
2024-03-21 9:29 ` Mattijs Korpershoek
2024-03-21 12:19 ` Colin
2024-03-22 7:41 ` [PATCH v4 0/2] Fix Android A/B backup Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312125729.82695-2-colinmca242@gmail.com \
--to=colinmca242@gmail.com \
--cc=JPEWhacker@gmail.com \
--cc=colin.mcallister@garmin.com \
--cc=igor.opaniuk@gmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=semen.protsenko@linaro.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox