From: Alexander Dahl <ada@thorsis.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Michael Trimarchi <michael@amarulasolutions.com>
Cc: Balamanikandan Gunasundar
<balamanikandan.gunasundar@microchip.com>,
Eugen Hristev <eugen.hristev@collabora.com>,
Mihai Sain <mihai.sain@microchip.com>,
Li Bin <bin.li@microchip.com>,
u-boot@lists.denx.de
Subject: [PATCH v2 5/6] mtd: nand: raw: atmel: Fix comment in timings preparation
Date: Wed, 20 Mar 2024 10:02:13 +0100 [thread overview]
Message-ID: <20240320090214.40465-6-ada@thorsis.com> (raw)
In-Reply-To: <20240320090214.40465-1-ada@thorsis.com>
Introduced with commit 6a8dfd57220d ("nand: atmel: Add DM based NAND
driver") when driver was initially ported from Linux. The context
around this and especially the code itself suggests 'read' is meant
instead of write.
The fix is the same as accepted in Linux already with mainline Linux
kernel commit 1c60e027ffde ("mtd: nand: raw: atmel: Fix comment in
timings preparation").
Link: https://lore.kernel.org/linux-mtd/20240307172835.3453880-1-miquel.raynal@bootlin.com/T/#t
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
Notes:
v2:
- initial patch version (not present in v1)
drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index 75da15c157b..bbafc88e44c 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -1271,7 +1271,7 @@ static int atmel_smc_nand_prepare_smcconf(struct atmel_nand *nand,
return ret;
/*
- * The write cycle timing is directly matching tWC, but is also
+ * The read cycle timing is directly matching tRC, but is also
* dependent on the setup and hold timings we calculated earlier,
* which gives:
*
--
2.39.2
next prev parent reply other threads:[~2024-03-20 9:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 9:02 [PATCH v2 0/6] mtd: nand: raw: Collected improvements Alexander Dahl
2024-03-20 9:02 ` [PATCH v2 1/6] mtd: nand: raw: Use macro nand_to_mtd() where appropriate Alexander Dahl
2024-03-20 9:02 ` [PATCH v2 2/6] mtd: nand: raw: Port another option flag from Linux Alexander Dahl
2024-03-20 9:02 ` [PATCH v2 3/6] mtd: nand: raw: Fix (most) Kconfig indentation Alexander Dahl
2024-03-20 9:02 ` [PATCH v2 4/6] mtd: nand: raw: atmel: Introduce optional debug commands Alexander Dahl
2024-03-20 9:02 ` Alexander Dahl [this message]
2024-03-20 12:25 ` [PATCH v2 5/6] mtd: nand: raw: atmel: Fix comment in timings preparation Michael Nazzareno Trimarchi
2024-03-20 9:02 ` [PATCH v2 6/6] cmd: nand: Add new optional sub-command 'onfi' Alexander Dahl
2024-03-20 12:48 ` Mihai.Sain
2024-03-20 14:08 ` Mihai.Sain
2024-03-21 9:16 ` Michael Nazzareno Trimarchi
2024-03-22 10:02 ` Mihai.Sain
2024-03-22 11:46 ` Alexander Dahl
2024-03-22 11:54 ` Michael Nazzareno Trimarchi
2024-03-22 12:02 ` Alexander Dahl
2024-03-22 12:34 ` Michael Nazzareno Trimarchi
2024-04-14 13:41 ` [PATCH v2 0/6] mtd: nand: raw: Collected improvements Dario Binacchi
2024-04-15 6:13 ` Alexander Dahl
2024-04-15 6:32 ` Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320090214.40465-6-ada@thorsis.com \
--to=ada@thorsis.com \
--cc=balamanikandan.gunasundar@microchip.com \
--cc=bin.li@microchip.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=eugen.hristev@collabora.com \
--cc=michael@amarulasolutions.com \
--cc=mihai.sain@microchip.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox