From: Tom Rini <trini@konsulko.com>
To: Devarsh Thakkar <devarsht@ti.com>
Cc: lukas.funke-oss@weidmueller.com, u-boot@lists.denx.de,
Lukas Funke <lukas.funke@weidmueller.com>,
Andre Przywara <andre.przywara@arm.com>,
Bin Meng <bmeng@tinylab.org>,
Chanho Park <chanho61.park@samsung.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Manoj Sai <abbaraju.manojsai@amarulasolutions.com>,
Marek Vasut <marex@denx.de>,
Mayuresh Chitale <mchitale@ventanamicro.com>,
Nikhil M Jain <n-jain1@ti.com>,
Oleksandr Suvorov <oleksandr.suvorov@foundries.io>,
Samuel Holland <samuel@sholland.org>,
Sean Anderson <seanga2@gmail.com>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 1/2] spl: Introduce architecture specific init function
Date: Wed, 20 Mar 2024 11:33:16 -0400 [thread overview]
Message-ID: <20240320153316.GW3442575@bill-the-cat> (raw)
In-Reply-To: <3866627e-de73-dbc7-fd8c-bb2b0d11b5cc@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
On Wed, Mar 20, 2024 at 08:52:30PM +0530, Devarsh Thakkar wrote:
> Hi Tom, Lukas,
>
> Thanks for the patch Lukas.
>
> On 20/03/24 20:00, Tom Rini wrote:
> > On Wed, Mar 20, 2024 at 02:19:26PM +0100, lukas.funke-oss@weidmueller.com wrote:
> >
> >> From: Lukas Funke <lukas.funke@weidmueller.com>
> >>
> >> Some architectures use spl_board_init() in their architecture specific
> >> implementation. Board developers should be able to add board specific
> >> implementation via spl_board_init(). Hence, introduce a spl_arch_init()
> >> method which is called right before spl_board_init() for architecture
> >> specific implementation.
> >>
> >> Signed-off-by: Lukas Funke <lukas.funke@weidmueller.com>
> >
> > I think this could allow for other SoCs to clean up their existing
>
> Does it make more sense to make this SoC specific then instead of arch
> specific to allow broader range of code?
"soc" and "arch" are somewhat interchangeable at times, so I think we
can go one step at a time here and bring in this abstraction and see
where everyone else is able to clean their code up to.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-03-20 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 13:19 [PATCH 0/2] Introduce spl_arch_init() for architecture specific initialization lukas.funke-oss
2024-03-20 13:19 ` [PATCH 1/2] spl: Introduce architecture specific init function lukas.funke-oss
2024-03-20 14:30 ` Tom Rini
2024-03-20 15:22 ` Devarsh Thakkar
2024-03-20 15:33 ` Tom Rini [this message]
2024-03-20 15:49 ` Andre Przywara
2024-03-21 7:54 ` Lukas Funke
2024-03-21 15:13 ` Michal Simek
2024-03-20 13:19 ` [PATCH 2/2] arm64: zynq(mp): Rename spl_board_init() to spl_arch_init() lukas.funke-oss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320153316.GW3442575@bill-the-cat \
--to=trini@konsulko.com \
--cc=abbaraju.manojsai@amarulasolutions.com \
--cc=andre.przywara@arm.com \
--cc=bmeng@tinylab.org \
--cc=chanho61.park@samsung.com \
--cc=devarsht@ti.com \
--cc=lukas.funke-oss@weidmueller.com \
--cc=lukas.funke@weidmueller.com \
--cc=marex@denx.de \
--cc=mchitale@ventanamicro.com \
--cc=n-jain1@ti.com \
--cc=oleksandr.suvorov@foundries.io \
--cc=samuel@sholland.org \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox