From: Lukasz Majewski <lukma@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>,
u-boot@lists.denx.de, Anatolij Gustschin <agust@denx.de>,
Christian Hewitt <christianshewitt@gmail.com>,
FUKAUMI Naoki <naoki@radxa.com>,
Hai Pham <hai.pham.ud@renesas.com>,
Jonas Karlman <jonas@kwiboo.se>,
Kever Yang <kever.yang@rock-chips.com>,
Marek Vasut <marex@denx.de>, Mathieu Othacehe <othacehe@gnu.org>,
Michal Simek <michal.simek@amd.com>,
"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Simon Glass <sjg@chromium.org>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Tianling Shen <cnsztl@gmail.com>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 00/12] arm: xea: Provide support for different XEA board HW versions
Date: Mon, 25 Mar 2024 09:48:12 +0100 [thread overview]
Message-ID: <20240325094812.480d23c8@wsk> (raw)
In-Reply-To: <CAOMZO5Cgjy6huSfX_gpd+UQB-xZN6vKJv-=sLE1QL38jCgUUeg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2039 bytes --]
Hi Fabio,
> Hi Lukasz,
>
> On Fri, Mar 22, 2024 at 8:43 AM Lukasz Majewski <lukma@denx.de> wrote:
>
> > arch/arm/dts/Makefile | 3 +-
> > arch/arm/dts/imx28-xea-1-u-boot.dtsi | 11 ++++
> > arch/arm/dts/imx28-xea-1.dts | 8 +++
> > arch/arm/dts/imx28-xea-2-u-boot.dtsi | 11 ++++
> > arch/arm/dts/imx28-xea-2.dts | 8 +++
> > arch/arm/dts/imx28-xea-u-boot.dtsi | 1 -
> > .../arm/dts/{imx28-xea.dts => imx28-xea.dtsi} | 0
>
> This rename deviates from the upstream devicetree name.
>
> Ideally, we should convert to OF_UPSTREAM available in U-Boot next.
>
> > board/liebherr/xea/spl_xea.c | 21 +++---
> > board/liebherr/xea/xea.c | 65
> > +++++++++++++++++++ board/liebherr/xea/xea.env |
> > 4 +- configs/imx28_xea_defconfig | 5 +-
> > configs/imx28_xea_sb_defconfig | 5 +-
> > 12 files changed, 128 insertions(+), 14 deletions(-)
> > create mode 100644 arch/arm/dts/imx28-xea-1-u-boot.dtsi
>
> > create mode 100644 arch/arm/dts/imx28-xea-1.dts
> > create mode 100644 arch/arm/dts/imx28-xea-2-u-boot.dtsi
> > create mode 100644 arch/arm/dts/imx28-xea-2.dts
> > rename arch/arm/dts/{imx28-xea.dts => imx28-xea.dtsi} (100%)
>
> You should upstream imx28-xea-1.dts and imx28-xea-2.dts first.
The case here is that I'm modifying the *-u-boot.dts{i} files only. In
other words, u-boot will not support features described in Linux DTS.
Hence, the rename of files (which would be in sync with Linux at some
point) looks like not related to Linux DTS (as even after re-sync with
upstream Linux those changes will not be in Linux DTS).
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-25 8:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 11:43 [PATCH 00/12] arm: xea: Provide support for different XEA board HW versions Lukasz Majewski
2024-03-22 11:43 ` [PATCH 01/12] arm: spl: xea: Remove I2S pins configuration from early initialization Lukasz Majewski
2024-03-22 11:43 ` [PATCH 02/12] arm: xea: Add support for reading SoM (CPU) and base board HW revision Lukasz Majewski
2024-03-22 11:43 ` [PATCH 03/12] arm: xea: Rename imx28-xea.dts to imx28-xea-1.dts Lukasz Majewski
2024-03-22 11:43 ` [PATCH 04/12] dts: xea: Move phy-reset-gpios property to version specific DTS file Lukasz Majewski
2024-03-22 11:43 ` [PATCH 05/12] dts: xea: Remove outdated comment Lukasz Majewski
2024-03-22 11:43 ` [PATCH 06/12] arm: xea: Add support for multiple dtbs in u-boot Lukasz Majewski
2024-03-22 11:43 ` [PATCH 07/12] dts: xea: Add device tree description for XEA HW rev. 2 Lukasz Majewski
2024-03-22 11:43 ` [PATCH 08/12] arm: spl: Add definition for PHY reset GPIO " Lukasz Majewski
2024-03-22 11:43 ` [PATCH 09/12] arm: config: xea: Enable support for multiple DTBs for XEA board Lukasz Majewski
2024-03-22 11:43 ` [PATCH 10/12] config: xea: Enable late board initialization to set revision variable Lukasz Majewski
2024-03-22 11:43 ` [PATCH 11/12] arm: xea: Print information about XEA's SoM HW revision Lukasz Majewski
2024-03-22 11:43 ` [PATCH 12/12] arm: env: Add support for booting different HW revisions of XEA boards Lukasz Majewski
2024-03-22 13:47 ` [PATCH 00/12] arm: xea: Provide support for different XEA board HW versions Fabio Estevam
2024-03-25 8:48 ` Lukasz Majewski [this message]
2024-03-26 11:05 ` Fabio Estevam
2024-03-26 13:50 ` Lukasz Majewski
2024-03-27 12:05 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325094812.480d23c8@wsk \
--to=lukma@denx.de \
--cc=agust@denx.de \
--cc=christianshewitt@gmail.com \
--cc=clamor95@gmail.com \
--cc=cnsztl@gmail.com \
--cc=festevam@gmail.com \
--cc=hai.pham.ud@renesas.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=marex@denx.de \
--cc=michal.simek@amd.com \
--cc=naoki@radxa.com \
--cc=neil.armstrong@linaro.org \
--cc=othacehe@gnu.org \
--cc=sbabic@denx.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox