Re: [PATCH 00/12] arm: xea: Provide support for different XEA board HW versions

Fabio Estevam
2024-03-22T13:47:37Z

Hi Lukasz,

On Fri, Mar 22, 2024 at 8:43 AM Lukasz Majewski <lukma@denx.de> wrote:

> arch/arm/dts/Makefile | 3 +-
> arch/arm/dts/imx28-xea-1-u-boot.dtsi | 11 ++++
> arch/arm/dts/imx28-xea-1.dts | 8 +++
> arch/arm/dts/imx28-xea-2-u-boot.dtsi | 11 ++++
> arch/arm/dts/imx28-xea-2.dts | 8 +++
> arch/arm/dts/imx28-xea-u-boot.dtsi | 1 -
> .../arm/dts/{imx28-xea.dts => imx28-xea.dtsi} | 0

This rename deviates from the upstream devicetree name.

Ideally, we should convert to OF_UPSTREAM available in U-Boot next.

> board/liebherr/xea/spl_xea.c | 21 +++---
> board/liebherr/xea/xea.c | 65 +++++++++++++++++++
> board/liebherr/xea/xea.env | 4 +-
> configs/imx28_xea_defconfig | 5 +-
> configs/imx28_xea_sb_defconfig | 5 +-
> 12 files changed, 128 insertions(+), 14 deletions(-)
> create mode 100644 arch/arm/dts/imx28-xea-1-u-boot.dtsi

> create mode 100644 arch/arm/dts/imx28-xea-1.dts
> create mode 100644 arch/arm/dts/imx28-xea-2-u-boot.dtsi
> create mode 100644 arch/arm/dts/imx28-xea-2.dts
> rename arch/arm/dts/{imx28-xea.dts => imx28-xea.dtsi} (100%)

You should upstream imx28-xea-1.dts and imx28-xea-2.dts first.