Re: [PATCH 00/12] arm: xea: Provide support for different XEA board HW versions

Lukasz Majewski
2024-03-25T08:48:23Z

[-- Attachment #1: Type: text/plain, Size: 2039 bytes --]

Hi Fabio,

> Hi Lukasz,
>
> On Fri, Mar 22, 2024 at 8:43 AM Lukasz Majewski <lukma@denx.de> wrote:
>
> > arch/arm/dts/Makefile | 3 +-
> > arch/arm/dts/imx28-xea-1-u-boot.dtsi | 11 ++++
> > arch/arm/dts/imx28-xea-1.dts | 8 +++
> > arch/arm/dts/imx28-xea-2-u-boot.dtsi | 11 ++++
> > arch/arm/dts/imx28-xea-2.dts | 8 +++
> > arch/arm/dts/imx28-xea-u-boot.dtsi | 1 -
> > .../arm/dts/{imx28-xea.dts => imx28-xea.dtsi} | 0
>
> This rename deviates from the upstream devicetree name.
>
> Ideally, we should convert to OF_UPSTREAM available in U-Boot next.
>
> > board/liebherr/xea/spl_xea.c | 21 +++---
> > board/liebherr/xea/xea.c | 65
> > +++++++++++++++++++ board/liebherr/xea/xea.env |
> > 4 +- configs/imx28_xea_defconfig | 5 +-
> > configs/imx28_xea_sb_defconfig | 5 +-
> > 12 files changed, 128 insertions(+), 14 deletions(-)
> > create mode 100644 arch/arm/dts/imx28-xea-1-u-boot.dtsi
>
> > create mode 100644 arch/arm/dts/imx28-xea-1.dts
> > create mode 100644 arch/arm/dts/imx28-xea-2-u-boot.dtsi
> > create mode 100644 arch/arm/dts/imx28-xea-2.dts
> > rename arch/arm/dts/{imx28-xea.dts => imx28-xea.dtsi} (100%)
>
> You should upstream imx28-xea-1.dts and imx28-xea-2.dts first.

The case here is that I'm modifying the *-u-boot.dts{i} files only. In
other words, u-boot will not support features described in Linux DTS.

Hence, the rename of files (which would be in sync with Linux at some
point) looks like not related to Linux DTS (as even after re-sync with
upstream Linux those changes will not be in Linux DTS).

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]