[PATCH u-boot-mvebu v3 00/18] Turris Omnia - New board revision support

[PATCH u-boot-mvebu v3 00/18] Turris Omnia - New board revision support

[Marek Behún]

Hi Stefan,

this is v3 of series adding support for new board revision of Turris
Omnia.

Changes since v2:
- patch 2: updated MCU command interface header
- patch 6: fixed bug setting \0 as end of string in src array instead
           of dst array after bin2hex() call
- patch 16: updated commit message (added the bit about ctrl+c)

v1 and v2 at:
  https://patchwork.ozlabs.org/project/uboot/cover/20240304152148.3847-1-kabel@kernel.org/
  https://patchwork.ozlabs.org/project/uboot/cover/20240323180711.5498-1-kabel@kernel.org/

Marek Behún (18):
  arm: mvebu: turris_omnia: Enable LTO by default on Turris Omnia
  arm: mvebu: turris_omnia: Add header containing MCU command interface
    and use it
  arm: mvebu: turris_{omnia, mox}: Don't print model two times
  arm: mvebu: turris_omnia: Update MCU status and features reading
  arm: mvebu: turris_omnia: Implement getting board information from MCU
  arm: mvebu: turris_omnia: Print board ECDSA public key if available
  arm: mvebu: turris_omnia: Disable Atmel SHA node if not present
  arm: mvebu: spl: Do not build mvebu-reset in SPL
  arm: mvebu: system-controller: Rework to use UCLASS_SYSCON
  arm: mvebu: system-controller: Select mvebu-reset if DM_RESET &&
    PCI_MVEBU
  arm: mvebu: system-controller: Add support for SYSRESET
  gpio: turris_omnia_mcu: Use byteorder conversion functions
  gpio: turris_omnia_mcu: Update firmware features reading
  gpio: turris_omnia_mcu: Add support for system power off via sysreset
  arm: mvebu: turris_omnia: Enable poweroff command via sysreset in
    defconfig
  cmd: rng: Print "Abort" on -EINTR
  misc: turris_omnia_mcu: Add support for rng provided by MCU
  arm: mvebu: turris_omnia: Enable rng command in defconfig

 arch/arm/mach-mvebu/Kconfig              |  25 ++
 arch/arm/mach-mvebu/Makefile             |   3 +-
 arch/arm/mach-mvebu/cpu.c                |   2 +
 arch/arm/mach-mvebu/system-controller.c  | 144 ++++++--
 board/CZ.NIC/turris_atsha_otp.c          |  27 +-
 board/CZ.NIC/turris_mox/turris_mox.c     |   5 +-
 board/CZ.NIC/turris_omnia/Makefile       |   2 +-
 board/CZ.NIC/turris_omnia/turris_omnia.c | 310 ++++++++++++-----
 cmd/rng.c                                |   7 +-
 configs/turris_omnia_defconfig           |   6 +
 drivers/gpio/Kconfig                     |   7 -
 drivers/gpio/Makefile                    |   1 -
 drivers/gpio/turris_omnia_mcu.c          | 316 -----------------
 drivers/misc/Kconfig                     |  11 +
 drivers/misc/Makefile                    |   1 +
 drivers/misc/turris_omnia_mcu.c          | 411 +++++++++++++++++++++++
 include/turris-omnia-mcu-interface.h     | 248 ++++++++++++++
 17 files changed, 1044 insertions(+), 482 deletions(-)
 delete mode 100644 drivers/gpio/turris_omnia_mcu.c
 create mode 100644 drivers/misc/turris_omnia_mcu.c
 create mode 100644 include/turris-omnia-mcu-interface.h

-- 
2.43.2

[PATCH u-boot-mvebu v3 01/18] arm: mvebu: turris_omnia: Enable LTO by default on Turris Omnia

[Marek Behún]

U-Boot builds for Turris Omnia are approaching the limit of 0xf0000
bytes, which is the size of the U-Boot partition on Omnia.

Enable LTO to get more size optimized binaries.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 configs/turris_omnia_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index 29148402a1..39e15043df 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -31,6 +31,7 @@ CONFIG_AHCI=y
 CONFIG_OF_BOARD_FIXUP=y
 CONFIG_SYS_MEMTEST_START=0x00800000
 CONFIG_SYS_MEMTEST_END=0x00ffffff
+CONFIG_LTO=y
 CONFIG_HAS_BOARD_SIZE_LIMIT=y
 CONFIG_BOARD_SIZE_LIMIT=983040
 CONFIG_FIT=y
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 01/18] arm: mvebu: turris_omnia: Enable LTO by default on Turris Omnia

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> U-Boot builds for Turris Omnia are approaching the limit of 0xf0000
> bytes, which is the size of the U-Boot partition on Omnia.
> 
> Enable LTO to get more size optimized binaries.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   configs/turris_omnia_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index 29148402a1..39e15043df 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -31,6 +31,7 @@ CONFIG_AHCI=y
>   CONFIG_OF_BOARD_FIXUP=y
>   CONFIG_SYS_MEMTEST_START=0x00800000
>   CONFIG_SYS_MEMTEST_END=0x00ffffff
> +CONFIG_LTO=y
>   CONFIG_HAS_BOARD_SIZE_LIMIT=y
>   CONFIG_BOARD_SIZE_LIMIT=983040
>   CONFIG_FIT=y

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 02/18] arm: mvebu: turris_omnia: Add header containing MCU command interface and use it

[Marek Behún]

Add header containing all MCU command definitions and use it in board
code and in MCU driver.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 board/CZ.NIC/turris_omnia/turris_omnia.c |  81 +++-----
 drivers/gpio/turris_omnia_mcu.c          |  54 +----
 include/turris-omnia-mcu-interface.h     | 248 +++++++++++++++++++++++
 3 files changed, 272 insertions(+), 111 deletions(-)
 create mode 100644 include/turris-omnia-mcu-interface.h

diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
index adeb69a205..6c2d7da528 100644
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c
+++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
@@ -23,6 +23,7 @@
 #include <fdt_support.h>
 #include <hexdump.h>
 #include <time.h>
+#include <turris-omnia-mcu-interface.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
 #include <u-boot/crc.h>
@@ -59,46 +60,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define A385_WD_RSTOUT_UNMASK		MVEBU_REGISTER(0x20704)
 #define   A385_WD_RSTOUT_UNMASK_GLOBAL	BIT(8)
 
-enum mcu_commands {
-	CMD_GET_STATUS_WORD	= 0x01,
-	CMD_GET_RESET		= 0x09,
-	CMD_GET_FW_VERSION_APP	= 0x0a,
-	CMD_WATCHDOG_STATE	= 0x0b,
-	CMD_GET_FW_VERSION_BOOT	= 0x0e,
-
-	/* available if STS_FEATURES_SUPPORTED bit set in status word */
-	CMD_GET_FEATURES	= 0x10,
-
-	/* available if EXT_CMD bit set in features */
-	CMD_EXT_CONTROL		= 0x12,
-};
-
-enum status_word_bits {
-	STS_MCU_TYPE_MASK	= GENMASK(1, 0),
-	STS_MCU_TYPE_STM32	= 0,
-	STS_MCU_TYPE_GD32	= 1,
-	STS_MCU_TYPE_MKL	= 2,
-	STS_MCU_TYPE_UNKN	= 3,
-	STS_FEATURES_SUPPORTED	= BIT(2),
-	CARD_DET_STSBIT		= 0x0010,
-	MSATA_IND_STSBIT	= 0x0020,
-};
-
-/* CMD_GET_FEATURES */
-enum features_e {
-	FEAT_PERIPH_MCU		= BIT(0),
-	FEAT_EXT_CMDS		= BIT(1),
-};
-
-/* CMD_EXT_CONTROL */
-enum ext_ctl_e {
-	EXT_CTL_nRES_LAN	= BIT(1),
-	EXT_CTL_nRES_PHY	= BIT(2),
-	EXT_CTL_nPERST0		= BIT(3),
-	EXT_CTL_nPERST1		= BIT(4),
-	EXT_CTL_nPERST2		= BIT(5),
-};
-
 /*
  * Those values and defines are taken from the Marvell U-Boot version
  * "u-boot-2013.01-2014_T3.0"
@@ -219,7 +180,7 @@ static bool disable_mcu_watchdog(void)
 
 	puts("Disabling MCU watchdog... ");
 
-	ret = omnia_mcu_write(CMD_WATCHDOG_STATE, "\x00", 1);
+	ret = omnia_mcu_write(CMD_SET_WATCHDOG_STATE, "\x00", 1);
 	if (ret) {
 		printf("omnia_mcu_write failed: %i\n", ret);
 		return false;
@@ -256,17 +217,17 @@ static bool omnia_detect_sata(const char *msata_slot)
 		return false;
 	}
 
-	if (!(stsword & CARD_DET_STSBIT)) {
+	if (!(stsword & STS_CARD_DET)) {
 		puts("none\n");
 		return false;
 	}
 
-	if (stsword & MSATA_IND_STSBIT)
+	if (stsword & STS_MSATA_IND)
 		puts("mSATA\n");
 	else
 		puts("MiniPCIe\n");
 
-	return stsword & MSATA_IND_STSBIT ? true : false;
+	return stsword & STS_MSATA_IND;
 }
 
 static bool omnia_detect_wwan_usb3(const char *wwan_slot)
@@ -393,18 +354,7 @@ static int omnia_get_ram_size_gb(void)
 
 static const char * const omnia_get_mcu_type(void)
 {
-	static const char * const mcu_types[] = {
-		[STS_MCU_TYPE_STM32] = "STM32",
-		[STS_MCU_TYPE_GD32]  = "GD32",
-		[STS_MCU_TYPE_MKL]   = "MKL",
-		[STS_MCU_TYPE_UNKN]  = "unknown",
-	};
-	static const char * const mcu_types_with_perip_resets[] = {
-		[STS_MCU_TYPE_STM32] = "STM32 (with peripheral resets)",
-		[STS_MCU_TYPE_GD32]  = "GD32 (with peripheral resets)",
-		[STS_MCU_TYPE_MKL]   = "MKL (with peripheral resets)",
-		[STS_MCU_TYPE_UNKN]  = "unknown (with peripheral resets)",
-	};
+	static char result[] = "xxxxxxx (with peripheral resets)";
 	u16 stsword, features;
 	int ret;
 
@@ -412,13 +362,28 @@ static const char * const omnia_get_mcu_type(void)
 	if (ret)
 		return "unknown";
 
+	switch (stsword & STS_MCU_TYPE_MASK) {
+	case STS_MCU_TYPE_STM32:
+		strcpy(result, "STM32");
+		break;
+	case STS_MCU_TYPE_GD32:
+		strcpy(result, "GD32");
+		break;
+	case STS_MCU_TYPE_MKL:
+		strcpy(result, "MKL");
+		break;
+	default:
+		strcpy(result, "unknown");
+		break;
+	}
+
 	if (stsword & STS_FEATURES_SUPPORTED) {
 		ret = omnia_mcu_read(CMD_GET_FEATURES, &features, sizeof(features));
 		if (ret == 0 && (features & FEAT_PERIPH_MCU))
-			return mcu_types_with_perip_resets[stsword & STS_MCU_TYPE_MASK];
+			strcat(result, " (with peripheral resets)");
 	}
 
-	return mcu_types[stsword & STS_MCU_TYPE_MASK];
+	return result;
 }
 
 static const char * const omnia_get_mcu_version(void)
diff --git a/drivers/gpio/turris_omnia_mcu.c b/drivers/gpio/turris_omnia_mcu.c
index 2d2bf2d1dd..da9a6efe6d 100644
--- a/drivers/gpio/turris_omnia_mcu.c
+++ b/drivers/gpio/turris_omnia_mcu.c
@@ -4,62 +4,10 @@
 #include <common.h>
 #include <dm.h>
 #include <i2c.h>
+#include <turris-omnia-mcu-interface.h>
 #include <asm/gpio.h>
 #include <linux/log2.h>
 
-enum commands_e {
-	CMD_GET_STATUS_WORD                 = 0x01,
-	CMD_GENERAL_CONTROL                 = 0x02,
-
-	/* available if STS_FEATURES_SUPPORTED bit set in status word */
-	CMD_GET_FEATURES                    = 0x10,
-
-	/* available if FEAT_EXT_CMDS bit is set in features */
-	CMD_GET_EXT_STATUS_DWORD            = 0x11,
-
-	/* available if FEAT_EXT_CMDS and FEAT_PERIPH_MCU bits are set in featurs */
-	CMD_EXT_CONTROL                     = 0x12,
-	CMD_GET_EXT_CONTROL_STATUS          = 0x13,
-};
-
-/* CMD_GET_STATUS_WORD */
-enum sts_word_e {
-	STS_MCU_TYPE_MASK                = GENMASK(1, 0),
-	STS_MCU_TYPE_STM32               = 0,
-	STS_MCU_TYPE_GD32                = 1,
-	STS_MCU_TYPE_MKL                 = 2,
-	STS_FEATURES_SUPPORTED           = BIT(2),
-	STS_USER_REGULATOR_NOT_SUPPORTED = BIT(3),
-	STS_CARD_DET                     = BIT(4),
-	STS_MSATA_IND                    = BIT(5),
-	STS_USB30_OVC                    = BIT(6),
-	STS_USB31_OVC                    = BIT(7),
-	STS_USB30_PWRON                  = BIT(8),
-	STS_USB31_PWRON                  = BIT(9),
-	STS_ENABLE_4V5                   = BIT(10),
-	STS_BUTTON_MODE                  = BIT(11),
-	STS_BUTTON_PRESSED               = BIT(12),
-	STS_BUTTON_COUNTER_MASK          = GENMASK(15, 13)
-};
-
-/* CMD_GENERAL_CONTROL */
-enum ctl_byte_e {
-	CTL_LIGHT_RST   = BIT(0),
-	CTL_HARD_RST    = BIT(1),
-	/*CTL_RESERVED    = BIT(2),*/
-	CTL_USB30_PWRON = BIT(3),
-	CTL_USB31_PWRON = BIT(4),
-	CTL_ENABLE_4V5  = BIT(5),
-	CTL_BUTTON_MODE = BIT(6),
-	CTL_BOOTLOADER  = BIT(7)
-};
-
-/* CMD_GET_FEATURES */
-enum features_e {
-	FEAT_PERIPH_MCU         = BIT(0),
-	FEAT_EXT_CMDS           = BIT(1),
-};
-
 struct turris_omnia_mcu_info {
 	u16 features;
 };
diff --git a/include/turris-omnia-mcu-interface.h b/include/turris-omnia-mcu-interface.h
new file mode 100644
index 0000000000..3c4638f732
--- /dev/null
+++ b/include/turris-omnia-mcu-interface.h
@@ -0,0 +1,248 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * CZ.NIC's Turris Omnia MCU I2C interface commands definitions
+ *
+ * 2023 by Marek Behún <kabel@kernel.org>
+ */
+
+#ifndef __TURRIS_OMNIA_MCU_INTERFACE_H
+#define __TURRIS_OMNIA_MCU_INTERFACE_H
+
+#include <linux/bitops.h>
+
+enum omnia_commands_e {
+	CMD_GET_STATUS_WORD		= 0x01, /* slave sends status word back */
+	CMD_GENERAL_CONTROL		= 0x02,
+	CMD_LED_MODE			= 0x03, /* default/user */
+	CMD_LED_STATE			= 0x04, /* LED on/off */
+	CMD_LED_COLOR			= 0x05, /* LED number + RED + GREEN + BLUE */
+	CMD_USER_VOLTAGE		= 0x06,
+	CMD_SET_BRIGHTNESS		= 0x07,
+	CMD_GET_BRIGHTNESS		= 0x08,
+	CMD_GET_RESET			= 0x09,
+	CMD_GET_FW_VERSION_APP		= 0x0A, /* 20B git hash number */
+	CMD_SET_WATCHDOG_STATE		= 0x0B, /* 0 - disable
+						 * 1 - enable / ping
+						 * after boot watchdog is started
+						 * with 2 minutes timeout
+						 */
+
+	/* CMD_WATCHDOG_STATUS		= 0x0C, not implemented anymore */
+
+	CMD_GET_WATCHDOG_STATE		= 0x0D,
+	CMD_GET_FW_VERSION_BOOT		= 0x0E, /* 20B git hash number */
+	CMD_GET_FW_CHECKSUM		= 0x0F, /* 4B length, 4B checksum */
+
+	/* available if FEATURES_SUPPORTED bit set in status word */
+	CMD_GET_FEATURES		= 0x10,
+
+	/* available if EXT_CMD bit set in features */
+	CMD_GET_EXT_STATUS_DWORD	= 0x11,
+	CMD_EXT_CONTROL			= 0x12,
+	CMD_GET_EXT_CONTROL_STATUS	= 0x13,
+
+	/* available if NEW_INT_API bit set in features */
+	CMD_GET_INT_AND_CLEAR		= 0x14,
+	CMD_GET_INT_MASK		= 0x15,
+	CMD_SET_INT_MASK		= 0x16,
+
+	/* available if FLASHING bit set in features */
+	CMD_FLASH			= 0x19,
+
+	/* available if WDT_PING bit set in features */
+	CMD_SET_WDT_TIMEOUT		= 0x20,
+	CMD_GET_WDT_TIMELEFT		= 0x21,
+
+	/* available if POWEROFF_WAKEUP bit set in features */
+	CMD_SET_WAKEUP			= 0x22,
+	CMD_GET_UPTIME_AND_WAKEUP	= 0x23,
+	CMD_POWER_OFF			= 0x24,
+
+	/* available if USB_OVC_PROT_SETTING bit set in features */
+	CMD_SET_USB_OVC_PROT		= 0x25,
+	CMD_GET_USB_OVC_PROT		= 0x26,
+
+	/* available if TRNG bit set in features */
+	CMD_TRNG_COLLECT_ENTROPY	= 0x28,
+
+	/* available if CRYPTO bit set in features */
+	CMD_CRYPTO_GET_PUBLIC_KEY	= 0x29,
+	CMD_CRYPTO_SIGN_MESSAGE		= 0x2A,
+	CMD_CRYPTO_COLLECT_SIGNATURE	= 0x2B,
+
+	/* available if BOARD_INFO it set in features */
+	CMD_BOARD_INFO_GET		= 0x2C,
+	CMD_BOARD_INFO_BURN		= 0x2D,
+
+	/* available only at address 0x2b (led-controller) */
+	/* available only if LED_GAMMA_CORRECTION bit set in features */
+	CMD_SET_GAMMA_CORRECTION	= 0x30,
+	CMD_GET_GAMMA_CORRECTION	= 0x31,
+
+	/* available only at address 0x2b (led-controller) */
+	/* available only if PER_LED_CORRECTION bit set in features */
+	/* available only if FROM_BIT_16_INVALID bit NOT set in features */
+	CMD_SET_LED_CORRECTIONS		= 0x32,
+	CMD_GET_LED_CORRECTIONS		= 0x33,
+};
+
+enum omnia_flashing_commands_e {
+	FLASH_CMD_UNLOCK		= 0x01,
+	FLASH_CMD_SIZE_AND_CSUM		= 0x02,
+	FLASH_CMD_PROGRAM		= 0x03,
+	FLASH_CMD_RESET			= 0x04,
+};
+
+enum omnia_sts_word_e {
+	STS_MCU_TYPE_MASK			= GENMASK(1, 0),
+	STS_MCU_TYPE_STM32			= 0 << 0,
+	STS_MCU_TYPE_GD32			= 1 << 0,
+	STS_MCU_TYPE_MKL			= 2 << 0,
+	STS_FEATURES_SUPPORTED			= BIT(2),
+	STS_USER_REGULATOR_NOT_SUPPORTED	= BIT(3),
+	STS_CARD_DET				= BIT(4),
+	STS_MSATA_IND				= BIT(5),
+	STS_USB30_OVC				= BIT(6),
+	STS_USB31_OVC				= BIT(7),
+	STS_USB30_PWRON				= BIT(8),
+	STS_USB31_PWRON				= BIT(9),
+	STS_ENABLE_4V5				= BIT(10),
+	STS_BUTTON_MODE				= BIT(11),
+	STS_BUTTON_PRESSED			= BIT(12),
+	STS_BUTTON_COUNTER_MASK			= GENMASK(15, 13)
+};
+
+enum omnia_ctl_byte_e {
+	CTL_LIGHT_RST		= BIT(0),
+	CTL_HARD_RST		= BIT(1),
+	/* BIT(2) is currently reserved */
+	CTL_USB30_PWRON		= BIT(3),
+	CTL_USB31_PWRON		= BIT(4),
+	CTL_ENABLE_4V5		= BIT(5),
+	CTL_BUTTON_MODE		= BIT(6),
+	CTL_BOOTLOADER		= BIT(7)
+};
+
+enum omnia_features_e {
+	FEAT_PERIPH_MCU			= BIT(0),
+	FEAT_EXT_CMDS			= BIT(1),
+	FEAT_WDT_PING			= BIT(2),
+	FEAT_LED_STATE_EXT_MASK		= GENMASK(4, 3),
+	FEAT_LED_STATE_EXT		= 1 << 3,
+	FEAT_LED_STATE_EXT_V32		= 2 << 3,
+	FEAT_LED_GAMMA_CORRECTION	= BIT(5),
+	FEAT_NEW_INT_API		= BIT(6),
+	FEAT_BOOTLOADER			= BIT(7),
+	FEAT_FLASHING			= BIT(8),
+	FEAT_NEW_MESSAGE_API		= BIT(9),
+	FEAT_BRIGHTNESS_INT		= BIT(10),
+	FEAT_POWEROFF_WAKEUP		= BIT(11),
+	FEAT_CAN_OLD_MESSAGE_API	= BIT(12),
+	FEAT_TRNG			= BIT(13),
+	FEAT_CRYPTO			= BIT(14),
+	FEAT_BOARD_INFO			= BIT(15),
+
+	/*
+	 * Orginally the features command replied only 16 bits. If more were
+	 * read, either the I2C transaction failed or 0xff bytes were sent.
+	 * Therefore to consider bits 16 - 31 valid, one bit (20) was reserved
+	 * to be zero.
+	 */
+
+	/* Bits 16 - 19 correspond to bits 0 - 3 of status word */
+	FEAT_MCU_TYPE_MASK		= GENMASK(17, 16),
+	FEAT_MCU_TYPE_STM32		= 0 << 16,
+	FEAT_MCU_TYPE_GD32		= 1 << 16,
+	FEAT_MCU_TYPE_MKL		= 2 << 16,
+	FEAT_FEATURES_SUPPORTED		= BIT(18),
+	FEAT_USER_REGULATOR_NOT_SUPPORTED = BIT(19),
+
+	/* must not be set */
+	FEAT_FROM_BIT_16_INVALID	= BIT(20),
+
+	FEAT_PER_LED_CORRECTION		= BIT(21),
+	FEAT_USB_OVC_PROT_SETTING	= BIT(22),
+};
+
+enum omnia_ext_sts_dword_e {
+	EXT_STS_SFP_nDET		= BIT(0),
+	EXT_STS_LED_STATES_MASK		= GENMASK(31, 12),
+	EXT_STS_WLAN0_MSATA_LED		= BIT(12),
+	EXT_STS_WLAN1_LED		= BIT(13),
+	EXT_STS_WLAN2_LED		= BIT(14),
+	EXT_STS_WPAN0_LED		= BIT(15),
+	EXT_STS_WPAN1_LED		= BIT(16),
+	EXT_STS_WPAN2_LED		= BIT(17),
+	EXT_STS_WAN_LED0		= BIT(18),
+	EXT_STS_WAN_LED1		= BIT(19),
+	EXT_STS_LAN0_LED0		= BIT(20),
+	EXT_STS_LAN0_LED1		= BIT(21),
+	EXT_STS_LAN1_LED0		= BIT(22),
+	EXT_STS_LAN1_LED1		= BIT(23),
+	EXT_STS_LAN2_LED0		= BIT(24),
+	EXT_STS_LAN2_LED1		= BIT(25),
+	EXT_STS_LAN3_LED0		= BIT(26),
+	EXT_STS_LAN3_LED1		= BIT(27),
+	EXT_STS_LAN4_LED0		= BIT(28),
+	EXT_STS_LAN4_LED1		= BIT(29),
+	EXT_STS_LAN5_LED0		= BIT(30),
+	EXT_STS_LAN5_LED1		= BIT(31),
+};
+
+enum omnia_ext_ctl_e {
+	EXT_CTL_nRES_MMC		= BIT(0),
+	EXT_CTL_nRES_LAN		= BIT(1),
+	EXT_CTL_nRES_PHY		= BIT(2),
+	EXT_CTL_nPERST0			= BIT(3),
+	EXT_CTL_nPERST1			= BIT(4),
+	EXT_CTL_nPERST2			= BIT(5),
+	EXT_CTL_PHY_SFP			= BIT(6),
+	EXT_CTL_PHY_SFP_AUTO		= BIT(7),
+	EXT_CTL_nVHV_CTRL		= BIT(8),
+};
+
+enum omnia_int_e {
+	INT_CARD_DET		= BIT(0),
+	INT_MSATA_IND		= BIT(1),
+	INT_USB30_OVC		= BIT(2),
+	INT_USB31_OVC		= BIT(3),
+	INT_BUTTON_PRESSED	= BIT(4),
+	INT_SFP_nDET		= BIT(5),
+	INT_BRIGHTNESS_CHANGED	= BIT(6),
+	INT_TRNG		= BIT(7),
+	INT_MESSAGE_SIGNED	= BIT(8),
+
+	INT_LED_STATES_MASK	= GENMASK(31, 12),
+	INT_WLAN0_MSATA_LED	= BIT(12),
+	INT_WLAN1_LED		= BIT(13),
+	INT_WLAN2_LED		= BIT(14),
+	INT_WPAN0_LED		= BIT(15),
+	INT_WPAN1_LED		= BIT(16),
+	INT_WPAN2_LED		= BIT(17),
+	INT_WAN_LED0		= BIT(18),
+	INT_WAN_LED1		= BIT(19),
+	INT_LAN0_LED0		= BIT(20),
+	INT_LAN0_LED1		= BIT(21),
+	INT_LAN1_LED0		= BIT(22),
+	INT_LAN1_LED1		= BIT(23),
+	INT_LAN2_LED0		= BIT(24),
+	INT_LAN2_LED1		= BIT(25),
+	INT_LAN3_LED0		= BIT(26),
+	INT_LAN3_LED1		= BIT(27),
+	INT_LAN4_LED0		= BIT(28),
+	INT_LAN4_LED1		= BIT(29),
+	INT_LAN5_LED0		= BIT(30),
+	INT_LAN5_LED1		= BIT(31),
+};
+
+enum omnia_cmd_poweroff_e {
+	CMD_POWER_OFF_POWERON_BUTTON	= BIT(0),
+	CMD_POWER_OFF_MAGIC		= 0xdead,
+};
+
+enum cmd_usb_ovc_prot_e {
+	CMD_xET_USB_OVC_PROT_PORT_MASK	= GENMASK(3, 0),
+	CMD_xET_USB_OVC_PROT_ENABLE	= BIT(4),
+};
+
+#endif /* __TURRIS_OMNIA_MCU_INTERFACE_H */
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 02/18] arm: mvebu: turris_omnia: Add header containing MCU command interface and use it

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Add header containing all MCU command definitions and use it in board
> code and in MCU driver.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   board/CZ.NIC/turris_omnia/turris_omnia.c |  81 +++-----
>   drivers/gpio/turris_omnia_mcu.c          |  54 +----
>   include/turris-omnia-mcu-interface.h     | 248 +++++++++++++++++++++++
>   3 files changed, 272 insertions(+), 111 deletions(-)
>   create mode 100644 include/turris-omnia-mcu-interface.h
> 
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index adeb69a205..6c2d7da528 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -23,6 +23,7 @@
>   #include <fdt_support.h>
>   #include <hexdump.h>
>   #include <time.h>
> +#include <turris-omnia-mcu-interface.h>
>   #include <linux/bitops.h>
>   #include <linux/delay.h>
>   #include <u-boot/crc.h>
> @@ -59,46 +60,6 @@ DECLARE_GLOBAL_DATA_PTR;
>   #define A385_WD_RSTOUT_UNMASK		MVEBU_REGISTER(0x20704)
>   #define   A385_WD_RSTOUT_UNMASK_GLOBAL	BIT(8)
>   
> -enum mcu_commands {
> -	CMD_GET_STATUS_WORD	= 0x01,
> -	CMD_GET_RESET		= 0x09,
> -	CMD_GET_FW_VERSION_APP	= 0x0a,
> -	CMD_WATCHDOG_STATE	= 0x0b,
> -	CMD_GET_FW_VERSION_BOOT	= 0x0e,
> -
> -	/* available if STS_FEATURES_SUPPORTED bit set in status word */
> -	CMD_GET_FEATURES	= 0x10,
> -
> -	/* available if EXT_CMD bit set in features */
> -	CMD_EXT_CONTROL		= 0x12,
> -};
> -
> -enum status_word_bits {
> -	STS_MCU_TYPE_MASK	= GENMASK(1, 0),
> -	STS_MCU_TYPE_STM32	= 0,
> -	STS_MCU_TYPE_GD32	= 1,
> -	STS_MCU_TYPE_MKL	= 2,
> -	STS_MCU_TYPE_UNKN	= 3,
> -	STS_FEATURES_SUPPORTED	= BIT(2),
> -	CARD_DET_STSBIT		= 0x0010,
> -	MSATA_IND_STSBIT	= 0x0020,
> -};
> -
> -/* CMD_GET_FEATURES */
> -enum features_e {
> -	FEAT_PERIPH_MCU		= BIT(0),
> -	FEAT_EXT_CMDS		= BIT(1),
> -};
> -
> -/* CMD_EXT_CONTROL */
> -enum ext_ctl_e {
> -	EXT_CTL_nRES_LAN	= BIT(1),
> -	EXT_CTL_nRES_PHY	= BIT(2),
> -	EXT_CTL_nPERST0		= BIT(3),
> -	EXT_CTL_nPERST1		= BIT(4),
> -	EXT_CTL_nPERST2		= BIT(5),
> -};
> -
>   /*
>    * Those values and defines are taken from the Marvell U-Boot version
>    * "u-boot-2013.01-2014_T3.0"
> @@ -219,7 +180,7 @@ static bool disable_mcu_watchdog(void)
>   
>   	puts("Disabling MCU watchdog... ");
>   
> -	ret = omnia_mcu_write(CMD_WATCHDOG_STATE, "\x00", 1);
> +	ret = omnia_mcu_write(CMD_SET_WATCHDOG_STATE, "\x00", 1);
>   	if (ret) {
>   		printf("omnia_mcu_write failed: %i\n", ret);
>   		return false;
> @@ -256,17 +217,17 @@ static bool omnia_detect_sata(const char *msata_slot)
>   		return false;
>   	}
>   
> -	if (!(stsword & CARD_DET_STSBIT)) {
> +	if (!(stsword & STS_CARD_DET)) {
>   		puts("none\n");
>   		return false;
>   	}
>   
> -	if (stsword & MSATA_IND_STSBIT)
> +	if (stsword & STS_MSATA_IND)
>   		puts("mSATA\n");
>   	else
>   		puts("MiniPCIe\n");
>   
> -	return stsword & MSATA_IND_STSBIT ? true : false;
> +	return stsword & STS_MSATA_IND;
>   }
>   
>   static bool omnia_detect_wwan_usb3(const char *wwan_slot)
> @@ -393,18 +354,7 @@ static int omnia_get_ram_size_gb(void)
>   
>   static const char * const omnia_get_mcu_type(void)
>   {
> -	static const char * const mcu_types[] = {
> -		[STS_MCU_TYPE_STM32] = "STM32",
> -		[STS_MCU_TYPE_GD32]  = "GD32",
> -		[STS_MCU_TYPE_MKL]   = "MKL",
> -		[STS_MCU_TYPE_UNKN]  = "unknown",
> -	};
> -	static const char * const mcu_types_with_perip_resets[] = {
> -		[STS_MCU_TYPE_STM32] = "STM32 (with peripheral resets)",
> -		[STS_MCU_TYPE_GD32]  = "GD32 (with peripheral resets)",
> -		[STS_MCU_TYPE_MKL]   = "MKL (with peripheral resets)",
> -		[STS_MCU_TYPE_UNKN]  = "unknown (with peripheral resets)",
> -	};
> +	static char result[] = "xxxxxxx (with peripheral resets)";
>   	u16 stsword, features;
>   	int ret;
>   
> @@ -412,13 +362,28 @@ static const char * const omnia_get_mcu_type(void)
>   	if (ret)
>   		return "unknown";
>   
> +	switch (stsword & STS_MCU_TYPE_MASK) {
> +	case STS_MCU_TYPE_STM32:
> +		strcpy(result, "STM32");
> +		break;
> +	case STS_MCU_TYPE_GD32:
> +		strcpy(result, "GD32");
> +		break;
> +	case STS_MCU_TYPE_MKL:
> +		strcpy(result, "MKL");
> +		break;
> +	default:
> +		strcpy(result, "unknown");
> +		break;
> +	}
> +
>   	if (stsword & STS_FEATURES_SUPPORTED) {
>   		ret = omnia_mcu_read(CMD_GET_FEATURES, &features, sizeof(features));
>   		if (ret == 0 && (features & FEAT_PERIPH_MCU))
> -			return mcu_types_with_perip_resets[stsword & STS_MCU_TYPE_MASK];
> +			strcat(result, " (with peripheral resets)");
>   	}
>   
> -	return mcu_types[stsword & STS_MCU_TYPE_MASK];
> +	return result;
>   }
>   
>   static const char * const omnia_get_mcu_version(void)
> diff --git a/drivers/gpio/turris_omnia_mcu.c b/drivers/gpio/turris_omnia_mcu.c
> index 2d2bf2d1dd..da9a6efe6d 100644
> --- a/drivers/gpio/turris_omnia_mcu.c
> +++ b/drivers/gpio/turris_omnia_mcu.c
> @@ -4,62 +4,10 @@
>   #include <common.h>
>   #include <dm.h>
>   #include <i2c.h>
> +#include <turris-omnia-mcu-interface.h>
>   #include <asm/gpio.h>
>   #include <linux/log2.h>
>   
> -enum commands_e {
> -	CMD_GET_STATUS_WORD                 = 0x01,
> -	CMD_GENERAL_CONTROL                 = 0x02,
> -
> -	/* available if STS_FEATURES_SUPPORTED bit set in status word */
> -	CMD_GET_FEATURES                    = 0x10,
> -
> -	/* available if FEAT_EXT_CMDS bit is set in features */
> -	CMD_GET_EXT_STATUS_DWORD            = 0x11,
> -
> -	/* available if FEAT_EXT_CMDS and FEAT_PERIPH_MCU bits are set in featurs */
> -	CMD_EXT_CONTROL                     = 0x12,
> -	CMD_GET_EXT_CONTROL_STATUS          = 0x13,
> -};
> -
> -/* CMD_GET_STATUS_WORD */
> -enum sts_word_e {
> -	STS_MCU_TYPE_MASK                = GENMASK(1, 0),
> -	STS_MCU_TYPE_STM32               = 0,
> -	STS_MCU_TYPE_GD32                = 1,
> -	STS_MCU_TYPE_MKL                 = 2,
> -	STS_FEATURES_SUPPORTED           = BIT(2),
> -	STS_USER_REGULATOR_NOT_SUPPORTED = BIT(3),
> -	STS_CARD_DET                     = BIT(4),
> -	STS_MSATA_IND                    = BIT(5),
> -	STS_USB30_OVC                    = BIT(6),
> -	STS_USB31_OVC                    = BIT(7),
> -	STS_USB30_PWRON                  = BIT(8),
> -	STS_USB31_PWRON                  = BIT(9),
> -	STS_ENABLE_4V5                   = BIT(10),
> -	STS_BUTTON_MODE                  = BIT(11),
> -	STS_BUTTON_PRESSED               = BIT(12),
> -	STS_BUTTON_COUNTER_MASK          = GENMASK(15, 13)
> -};
> -
> -/* CMD_GENERAL_CONTROL */
> -enum ctl_byte_e {
> -	CTL_LIGHT_RST   = BIT(0),
> -	CTL_HARD_RST    = BIT(1),
> -	/*CTL_RESERVED    = BIT(2),*/
> -	CTL_USB30_PWRON = BIT(3),
> -	CTL_USB31_PWRON = BIT(4),
> -	CTL_ENABLE_4V5  = BIT(5),
> -	CTL_BUTTON_MODE = BIT(6),
> -	CTL_BOOTLOADER  = BIT(7)
> -};
> -
> -/* CMD_GET_FEATURES */
> -enum features_e {
> -	FEAT_PERIPH_MCU         = BIT(0),
> -	FEAT_EXT_CMDS           = BIT(1),
> -};
> -
>   struct turris_omnia_mcu_info {
>   	u16 features;
>   };
> diff --git a/include/turris-omnia-mcu-interface.h b/include/turris-omnia-mcu-interface.h
> new file mode 100644
> index 0000000000..3c4638f732
> --- /dev/null
> +++ b/include/turris-omnia-mcu-interface.h
> @@ -0,0 +1,248 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * CZ.NIC's Turris Omnia MCU I2C interface commands definitions
> + *
> + * 2023 by Marek Behún <kabel@kernel.org>
> + */
> +
> +#ifndef __TURRIS_OMNIA_MCU_INTERFACE_H
> +#define __TURRIS_OMNIA_MCU_INTERFACE_H
> +
> +#include <linux/bitops.h>
> +
> +enum omnia_commands_e {
> +	CMD_GET_STATUS_WORD		= 0x01, /* slave sends status word back */
> +	CMD_GENERAL_CONTROL		= 0x02,
> +	CMD_LED_MODE			= 0x03, /* default/user */
> +	CMD_LED_STATE			= 0x04, /* LED on/off */
> +	CMD_LED_COLOR			= 0x05, /* LED number + RED + GREEN + BLUE */
> +	CMD_USER_VOLTAGE		= 0x06,
> +	CMD_SET_BRIGHTNESS		= 0x07,
> +	CMD_GET_BRIGHTNESS		= 0x08,
> +	CMD_GET_RESET			= 0x09,
> +	CMD_GET_FW_VERSION_APP		= 0x0A, /* 20B git hash number */
> +	CMD_SET_WATCHDOG_STATE		= 0x0B, /* 0 - disable
> +						 * 1 - enable / ping
> +						 * after boot watchdog is started
> +						 * with 2 minutes timeout
> +						 */
> +
> +	/* CMD_WATCHDOG_STATUS		= 0x0C, not implemented anymore */
> +
> +	CMD_GET_WATCHDOG_STATE		= 0x0D,
> +	CMD_GET_FW_VERSION_BOOT		= 0x0E, /* 20B git hash number */
> +	CMD_GET_FW_CHECKSUM		= 0x0F, /* 4B length, 4B checksum */
> +
> +	/* available if FEATURES_SUPPORTED bit set in status word */
> +	CMD_GET_FEATURES		= 0x10,
> +
> +	/* available if EXT_CMD bit set in features */
> +	CMD_GET_EXT_STATUS_DWORD	= 0x11,
> +	CMD_EXT_CONTROL			= 0x12,
> +	CMD_GET_EXT_CONTROL_STATUS	= 0x13,
> +
> +	/* available if NEW_INT_API bit set in features */
> +	CMD_GET_INT_AND_CLEAR		= 0x14,
> +	CMD_GET_INT_MASK		= 0x15,
> +	CMD_SET_INT_MASK		= 0x16,
> +
> +	/* available if FLASHING bit set in features */
> +	CMD_FLASH			= 0x19,
> +
> +	/* available if WDT_PING bit set in features */
> +	CMD_SET_WDT_TIMEOUT		= 0x20,
> +	CMD_GET_WDT_TIMELEFT		= 0x21,
> +
> +	/* available if POWEROFF_WAKEUP bit set in features */
> +	CMD_SET_WAKEUP			= 0x22,
> +	CMD_GET_UPTIME_AND_WAKEUP	= 0x23,
> +	CMD_POWER_OFF			= 0x24,
> +
> +	/* available if USB_OVC_PROT_SETTING bit set in features */
> +	CMD_SET_USB_OVC_PROT		= 0x25,
> +	CMD_GET_USB_OVC_PROT		= 0x26,
> +
> +	/* available if TRNG bit set in features */
> +	CMD_TRNG_COLLECT_ENTROPY	= 0x28,
> +
> +	/* available if CRYPTO bit set in features */
> +	CMD_CRYPTO_GET_PUBLIC_KEY	= 0x29,
> +	CMD_CRYPTO_SIGN_MESSAGE		= 0x2A,
> +	CMD_CRYPTO_COLLECT_SIGNATURE	= 0x2B,
> +
> +	/* available if BOARD_INFO it set in features */
> +	CMD_BOARD_INFO_GET		= 0x2C,
> +	CMD_BOARD_INFO_BURN		= 0x2D,
> +
> +	/* available only at address 0x2b (led-controller) */
> +	/* available only if LED_GAMMA_CORRECTION bit set in features */
> +	CMD_SET_GAMMA_CORRECTION	= 0x30,
> +	CMD_GET_GAMMA_CORRECTION	= 0x31,
> +
> +	/* available only at address 0x2b (led-controller) */
> +	/* available only if PER_LED_CORRECTION bit set in features */
> +	/* available only if FROM_BIT_16_INVALID bit NOT set in features */
> +	CMD_SET_LED_CORRECTIONS		= 0x32,
> +	CMD_GET_LED_CORRECTIONS		= 0x33,
> +};
> +
> +enum omnia_flashing_commands_e {
> +	FLASH_CMD_UNLOCK		= 0x01,
> +	FLASH_CMD_SIZE_AND_CSUM		= 0x02,
> +	FLASH_CMD_PROGRAM		= 0x03,
> +	FLASH_CMD_RESET			= 0x04,
> +};
> +
> +enum omnia_sts_word_e {
> +	STS_MCU_TYPE_MASK			= GENMASK(1, 0),
> +	STS_MCU_TYPE_STM32			= 0 << 0,
> +	STS_MCU_TYPE_GD32			= 1 << 0,
> +	STS_MCU_TYPE_MKL			= 2 << 0,
> +	STS_FEATURES_SUPPORTED			= BIT(2),
> +	STS_USER_REGULATOR_NOT_SUPPORTED	= BIT(3),
> +	STS_CARD_DET				= BIT(4),
> +	STS_MSATA_IND				= BIT(5),
> +	STS_USB30_OVC				= BIT(6),
> +	STS_USB31_OVC				= BIT(7),
> +	STS_USB30_PWRON				= BIT(8),
> +	STS_USB31_PWRON				= BIT(9),
> +	STS_ENABLE_4V5				= BIT(10),
> +	STS_BUTTON_MODE				= BIT(11),
> +	STS_BUTTON_PRESSED			= BIT(12),
> +	STS_BUTTON_COUNTER_MASK			= GENMASK(15, 13)
> +};
> +
> +enum omnia_ctl_byte_e {
> +	CTL_LIGHT_RST		= BIT(0),
> +	CTL_HARD_RST		= BIT(1),
> +	/* BIT(2) is currently reserved */
> +	CTL_USB30_PWRON		= BIT(3),
> +	CTL_USB31_PWRON		= BIT(4),
> +	CTL_ENABLE_4V5		= BIT(5),
> +	CTL_BUTTON_MODE		= BIT(6),
> +	CTL_BOOTLOADER		= BIT(7)
> +};
> +
> +enum omnia_features_e {
> +	FEAT_PERIPH_MCU			= BIT(0),
> +	FEAT_EXT_CMDS			= BIT(1),
> +	FEAT_WDT_PING			= BIT(2),
> +	FEAT_LED_STATE_EXT_MASK		= GENMASK(4, 3),
> +	FEAT_LED_STATE_EXT		= 1 << 3,
> +	FEAT_LED_STATE_EXT_V32		= 2 << 3,
> +	FEAT_LED_GAMMA_CORRECTION	= BIT(5),
> +	FEAT_NEW_INT_API		= BIT(6),
> +	FEAT_BOOTLOADER			= BIT(7),
> +	FEAT_FLASHING			= BIT(8),
> +	FEAT_NEW_MESSAGE_API		= BIT(9),
> +	FEAT_BRIGHTNESS_INT		= BIT(10),
> +	FEAT_POWEROFF_WAKEUP		= BIT(11),
> +	FEAT_CAN_OLD_MESSAGE_API	= BIT(12),
> +	FEAT_TRNG			= BIT(13),
> +	FEAT_CRYPTO			= BIT(14),
> +	FEAT_BOARD_INFO			= BIT(15),
> +
> +	/*
> +	 * Orginally the features command replied only 16 bits. If more were
> +	 * read, either the I2C transaction failed or 0xff bytes were sent.
> +	 * Therefore to consider bits 16 - 31 valid, one bit (20) was reserved
> +	 * to be zero.
> +	 */
> +
> +	/* Bits 16 - 19 correspond to bits 0 - 3 of status word */
> +	FEAT_MCU_TYPE_MASK		= GENMASK(17, 16),
> +	FEAT_MCU_TYPE_STM32		= 0 << 16,
> +	FEAT_MCU_TYPE_GD32		= 1 << 16,
> +	FEAT_MCU_TYPE_MKL		= 2 << 16,
> +	FEAT_FEATURES_SUPPORTED		= BIT(18),
> +	FEAT_USER_REGULATOR_NOT_SUPPORTED = BIT(19),
> +
> +	/* must not be set */
> +	FEAT_FROM_BIT_16_INVALID	= BIT(20),
> +
> +	FEAT_PER_LED_CORRECTION		= BIT(21),
> +	FEAT_USB_OVC_PROT_SETTING	= BIT(22),
> +};
> +
> +enum omnia_ext_sts_dword_e {
> +	EXT_STS_SFP_nDET		= BIT(0),
> +	EXT_STS_LED_STATES_MASK		= GENMASK(31, 12),
> +	EXT_STS_WLAN0_MSATA_LED		= BIT(12),
> +	EXT_STS_WLAN1_LED		= BIT(13),
> +	EXT_STS_WLAN2_LED		= BIT(14),
> +	EXT_STS_WPAN0_LED		= BIT(15),
> +	EXT_STS_WPAN1_LED		= BIT(16),
> +	EXT_STS_WPAN2_LED		= BIT(17),
> +	EXT_STS_WAN_LED0		= BIT(18),
> +	EXT_STS_WAN_LED1		= BIT(19),
> +	EXT_STS_LAN0_LED0		= BIT(20),
> +	EXT_STS_LAN0_LED1		= BIT(21),
> +	EXT_STS_LAN1_LED0		= BIT(22),
> +	EXT_STS_LAN1_LED1		= BIT(23),
> +	EXT_STS_LAN2_LED0		= BIT(24),
> +	EXT_STS_LAN2_LED1		= BIT(25),
> +	EXT_STS_LAN3_LED0		= BIT(26),
> +	EXT_STS_LAN3_LED1		= BIT(27),
> +	EXT_STS_LAN4_LED0		= BIT(28),
> +	EXT_STS_LAN4_LED1		= BIT(29),
> +	EXT_STS_LAN5_LED0		= BIT(30),
> +	EXT_STS_LAN5_LED1		= BIT(31),
> +};
> +
> +enum omnia_ext_ctl_e {
> +	EXT_CTL_nRES_MMC		= BIT(0),
> +	EXT_CTL_nRES_LAN		= BIT(1),
> +	EXT_CTL_nRES_PHY		= BIT(2),
> +	EXT_CTL_nPERST0			= BIT(3),
> +	EXT_CTL_nPERST1			= BIT(4),
> +	EXT_CTL_nPERST2			= BIT(5),
> +	EXT_CTL_PHY_SFP			= BIT(6),
> +	EXT_CTL_PHY_SFP_AUTO		= BIT(7),
> +	EXT_CTL_nVHV_CTRL		= BIT(8),
> +};
> +
> +enum omnia_int_e {
> +	INT_CARD_DET		= BIT(0),
> +	INT_MSATA_IND		= BIT(1),
> +	INT_USB30_OVC		= BIT(2),
> +	INT_USB31_OVC		= BIT(3),
> +	INT_BUTTON_PRESSED	= BIT(4),
> +	INT_SFP_nDET		= BIT(5),
> +	INT_BRIGHTNESS_CHANGED	= BIT(6),
> +	INT_TRNG		= BIT(7),
> +	INT_MESSAGE_SIGNED	= BIT(8),
> +
> +	INT_LED_STATES_MASK	= GENMASK(31, 12),
> +	INT_WLAN0_MSATA_LED	= BIT(12),
> +	INT_WLAN1_LED		= BIT(13),
> +	INT_WLAN2_LED		= BIT(14),
> +	INT_WPAN0_LED		= BIT(15),
> +	INT_WPAN1_LED		= BIT(16),
> +	INT_WPAN2_LED		= BIT(17),
> +	INT_WAN_LED0		= BIT(18),
> +	INT_WAN_LED1		= BIT(19),
> +	INT_LAN0_LED0		= BIT(20),
> +	INT_LAN0_LED1		= BIT(21),
> +	INT_LAN1_LED0		= BIT(22),
> +	INT_LAN1_LED1		= BIT(23),
> +	INT_LAN2_LED0		= BIT(24),
> +	INT_LAN2_LED1		= BIT(25),
> +	INT_LAN3_LED0		= BIT(26),
> +	INT_LAN3_LED1		= BIT(27),
> +	INT_LAN4_LED0		= BIT(28),
> +	INT_LAN4_LED1		= BIT(29),
> +	INT_LAN5_LED0		= BIT(30),
> +	INT_LAN5_LED1		= BIT(31),
> +};
> +
> +enum omnia_cmd_poweroff_e {
> +	CMD_POWER_OFF_POWERON_BUTTON	= BIT(0),
> +	CMD_POWER_OFF_MAGIC		= 0xdead,
> +};
> +
> +enum cmd_usb_ovc_prot_e {
> +	CMD_xET_USB_OVC_PROT_PORT_MASK	= GENMASK(3, 0),
> +	CMD_xET_USB_OVC_PROT_ENABLE	= BIT(4),
> +};
> +
> +#endif /* __TURRIS_OMNIA_MCU_INTERFACE_H */

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 03/18] arm: mvebu: turris_{omnia, mox}: Don't print model two times

[Marek Behún]

Since commit 8cd4bf7dc9ba ("turris: Use checkboard() instead of
show_board_info()") the model is show two times during boot:
  Model: Turris Omnia
  Model: Turris Omnia

This is because the common function show_board_info() shows it, and
Turris' checkboard() also does.

Remove the second print.

Fixes: 8cd4bf7dc9ba ("turris: Use checkboard() instead of show_board_info()")
Signed-off-by: Marek Behún <kabel@kernel.org>
---
 board/CZ.NIC/turris_mox/turris_mox.c     | 5 +----
 board/CZ.NIC/turris_omnia/turris_omnia.c | 1 -
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/board/CZ.NIC/turris_mox/turris_mox.c b/board/CZ.NIC/turris_mox/turris_mox.c
index 3489bdd74b..1a2f60e3d1 100644
--- a/board/CZ.NIC/turris_mox/turris_mox.c
+++ b/board/CZ.NIC/turris_mox/turris_mox.c
@@ -565,13 +565,10 @@ static void handle_reset_button(void)
 int checkboard(void)
 {
 	int i, ret, board_version, ram_size, is_sd;
-	const char *pub_key, *model;
+	const char *pub_key;
 	const u8 *topology;
 	u64 serial_number;
 
-	model = fdt_getprop(gd->fdt_blob, 0, "model", NULL);
-	printf("Model: %s\n", model);
-
 	ret = mbox_sp_get_board_info(&serial_number, NULL, NULL, &board_version,
 				     &ram_size, NULL);
 	if (ret < 0) {
diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
index 6c2d7da528..87e33d88c4 100644
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c
+++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
@@ -933,7 +933,6 @@ int checkboard(void)
 	int err;
 
 	err = turris_atsha_otp_get_serial_number(serial);
-	printf("Model: Turris Omnia\n");
 	printf("  MCU type: %s\n", omnia_get_mcu_type());
 	printf("  MCU version: %s\n", omnia_get_mcu_version());
 	printf("  RAM size: %i MiB\n", omnia_get_ram_size_gb() * 1024);
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 03/18] arm: mvebu: turris_{omnia, mox}: Don't print model two times

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Since commit 8cd4bf7dc9ba ("turris: Use checkboard() instead of
> show_board_info()") the model is show two times during boot:
>    Model: Turris Omnia
>    Model: Turris Omnia
> 
> This is because the common function show_board_info() shows it, and
> Turris' checkboard() also does.
> 
> Remove the second print.
> 
> Fixes: 8cd4bf7dc9ba ("turris: Use checkboard() instead of show_board_info()")
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   board/CZ.NIC/turris_mox/turris_mox.c     | 5 +----
>   board/CZ.NIC/turris_omnia/turris_omnia.c | 1 -
>   2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/board/CZ.NIC/turris_mox/turris_mox.c b/board/CZ.NIC/turris_mox/turris_mox.c
> index 3489bdd74b..1a2f60e3d1 100644
> --- a/board/CZ.NIC/turris_mox/turris_mox.c
> +++ b/board/CZ.NIC/turris_mox/turris_mox.c
> @@ -565,13 +565,10 @@ static void handle_reset_button(void)
>   int checkboard(void)
>   {
>   	int i, ret, board_version, ram_size, is_sd;
> -	const char *pub_key, *model;
> +	const char *pub_key;
>   	const u8 *topology;
>   	u64 serial_number;
>   
> -	model = fdt_getprop(gd->fdt_blob, 0, "model", NULL);
> -	printf("Model: %s\n", model);
> -
>   	ret = mbox_sp_get_board_info(&serial_number, NULL, NULL, &board_version,
>   				     &ram_size, NULL);
>   	if (ret < 0) {
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index 6c2d7da528..87e33d88c4 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -933,7 +933,6 @@ int checkboard(void)
>   	int err;
>   
>   	err = turris_atsha_otp_get_serial_number(serial);
> -	printf("Model: Turris Omnia\n");
>   	printf("  MCU type: %s\n", omnia_get_mcu_type());
>   	printf("  MCU version: %s\n", omnia_get_mcu_version());
>   	printf("  RAM size: %i MiB\n", omnia_get_ram_size_gb() * 1024);

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 04/18] arm: mvebu: turris_omnia: Update MCU status and features reading

[Marek Behún]

Refactor MCU status word and MCU firmware features reading to make it
simpler to use.

Try reading 32 bits of features, if that fails, read 16 bits. Older MCU
firmware supports only 16-bit wide features, and if more bytes are read,
either 0xff is sent or I2C transaction fails. Handle both cases.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 board/CZ.NIC/turris_omnia/turris_omnia.c | 100 +++++++++++++++--------
 1 file changed, 68 insertions(+), 32 deletions(-)

diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
index 87e33d88c4..6dfde5ee7a 100644
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c
+++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
@@ -133,6 +133,59 @@ static int omnia_mcu_write(u8 cmd, const void *buf, int len)
 	return dm_i2c_write(chip, cmd, buf, len);
 }
 
+static int omnia_mcu_get_sts_and_features(u16 *psts, u32 *pfeatures)
+{
+	u16 sts, feat16;
+	int ret;
+
+	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &sts, sizeof(sts));
+	if (ret)
+		return ret;
+
+	if (psts)
+		*psts = sts;
+
+	if (!pfeatures)
+		return 0;
+
+	if (sts & STS_FEATURES_SUPPORTED) {
+		/* try read 32-bit features */
+		ret = omnia_mcu_read(CMD_GET_FEATURES, pfeatures,
+				     sizeof(*pfeatures));
+		if (ret) {
+			/* try read 16-bit features */
+			ret = omnia_mcu_read(CMD_GET_FEATURES, &feat16,
+					     sizeof(&feat16));
+			if (ret)
+				return ret;
+
+			*pfeatures = feat16;
+		} else {
+			if (*pfeatures & FEAT_FROM_BIT_16_INVALID)
+				*pfeatures &= GENMASK(15, 0);
+		}
+	} else {
+		*pfeatures = 0;
+	}
+
+	return 0;
+}
+
+static int omnia_mcu_get_sts(u16 *sts)
+{
+	return omnia_mcu_get_sts_and_features(sts, NULL);
+}
+
+static bool omnia_mcu_has_feature(u32 feature)
+{
+	u32 features;
+
+	if (omnia_mcu_get_sts_and_features(NULL, &features))
+		return false;
+
+	return feature & features;
+}
+
 static void enable_a385_watchdog(unsigned int timeout_minutes)
 {
 	struct sar_freq_modes sar_freq;
@@ -194,7 +247,7 @@ static bool disable_mcu_watchdog(void)
 static bool omnia_detect_sata(const char *msata_slot)
 {
 	int ret;
-	u16 stsword;
+	u16 sts;
 
 	puts("MiniPCIe/mSATA card detection... ");
 
@@ -210,24 +263,24 @@ static bool omnia_detect_sata(const char *msata_slot)
 		}
 	}
 
-	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &stsword, sizeof(stsword));
+	ret = omnia_mcu_get_sts(&sts);
 	if (ret) {
 		printf("omnia_mcu_read failed: %i, defaulting to MiniPCIe card\n",
 		       ret);
 		return false;
 	}
 
-	if (!(stsword & STS_CARD_DET)) {
+	if (!(sts & STS_CARD_DET)) {
 		puts("none\n");
 		return false;
 	}
 
-	if (stsword & STS_MSATA_IND)
+	if (sts & STS_MSATA_IND)
 		puts("mSATA\n");
 	else
 		puts("MiniPCIe\n");
 
-	return stsword & STS_MSATA_IND;
+	return sts & STS_MSATA_IND;
 }
 
 static bool omnia_detect_wwan_usb3(const char *wwan_slot)
@@ -355,14 +408,14 @@ static int omnia_get_ram_size_gb(void)
 static const char * const omnia_get_mcu_type(void)
 {
 	static char result[] = "xxxxxxx (with peripheral resets)";
-	u16 stsword, features;
+	u16 sts;
 	int ret;
 
-	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &stsword, sizeof(stsword));
+	ret = omnia_mcu_get_sts(&sts);
 	if (ret)
 		return "unknown";
 
-	switch (stsword & STS_MCU_TYPE_MASK) {
+	switch (sts & STS_MCU_TYPE_MASK) {
 	case STS_MCU_TYPE_STM32:
 		strcpy(result, "STM32");
 		break;
@@ -377,11 +430,8 @@ static const char * const omnia_get_mcu_type(void)
 		break;
 	}
 
-	if (stsword & STS_FEATURES_SUPPORTED) {
-		ret = omnia_mcu_read(CMD_GET_FEATURES, &features, sizeof(features));
-		if (ret == 0 && (features & FEAT_PERIPH_MCU))
-			strcat(result, " (with peripheral resets)");
-	}
+	if (omnia_mcu_has_feature(FEAT_PERIPH_MCU))
+		strcat(result, " (with peripheral resets)");
 
 	return result;
 }
@@ -660,9 +710,6 @@ int board_early_init_f(void)
 
 void spl_board_init(void)
 {
-	u16 val;
-	int ret;
-
 	/*
 	 * If booting from UART, disable MCU watchdog in SPL, since uploading
 	 * U-Boot proper can take too much time and trigger it. Instead enable
@@ -679,12 +726,8 @@ void spl_board_init(void)
 	 * resets then LAN eth switch is initialized automatically by bootstrap
 	 * pins when A385 is released from the reset.
 	 */
-	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &val, sizeof(val));
-	if (ret == 0 && (val & STS_FEATURES_SUPPORTED)) {
-		ret = omnia_mcu_read(CMD_GET_FEATURES, &val, sizeof(val));
-		if (ret == 0 && (val & FEAT_PERIPH_MCU))
-			initialize_switch();
-	}
+	if (omnia_mcu_has_feature(FEAT_PERIPH_MCU))
+		initialize_switch();
 }
 
 #if IS_ENABLED(CONFIG_OF_BOARD_FIXUP) || IS_ENABLED(CONFIG_OF_BOARD_SETUP)
@@ -884,16 +927,9 @@ static int fixup_mcu_gpio_in_eth_wan_node(void *blob)
 #if IS_ENABLED(CONFIG_OF_BOARD_FIXUP)
 int board_fix_fdt(void *blob)
 {
-	u16 val;
-	int ret;
-
-	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &val, sizeof(val));
-	if (ret == 0 && (val & STS_FEATURES_SUPPORTED)) {
-		ret = omnia_mcu_read(CMD_GET_FEATURES, &val, sizeof(val));
-		if (ret == 0 && (val & FEAT_PERIPH_MCU)) {
-			fixup_mcu_gpio_in_pcie_nodes(blob);
-			fixup_mcu_gpio_in_eth_wan_node(blob);
-		}
+	if (omnia_mcu_has_feature(FEAT_PERIPH_MCU)) {
+		fixup_mcu_gpio_in_pcie_nodes(blob);
+		fixup_mcu_gpio_in_eth_wan_node(blob);
 	}
 
 	fixup_msata_port_nodes(blob);
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 04/18] arm: mvebu: turris_omnia: Update MCU status and features reading

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Refactor MCU status word and MCU firmware features reading to make it
> simpler to use.
> 
> Try reading 32 bits of features, if that fails, read 16 bits. Older MCU
> firmware supports only 16-bit wide features, and if more bytes are read,
> either 0xff is sent or I2C transaction fails. Handle both cases.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   board/CZ.NIC/turris_omnia/turris_omnia.c | 100 +++++++++++++++--------
>   1 file changed, 68 insertions(+), 32 deletions(-)
> 
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index 87e33d88c4..6dfde5ee7a 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -133,6 +133,59 @@ static int omnia_mcu_write(u8 cmd, const void *buf, int len)
>   	return dm_i2c_write(chip, cmd, buf, len);
>   }
>   
> +static int omnia_mcu_get_sts_and_features(u16 *psts, u32 *pfeatures)
> +{
> +	u16 sts, feat16;
> +	int ret;
> +
> +	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &sts, sizeof(sts));
> +	if (ret)
> +		return ret;
> +
> +	if (psts)
> +		*psts = sts;
> +
> +	if (!pfeatures)
> +		return 0;
> +
> +	if (sts & STS_FEATURES_SUPPORTED) {
> +		/* try read 32-bit features */
> +		ret = omnia_mcu_read(CMD_GET_FEATURES, pfeatures,
> +				     sizeof(*pfeatures));
> +		if (ret) {
> +			/* try read 16-bit features */
> +			ret = omnia_mcu_read(CMD_GET_FEATURES, &feat16,
> +					     sizeof(&feat16));
> +			if (ret)
> +				return ret;
> +
> +			*pfeatures = feat16;
> +		} else {
> +			if (*pfeatures & FEAT_FROM_BIT_16_INVALID)
> +				*pfeatures &= GENMASK(15, 0);
> +		}
> +	} else {
> +		*pfeatures = 0;
> +	}
> +
> +	return 0;
> +}
> +
> +static int omnia_mcu_get_sts(u16 *sts)
> +{
> +	return omnia_mcu_get_sts_and_features(sts, NULL);
> +}
> +
> +static bool omnia_mcu_has_feature(u32 feature)
> +{
> +	u32 features;
> +
> +	if (omnia_mcu_get_sts_and_features(NULL, &features))
> +		return false;
> +
> +	return feature & features;
> +}
> +
>   static void enable_a385_watchdog(unsigned int timeout_minutes)
>   {
>   	struct sar_freq_modes sar_freq;
> @@ -194,7 +247,7 @@ static bool disable_mcu_watchdog(void)
>   static bool omnia_detect_sata(const char *msata_slot)
>   {
>   	int ret;
> -	u16 stsword;
> +	u16 sts;
>   
>   	puts("MiniPCIe/mSATA card detection... ");
>   
> @@ -210,24 +263,24 @@ static bool omnia_detect_sata(const char *msata_slot)
>   		}
>   	}
>   
> -	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &stsword, sizeof(stsword));
> +	ret = omnia_mcu_get_sts(&sts);
>   	if (ret) {
>   		printf("omnia_mcu_read failed: %i, defaulting to MiniPCIe card\n",
>   		       ret);
>   		return false;
>   	}
>   
> -	if (!(stsword & STS_CARD_DET)) {
> +	if (!(sts & STS_CARD_DET)) {
>   		puts("none\n");
>   		return false;
>   	}
>   
> -	if (stsword & STS_MSATA_IND)
> +	if (sts & STS_MSATA_IND)
>   		puts("mSATA\n");
>   	else
>   		puts("MiniPCIe\n");
>   
> -	return stsword & STS_MSATA_IND;
> +	return sts & STS_MSATA_IND;
>   }
>   
>   static bool omnia_detect_wwan_usb3(const char *wwan_slot)
> @@ -355,14 +408,14 @@ static int omnia_get_ram_size_gb(void)
>   static const char * const omnia_get_mcu_type(void)
>   {
>   	static char result[] = "xxxxxxx (with peripheral resets)";
> -	u16 stsword, features;
> +	u16 sts;
>   	int ret;
>   
> -	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &stsword, sizeof(stsword));
> +	ret = omnia_mcu_get_sts(&sts);
>   	if (ret)
>   		return "unknown";
>   
> -	switch (stsword & STS_MCU_TYPE_MASK) {
> +	switch (sts & STS_MCU_TYPE_MASK) {
>   	case STS_MCU_TYPE_STM32:
>   		strcpy(result, "STM32");
>   		break;
> @@ -377,11 +430,8 @@ static const char * const omnia_get_mcu_type(void)
>   		break;
>   	}
>   
> -	if (stsword & STS_FEATURES_SUPPORTED) {
> -		ret = omnia_mcu_read(CMD_GET_FEATURES, &features, sizeof(features));
> -		if (ret == 0 && (features & FEAT_PERIPH_MCU))
> -			strcat(result, " (with peripheral resets)");
> -	}
> +	if (omnia_mcu_has_feature(FEAT_PERIPH_MCU))
> +		strcat(result, " (with peripheral resets)");
>   
>   	return result;
>   }
> @@ -660,9 +710,6 @@ int board_early_init_f(void)
>   
>   void spl_board_init(void)
>   {
> -	u16 val;
> -	int ret;
> -
>   	/*
>   	 * If booting from UART, disable MCU watchdog in SPL, since uploading
>   	 * U-Boot proper can take too much time and trigger it. Instead enable
> @@ -679,12 +726,8 @@ void spl_board_init(void)
>   	 * resets then LAN eth switch is initialized automatically by bootstrap
>   	 * pins when A385 is released from the reset.
>   	 */
> -	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &val, sizeof(val));
> -	if (ret == 0 && (val & STS_FEATURES_SUPPORTED)) {
> -		ret = omnia_mcu_read(CMD_GET_FEATURES, &val, sizeof(val));
> -		if (ret == 0 && (val & FEAT_PERIPH_MCU))
> -			initialize_switch();
> -	}
> +	if (omnia_mcu_has_feature(FEAT_PERIPH_MCU))
> +		initialize_switch();
>   }
>   
>   #if IS_ENABLED(CONFIG_OF_BOARD_FIXUP) || IS_ENABLED(CONFIG_OF_BOARD_SETUP)
> @@ -884,16 +927,9 @@ static int fixup_mcu_gpio_in_eth_wan_node(void *blob)
>   #if IS_ENABLED(CONFIG_OF_BOARD_FIXUP)
>   int board_fix_fdt(void *blob)
>   {
> -	u16 val;
> -	int ret;
> -
> -	ret = omnia_mcu_read(CMD_GET_STATUS_WORD, &val, sizeof(val));
> -	if (ret == 0 && (val & STS_FEATURES_SUPPORTED)) {
> -		ret = omnia_mcu_read(CMD_GET_FEATURES, &val, sizeof(val));
> -		if (ret == 0 && (val & FEAT_PERIPH_MCU)) {
> -			fixup_mcu_gpio_in_pcie_nodes(blob);
> -			fixup_mcu_gpio_in_eth_wan_node(blob);
> -		}
> +	if (omnia_mcu_has_feature(FEAT_PERIPH_MCU)) {
> +		fixup_mcu_gpio_in_pcie_nodes(blob);
> +		fixup_mcu_gpio_in_eth_wan_node(blob);
>   	}
>   
>   	fixup_msata_port_nodes(blob);

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

[Marek Behún]

Implement reading board serial number, first MAC address and board
version from MCU. MCU supports board information if the FEAT_BOARD_INFO
feature bit is set in MCU features.

Prefer getting board information from MCU if supported, fallback to
Atmel SHA chip.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 board/CZ.NIC/turris_atsha_otp.c          | 27 +------
 board/CZ.NIC/turris_omnia/Makefile       |  2 +-
 board/CZ.NIC/turris_omnia/turris_omnia.c | 94 +++++++++++++++++++++++-
 3 files changed, 93 insertions(+), 30 deletions(-)

diff --git a/board/CZ.NIC/turris_atsha_otp.c b/board/CZ.NIC/turris_atsha_otp.c
index a29fe36231..85eebcdf18 100644
--- a/board/CZ.NIC/turris_atsha_otp.c
+++ b/board/CZ.NIC/turris_atsha_otp.c
@@ -11,6 +11,7 @@
 #include <atsha204a-i2c.h>
 
 #include "turris_atsha_otp.h"
+#include "turris_common.h"
 
 #define TURRIS_ATSHA_OTP_VERSION	0
 #define TURRIS_ATSHA_OTP_SERIAL		1
@@ -32,26 +33,6 @@ static struct udevice *get_atsha204a_dev(void)
 	return dev;
 }
 
-static void increment_mac(u8 *mac)
-{
-	int i;
-
-	for (i = 5; i >= 3; i--) {
-		mac[i] += 1;
-		if (mac[i])
-			break;
-	}
-}
-
-static void set_mac_if_invalid(int i, u8 *mac)
-{
-	u8 oldmac[6];
-
-	if (is_valid_ethaddr(mac) &&
-	    !eth_env_get_enetaddr_by_index("eth", i, oldmac))
-		eth_env_set_enetaddr_by_index("eth", i, mac);
-}
-
 int turris_atsha_otp_init_mac_addresses(int first_idx)
 {
 	struct udevice *dev = get_atsha204a_dev();
@@ -84,11 +65,7 @@ int turris_atsha_otp_init_mac_addresses(int first_idx)
 	mac[4] = mac1[2];
 	mac[5] = mac1[3];
 
-	set_mac_if_invalid((first_idx + 0) % 3, mac);
-	increment_mac(mac);
-	set_mac_if_invalid((first_idx + 1) % 3, mac);
-	increment_mac(mac);
-	set_mac_if_invalid((first_idx + 2) % 3, mac);
+	turris_init_mac_addresses(first_idx, mac);
 
 	return 0;
 }
diff --git a/board/CZ.NIC/turris_omnia/Makefile b/board/CZ.NIC/turris_omnia/Makefile
index dc39b44ae1..341378b4e5 100644
--- a/board/CZ.NIC/turris_omnia/Makefile
+++ b/board/CZ.NIC/turris_omnia/Makefile
@@ -2,4 +2,4 @@
 #
 # Copyright (C) 2017 Marek Behún <kabel@kernel.org>
 
-obj-y	:= turris_omnia.o ../turris_atsha_otp.o
+obj-y	:= turris_omnia.o ../turris_atsha_otp.o ../turris_common.o
diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
index 6dfde5ee7a..f63640ad64 100644
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c
+++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
@@ -18,6 +18,7 @@
 #include <asm/io.h>
 #include <asm/arch/cpu.h>
 #include <asm/arch/soc.h>
+#include <asm/unaligned.h>
 #include <dm/uclass.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <fdt_support.h>
@@ -25,12 +26,14 @@
 #include <time.h>
 #include <turris-omnia-mcu-interface.h>
 #include <linux/bitops.h>
+#include <linux/bitrev.h>
 #include <linux/delay.h>
 #include <u-boot/crc.h>
 
 #include "../drivers/ddr/marvell/a38x/ddr3_init.h"
 #include <../serdes/a38x/high_speed_env_spec.h>
 #include "../turris_atsha_otp.h"
+#include "../turris_common.h"
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -186,6 +189,70 @@ static bool omnia_mcu_has_feature(u32 feature)
 	return feature & features;
 }
 
+static u32 omnia_mcu_crc32(const void *p, size_t len)
+{
+	u32 val, crc = 0;
+
+	compiletime_assert(!(len % 4), "length has to be a multiple of 4");
+
+	while (len) {
+		val = bitrev32(get_unaligned_le32(p));
+		crc = crc32(crc, (void *)&val, 4);
+		p += 4;
+		len -= 4;
+	}
+
+	return ~bitrev32(crc);
+}
+
+/* Can only be called after relocation, since it needs cleared BSS */
+static int omnia_mcu_board_info(char *serial, u8 *mac, char *version)
+{
+	static u8 reply[17];
+	static bool cached;
+
+	if (!cached) {
+		u8 csum;
+		int ret;
+
+		ret = omnia_mcu_read(CMD_BOARD_INFO_GET, reply, sizeof(reply));
+		if (ret)
+			return ret;
+
+		if (reply[0] != 16)
+			return -EBADMSG;
+
+		csum = reply[16];
+		reply[16] = 0;
+
+		if ((omnia_mcu_crc32(&reply[1], 16) & 0xff) != csum)
+			return -EBADMSG;
+
+		cached = true;
+	}
+
+	if (serial) {
+		const char *serial_env;
+
+		serial_env = env_get("serial#");
+		if (serial_env && strlen(serial_env) == 16) {
+			strcpy(serial, serial_env);
+		} else {
+			sprintf(serial, "%016llX",
+				get_unaligned_le64(&reply[1]));
+			env_set("serial#", serial);
+		}
+	}
+
+	if (mac)
+		memcpy(mac, &reply[9], ETH_ALEN);
+
+	if (version)
+		sprintf(version, "%u", reply[15]);
+
+	return 0;
+}
+
 static void enable_a385_watchdog(unsigned int timeout_minutes)
 {
 	struct sar_freq_modes sar_freq;
@@ -965,13 +1032,23 @@ int board_late_init(void)
 
 int checkboard(void)
 {
-	char serial[17];
+	char serial[17], version[4];
+	bool has_version;
 	int err;
 
-	err = turris_atsha_otp_get_serial_number(serial);
 	printf("  MCU type: %s\n", omnia_get_mcu_type());
 	printf("  MCU version: %s\n", omnia_get_mcu_version());
 	printf("  RAM size: %i MiB\n", omnia_get_ram_size_gb() * 1024);
+
+	if (omnia_mcu_has_feature(FEAT_BOARD_INFO)) {
+		err = omnia_mcu_board_info(serial, NULL, version);
+		has_version = !err;
+	} else {
+		err = turris_atsha_otp_get_serial_number(serial);
+		has_version = false;
+	}
+
+	printf("  Board version: %s\n", has_version ? version : "unknown");
 	printf("  Serial Number: %s\n", !err ? serial : "unknown");
 
 	return 0;
@@ -979,8 +1056,17 @@ int checkboard(void)
 
 int misc_init_r(void)
 {
-	turris_atsha_otp_init_mac_addresses(1);
-	turris_atsha_otp_init_serial_number();
+	if (omnia_mcu_has_feature(FEAT_BOARD_INFO)) {
+		char serial[17];
+		u8 first_mac[6];
+
+		if (!omnia_mcu_board_info(serial, first_mac, NULL))
+			turris_init_mac_addresses(1, first_mac);
+	} else {
+		turris_atsha_otp_init_mac_addresses(1);
+		turris_atsha_otp_init_serial_number();
+	}
+
 	return 0;
 }
 
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Implement reading board serial number, first MAC address and board
> version from MCU. MCU supports board information if the FEAT_BOARD_INFO
> feature bit is set in MCU features.
> 
> Prefer getting board information from MCU if supported, fallback to
> Atmel SHA chip.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Minor comment below. Other than this:

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   board/CZ.NIC/turris_atsha_otp.c          | 27 +------
>   board/CZ.NIC/turris_omnia/Makefile       |  2 +-
>   board/CZ.NIC/turris_omnia/turris_omnia.c | 94 +++++++++++++++++++++++-
>   3 files changed, 93 insertions(+), 30 deletions(-)
> 
> diff --git a/board/CZ.NIC/turris_atsha_otp.c b/board/CZ.NIC/turris_atsha_otp.c
> index a29fe36231..85eebcdf18 100644
> --- a/board/CZ.NIC/turris_atsha_otp.c
> +++ b/board/CZ.NIC/turris_atsha_otp.c
> @@ -11,6 +11,7 @@
>   #include <atsha204a-i2c.h>
>   
>   #include "turris_atsha_otp.h"
> +#include "turris_common.h"
>   
>   #define TURRIS_ATSHA_OTP_VERSION	0
>   #define TURRIS_ATSHA_OTP_SERIAL		1
> @@ -32,26 +33,6 @@ static struct udevice *get_atsha204a_dev(void)
>   	return dev;
>   }
>   
> -static void increment_mac(u8 *mac)
> -{
> -	int i;
> -
> -	for (i = 5; i >= 3; i--) {
> -		mac[i] += 1;
> -		if (mac[i])
> -			break;
> -	}
> -}
> -
> -static void set_mac_if_invalid(int i, u8 *mac)
> -{
> -	u8 oldmac[6];
> -
> -	if (is_valid_ethaddr(mac) &&
> -	    !eth_env_get_enetaddr_by_index("eth", i, oldmac))
> -		eth_env_set_enetaddr_by_index("eth", i, mac);
> -}
> -
>   int turris_atsha_otp_init_mac_addresses(int first_idx)
>   {
>   	struct udevice *dev = get_atsha204a_dev();
> @@ -84,11 +65,7 @@ int turris_atsha_otp_init_mac_addresses(int first_idx)
>   	mac[4] = mac1[2];
>   	mac[5] = mac1[3];
>   
> -	set_mac_if_invalid((first_idx + 0) % 3, mac);
> -	increment_mac(mac);
> -	set_mac_if_invalid((first_idx + 1) % 3, mac);
> -	increment_mac(mac);
> -	set_mac_if_invalid((first_idx + 2) % 3, mac);
> +	turris_init_mac_addresses(first_idx, mac);
>   
>   	return 0;
>   }
> diff --git a/board/CZ.NIC/turris_omnia/Makefile b/board/CZ.NIC/turris_omnia/Makefile
> index dc39b44ae1..341378b4e5 100644
> --- a/board/CZ.NIC/turris_omnia/Makefile
> +++ b/board/CZ.NIC/turris_omnia/Makefile
> @@ -2,4 +2,4 @@
>   #
>   # Copyright (C) 2017 Marek Behún <kabel@kernel.org>
>   
> -obj-y	:= turris_omnia.o ../turris_atsha_otp.o
> +obj-y	:= turris_omnia.o ../turris_atsha_otp.o ../turris_common.o
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index 6dfde5ee7a..f63640ad64 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -18,6 +18,7 @@
>   #include <asm/io.h>
>   #include <asm/arch/cpu.h>
>   #include <asm/arch/soc.h>
> +#include <asm/unaligned.h>
>   #include <dm/uclass.h>
>   #include <dt-bindings/gpio/gpio.h>
>   #include <fdt_support.h>
> @@ -25,12 +26,14 @@
>   #include <time.h>
>   #include <turris-omnia-mcu-interface.h>
>   #include <linux/bitops.h>
> +#include <linux/bitrev.h>
>   #include <linux/delay.h>
>   #include <u-boot/crc.h>
>   
>   #include "../drivers/ddr/marvell/a38x/ddr3_init.h"
>   #include <../serdes/a38x/high_speed_env_spec.h>
>   #include "../turris_atsha_otp.h"
> +#include "../turris_common.h"
>   
>   DECLARE_GLOBAL_DATA_PTR;
>   
> @@ -186,6 +189,70 @@ static bool omnia_mcu_has_feature(u32 feature)
>   	return feature & features;
>   }
>   
> +static u32 omnia_mcu_crc32(const void *p, size_t len)
> +{
> +	u32 val, crc = 0;
> +
> +	compiletime_assert(!(len % 4), "length has to be a multiple of 4");
> +
> +	while (len) {
> +		val = bitrev32(get_unaligned_le32(p));
> +		crc = crc32(crc, (void *)&val, 4);
> +		p += 4;
> +		len -= 4;
> +	}
> +
> +	return ~bitrev32(crc);
> +}
> +
> +/* Can only be called after relocation, since it needs cleared BSS */
> +static int omnia_mcu_board_info(char *serial, u8 *mac, char *version)
> +{
> +	static u8 reply[17];
> +	static bool cached;
> +
> +	if (!cached) {
> +		u8 csum;
> +		int ret;
> +
> +		ret = omnia_mcu_read(CMD_BOARD_INFO_GET, reply, sizeof(reply));
> +		if (ret)
> +			return ret;
> +
> +		if (reply[0] != 16)
> +			return -EBADMSG;
> +
> +		csum = reply[16];
> +		reply[16] = 0;
> +
> +		if ((omnia_mcu_crc32(&reply[1], 16) & 0xff) != csum)
> +			return -EBADMSG;
> +
> +		cached = true;
> +	}
> +
> +	if (serial) {
> +		const char *serial_env;
> +
> +		serial_env = env_get("serial#");
> +		if (serial_env && strlen(serial_env) == 16) {
> +			strcpy(serial, serial_env);

Usage of strcpy() is discouraged AFAIK.

> +		} else {
> +			sprintf(serial, "%016llX",
> +				get_unaligned_le64(&reply[1]));
> +			env_set("serial#", serial);
> +		}
> +	}
> +
> +	if (mac)
> +		memcpy(mac, &reply[9], ETH_ALEN);
> +
> +	if (version)
> +		sprintf(version, "%u", reply[15]);
> +
> +	return 0;
> +}
> +
>   static void enable_a385_watchdog(unsigned int timeout_minutes)
>   {
>   	struct sar_freq_modes sar_freq;
> @@ -965,13 +1032,23 @@ int board_late_init(void)
>   
>   int checkboard(void)
>   {
> -	char serial[17];
> +	char serial[17], version[4];
> +	bool has_version;
>   	int err;
>   
> -	err = turris_atsha_otp_get_serial_number(serial);
>   	printf("  MCU type: %s\n", omnia_get_mcu_type());
>   	printf("  MCU version: %s\n", omnia_get_mcu_version());
>   	printf("  RAM size: %i MiB\n", omnia_get_ram_size_gb() * 1024);
> +
> +	if (omnia_mcu_has_feature(FEAT_BOARD_INFO)) {
> +		err = omnia_mcu_board_info(serial, NULL, version);
> +		has_version = !err;
> +	} else {
> +		err = turris_atsha_otp_get_serial_number(serial);
> +		has_version = false;
> +	}
> +
> +	printf("  Board version: %s\n", has_version ? version : "unknown");
>   	printf("  Serial Number: %s\n", !err ? serial : "unknown");
>   
>   	return 0;
> @@ -979,8 +1056,17 @@ int checkboard(void)
>   
>   int misc_init_r(void)
>   {
> -	turris_atsha_otp_init_mac_addresses(1);
> -	turris_atsha_otp_init_serial_number();
> +	if (omnia_mcu_has_feature(FEAT_BOARD_INFO)) {
> +		char serial[17];
> +		u8 first_mac[6];
> +
> +		if (!omnia_mcu_board_info(serial, first_mac, NULL))
> +			turris_init_mac_addresses(1, first_mac);
> +	} else {
> +		turris_atsha_otp_init_mac_addresses(1);
> +		turris_atsha_otp_init_serial_number();
> +	}
> +
>   	return 0;
>   }
>   

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

[Marek Behún]

On Thu, 28 Mar 2024 10:56:01 +0100
Stefan Roese <sr@denx.de> wrote:

> On 3/27/24 17:23, Marek Behún wrote:
> > Implement reading board serial number, first MAC address and board
> > version from MCU. MCU supports board information if the FEAT_BOARD_INFO
> > feature bit is set in MCU features.
> > 
> > Prefer getting board information from MCU if supported, fallback to
> > Atmel SHA chip.
> > 
> > Signed-off-by: Marek Behún <kabel@kernel.org>  
> 
> Minor comment below. Other than this:
> 
> Reviewed-by: Stefan Roese <sr@denx.de>
> 
> Thanks,
> Stefan
> 
> > ---
> >   board/CZ.NIC/turris_atsha_otp.c          | 27 +------
> >   board/CZ.NIC/turris_omnia/Makefile       |  2 +-
> >   board/CZ.NIC/turris_omnia/turris_omnia.c | 94 +++++++++++++++++++++++-
> >   3 files changed, 93 insertions(+), 30 deletions(-)
> > 
> > diff --git a/board/CZ.NIC/turris_atsha_otp.c b/board/CZ.NIC/turris_atsha_otp.c
> > index a29fe36231..85eebcdf18 100644
> > --- a/board/CZ.NIC/turris_atsha_otp.c
> > +++ b/board/CZ.NIC/turris_atsha_otp.c
> > @@ -11,6 +11,7 @@
> >   #include <atsha204a-i2c.h>
> >   
> >   #include "turris_atsha_otp.h"
> > +#include "turris_common.h"
> >   
> >   #define TURRIS_ATSHA_OTP_VERSION	0
> >   #define TURRIS_ATSHA_OTP_SERIAL		1
> > @@ -32,26 +33,6 @@ static struct udevice *get_atsha204a_dev(void)
> >   	return dev;
> >   }
> >   
> > -static void increment_mac(u8 *mac)
> > -{
> > -	int i;
> > -
> > -	for (i = 5; i >= 3; i--) {
> > -		mac[i] += 1;
> > -		if (mac[i])
> > -			break;
> > -	}
> > -}
> > -
> > -static void set_mac_if_invalid(int i, u8 *mac)
> > -{
> > -	u8 oldmac[6];
> > -
> > -	if (is_valid_ethaddr(mac) &&
> > -	    !eth_env_get_enetaddr_by_index("eth", i, oldmac))
> > -		eth_env_set_enetaddr_by_index("eth", i, mac);
> > -}
> > -
> >   int turris_atsha_otp_init_mac_addresses(int first_idx)
> >   {
> >   	struct udevice *dev = get_atsha204a_dev();
> > @@ -84,11 +65,7 @@ int turris_atsha_otp_init_mac_addresses(int first_idx)
> >   	mac[4] = mac1[2];
> >   	mac[5] = mac1[3];
> >   
> > -	set_mac_if_invalid((first_idx + 0) % 3, mac);
> > -	increment_mac(mac);
> > -	set_mac_if_invalid((first_idx + 1) % 3, mac);
> > -	increment_mac(mac);
> > -	set_mac_if_invalid((first_idx + 2) % 3, mac);
> > +	turris_init_mac_addresses(first_idx, mac);
> >   
> >   	return 0;
> >   }
> > diff --git a/board/CZ.NIC/turris_omnia/Makefile b/board/CZ.NIC/turris_omnia/Makefile
> > index dc39b44ae1..341378b4e5 100644
> > --- a/board/CZ.NIC/turris_omnia/Makefile
> > +++ b/board/CZ.NIC/turris_omnia/Makefile
> > @@ -2,4 +2,4 @@
> >   #
> >   # Copyright (C) 2017 Marek Behún <kabel@kernel.org>
> >   
> > -obj-y	:= turris_omnia.o ../turris_atsha_otp.o
> > +obj-y	:= turris_omnia.o ../turris_atsha_otp.o ../turris_common.o
> > diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> > index 6dfde5ee7a..f63640ad64 100644
> > --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> > +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> > @@ -18,6 +18,7 @@
> >   #include <asm/io.h>
> >   #include <asm/arch/cpu.h>
> >   #include <asm/arch/soc.h>
> > +#include <asm/unaligned.h>
> >   #include <dm/uclass.h>
> >   #include <dt-bindings/gpio/gpio.h>
> >   #include <fdt_support.h>
> > @@ -25,12 +26,14 @@
> >   #include <time.h>
> >   #include <turris-omnia-mcu-interface.h>
> >   #include <linux/bitops.h>
> > +#include <linux/bitrev.h>
> >   #include <linux/delay.h>
> >   #include <u-boot/crc.h>
> >   
> >   #include "../drivers/ddr/marvell/a38x/ddr3_init.h"
> >   #include <../serdes/a38x/high_speed_env_spec.h>
> >   #include "../turris_atsha_otp.h"
> > +#include "../turris_common.h"
> >   
> >   DECLARE_GLOBAL_DATA_PTR;
> >   
> > @@ -186,6 +189,70 @@ static bool omnia_mcu_has_feature(u32 feature)
> >   	return feature & features;
> >   }
> >   
> > +static u32 omnia_mcu_crc32(const void *p, size_t len)
> > +{
> > +	u32 val, crc = 0;
> > +
> > +	compiletime_assert(!(len % 4), "length has to be a multiple of 4");
> > +
> > +	while (len) {
> > +		val = bitrev32(get_unaligned_le32(p));
> > +		crc = crc32(crc, (void *)&val, 4);
> > +		p += 4;
> > +		len -= 4;
> > +	}
> > +
> > +	return ~bitrev32(crc);
> > +}
> > +
> > +/* Can only be called after relocation, since it needs cleared BSS */
> > +static int omnia_mcu_board_info(char *serial, u8 *mac, char *version)
> > +{
> > +	static u8 reply[17];
> > +	static bool cached;
> > +
> > +	if (!cached) {
> > +		u8 csum;
> > +		int ret;
> > +
> > +		ret = omnia_mcu_read(CMD_BOARD_INFO_GET, reply, sizeof(reply));
> > +		if (ret)
> > +			return ret;
> > +
> > +		if (reply[0] != 16)
> > +			return -EBADMSG;
> > +
> > +		csum = reply[16];
> > +		reply[16] = 0;
> > +
> > +		if ((omnia_mcu_crc32(&reply[1], 16) & 0xff) != csum)
> > +			return -EBADMSG;
> > +
> > +		cached = true;
> > +	}
> > +
> > +	if (serial) {
> > +		const char *serial_env;
> > +
> > +		serial_env = env_get("serial#");
> > +		if (serial_env && strlen(serial_env) == 16) {
> > +			strcpy(serial, serial_env);  
> 
> Usage of strcpy() is discouraged AFAIK.

Yeah, it would make sense to use strncpy, but the potential leak is
prevented by strlen() check.

Marek

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

[Stefan Roese]

On 3/28/24 12:17, Marek Behún wrote:
> On Thu, 28 Mar 2024 10:56:01 +0100
> Stefan Roese <sr@denx.de> wrote:
> 
>> On 3/27/24 17:23, Marek Behún wrote:
>>> Implement reading board serial number, first MAC address and board
>>> version from MCU. MCU supports board information if the FEAT_BOARD_INFO
>>> feature bit is set in MCU features.
>>>
>>> Prefer getting board information from MCU if supported, fallback to
>>> Atmel SHA chip.
>>>
>>> Signed-off-by: Marek Behún <kabel@kernel.org>
>>
>> Minor comment below. Other than this:
>>
>> Reviewed-by: Stefan Roese <sr@denx.de>
>>
>> Thanks,
>> Stefan
>>
>>> ---
>>>    board/CZ.NIC/turris_atsha_otp.c          | 27 +------
>>>    board/CZ.NIC/turris_omnia/Makefile       |  2 +-
>>>    board/CZ.NIC/turris_omnia/turris_omnia.c | 94 +++++++++++++++++++++++-
>>>    3 files changed, 93 insertions(+), 30 deletions(-)
>>>
>>> diff --git a/board/CZ.NIC/turris_atsha_otp.c b/board/CZ.NIC/turris_atsha_otp.c
>>> index a29fe36231..85eebcdf18 100644
>>> --- a/board/CZ.NIC/turris_atsha_otp.c
>>> +++ b/board/CZ.NIC/turris_atsha_otp.c
>>> @@ -11,6 +11,7 @@
>>>    #include <atsha204a-i2c.h>
>>>    
>>>    #include "turris_atsha_otp.h"
>>> +#include "turris_common.h"
>>>    
>>>    #define TURRIS_ATSHA_OTP_VERSION	0
>>>    #define TURRIS_ATSHA_OTP_SERIAL		1
>>> @@ -32,26 +33,6 @@ static struct udevice *get_atsha204a_dev(void)
>>>    	return dev;
>>>    }
>>>    
>>> -static void increment_mac(u8 *mac)
>>> -{
>>> -	int i;
>>> -
>>> -	for (i = 5; i >= 3; i--) {
>>> -		mac[i] += 1;
>>> -		if (mac[i])
>>> -			break;
>>> -	}
>>> -}
>>> -
>>> -static void set_mac_if_invalid(int i, u8 *mac)
>>> -{
>>> -	u8 oldmac[6];
>>> -
>>> -	if (is_valid_ethaddr(mac) &&
>>> -	    !eth_env_get_enetaddr_by_index("eth", i, oldmac))
>>> -		eth_env_set_enetaddr_by_index("eth", i, mac);
>>> -}
>>> -
>>>    int turris_atsha_otp_init_mac_addresses(int first_idx)
>>>    {
>>>    	struct udevice *dev = get_atsha204a_dev();
>>> @@ -84,11 +65,7 @@ int turris_atsha_otp_init_mac_addresses(int first_idx)
>>>    	mac[4] = mac1[2];
>>>    	mac[5] = mac1[3];
>>>    
>>> -	set_mac_if_invalid((first_idx + 0) % 3, mac);
>>> -	increment_mac(mac);
>>> -	set_mac_if_invalid((first_idx + 1) % 3, mac);
>>> -	increment_mac(mac);
>>> -	set_mac_if_invalid((first_idx + 2) % 3, mac);
>>> +	turris_init_mac_addresses(first_idx, mac);
>>>    
>>>    	return 0;
>>>    }
>>> diff --git a/board/CZ.NIC/turris_omnia/Makefile b/board/CZ.NIC/turris_omnia/Makefile
>>> index dc39b44ae1..341378b4e5 100644
>>> --- a/board/CZ.NIC/turris_omnia/Makefile
>>> +++ b/board/CZ.NIC/turris_omnia/Makefile
>>> @@ -2,4 +2,4 @@
>>>    #
>>>    # Copyright (C) 2017 Marek Behún <kabel@kernel.org>
>>>    
>>> -obj-y	:= turris_omnia.o ../turris_atsha_otp.o
>>> +obj-y	:= turris_omnia.o ../turris_atsha_otp.o ../turris_common.o
>>> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
>>> index 6dfde5ee7a..f63640ad64 100644
>>> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
>>> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
>>> @@ -18,6 +18,7 @@
>>>    #include <asm/io.h>
>>>    #include <asm/arch/cpu.h>
>>>    #include <asm/arch/soc.h>
>>> +#include <asm/unaligned.h>
>>>    #include <dm/uclass.h>
>>>    #include <dt-bindings/gpio/gpio.h>
>>>    #include <fdt_support.h>
>>> @@ -25,12 +26,14 @@
>>>    #include <time.h>
>>>    #include <turris-omnia-mcu-interface.h>
>>>    #include <linux/bitops.h>
>>> +#include <linux/bitrev.h>
>>>    #include <linux/delay.h>
>>>    #include <u-boot/crc.h>
>>>    
>>>    #include "../drivers/ddr/marvell/a38x/ddr3_init.h"
>>>    #include <../serdes/a38x/high_speed_env_spec.h>
>>>    #include "../turris_atsha_otp.h"
>>> +#include "../turris_common.h"
>>>    
>>>    DECLARE_GLOBAL_DATA_PTR;
>>>    
>>> @@ -186,6 +189,70 @@ static bool omnia_mcu_has_feature(u32 feature)
>>>    	return feature & features;
>>>    }
>>>    
>>> +static u32 omnia_mcu_crc32(const void *p, size_t len)
>>> +{
>>> +	u32 val, crc = 0;
>>> +
>>> +	compiletime_assert(!(len % 4), "length has to be a multiple of 4");
>>> +
>>> +	while (len) {
>>> +		val = bitrev32(get_unaligned_le32(p));
>>> +		crc = crc32(crc, (void *)&val, 4);
>>> +		p += 4;
>>> +		len -= 4;
>>> +	}
>>> +
>>> +	return ~bitrev32(crc);
>>> +}
>>> +
>>> +/* Can only be called after relocation, since it needs cleared BSS */
>>> +static int omnia_mcu_board_info(char *serial, u8 *mac, char *version)
>>> +{
>>> +	static u8 reply[17];
>>> +	static bool cached;
>>> +
>>> +	if (!cached) {
>>> +		u8 csum;
>>> +		int ret;
>>> +
>>> +		ret = omnia_mcu_read(CMD_BOARD_INFO_GET, reply, sizeof(reply));
>>> +		if (ret)
>>> +			return ret;
>>> +
>>> +		if (reply[0] != 16)
>>> +			return -EBADMSG;
>>> +
>>> +		csum = reply[16];
>>> +		reply[16] = 0;
>>> +
>>> +		if ((omnia_mcu_crc32(&reply[1], 16) & 0xff) != csum)
>>> +			return -EBADMSG;
>>> +
>>> +		cached = true;
>>> +	}
>>> +
>>> +	if (serial) {
>>> +		const char *serial_env;
>>> +
>>> +		serial_env = env_get("serial#");
>>> +		if (serial_env && strlen(serial_env) == 16) {
>>> +			strcpy(serial, serial_env);
>>
>> Usage of strcpy() is discouraged AFAIK.
> 
> Yeah, it would make sense to use strncpy, but the potential leak is
> prevented by strlen() check.

strncpy is also not optimal. Please see here if you are interested:

https://www.geeksforgeeks.org/why-strcpy-and-strncpy-are-not-safe-to-use/

AFAIU, there is no pressing need to change this implementation here
though right now. I just wanted to make this comment.

Thanks,
Stefan

[PATCH u-boot-mvebu v3 06/18] arm: mvebu: turris_omnia: Print board ECDSA public key if available

[Marek Behún]

If MCU supports the FEAT_CRYPTO feature, read board ECDSA public key
from MCU and print it.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 board/CZ.NIC/turris_omnia/turris_omnia.c | 25 +++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
index f63640ad64..b2f0088e5e 100644
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c
+++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
@@ -253,6 +253,24 @@ static int omnia_mcu_board_info(char *serial, u8 *mac, char *version)
 	return 0;
 }
 
+static int omnia_mcu_get_board_public_key(char pub_key[static 67])
+{
+	u8 reply[34];
+	int ret;
+
+	ret = omnia_mcu_read(CMD_CRYPTO_GET_PUBLIC_KEY, reply, sizeof(reply));
+	if (ret)
+		return ret;
+
+	if (reply[0] != 33)
+		return -EBADMSG;
+
+	bin2hex(pub_key, &reply[1], 33);
+	pub_key[66] = '\0';
+
+	return 0;
+}
+
 static void enable_a385_watchdog(unsigned int timeout_minutes)
 {
 	struct sar_freq_modes sar_freq;
@@ -1032,7 +1050,7 @@ int board_late_init(void)
 
 int checkboard(void)
 {
-	char serial[17], version[4];
+	char serial[17], version[4], pub_key[67];
 	bool has_version;
 	int err;
 
@@ -1051,6 +1069,11 @@ int checkboard(void)
 	printf("  Board version: %s\n", has_version ? version : "unknown");
 	printf("  Serial Number: %s\n", !err ? serial : "unknown");
 
+	if (omnia_mcu_has_feature(FEAT_CRYPTO)) {
+		err = omnia_mcu_get_board_public_key(pub_key);
+		printf("  ECDSA Public Key: %s\n", !err ? pub_key : "unknown");
+	}
+
 	return 0;
 }
 
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 06/18] arm: mvebu: turris_omnia: Print board ECDSA public key if available

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> If MCU supports the FEAT_CRYPTO feature, read board ECDSA public key
> from MCU and print it.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   board/CZ.NIC/turris_omnia/turris_omnia.c | 25 +++++++++++++++++++++++-
>   1 file changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index f63640ad64..b2f0088e5e 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -253,6 +253,24 @@ static int omnia_mcu_board_info(char *serial, u8 *mac, char *version)
>   	return 0;
>   }
>   
> +static int omnia_mcu_get_board_public_key(char pub_key[static 67])
> +{
> +	u8 reply[34];
> +	int ret;
> +
> +	ret = omnia_mcu_read(CMD_CRYPTO_GET_PUBLIC_KEY, reply, sizeof(reply));
> +	if (ret)
> +		return ret;
> +
> +	if (reply[0] != 33)
> +		return -EBADMSG;
> +
> +	bin2hex(pub_key, &reply[1], 33);
> +	pub_key[66] = '\0';
> +
> +	return 0;
> +}
> +
>   static void enable_a385_watchdog(unsigned int timeout_minutes)
>   {
>   	struct sar_freq_modes sar_freq;
> @@ -1032,7 +1050,7 @@ int board_late_init(void)
>   
>   int checkboard(void)
>   {
> -	char serial[17], version[4];
> +	char serial[17], version[4], pub_key[67];
>   	bool has_version;
>   	int err;
>   
> @@ -1051,6 +1069,11 @@ int checkboard(void)
>   	printf("  Board version: %s\n", has_version ? version : "unknown");
>   	printf("  Serial Number: %s\n", !err ? serial : "unknown");
>   
> +	if (omnia_mcu_has_feature(FEAT_CRYPTO)) {
> +		err = omnia_mcu_get_board_public_key(pub_key);
> +		printf("  ECDSA Public Key: %s\n", !err ? pub_key : "unknown");
> +	}
> +
>   	return 0;
>   }
>   

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 07/18] arm: mvebu: turris_omnia: Disable Atmel SHA node if not present

[Marek Behún]

If the FEAT_CRYPTO feature bit is present in MCU features, the board
crypto is implemented by MCU and the Atmel SHA chip is not present.
Disable Atmel SHA device-tree node in that case.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 board/CZ.NIC/turris_omnia/turris_omnia.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
index b2f0088e5e..3b7a71bdad 100644
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c
+++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
@@ -1007,6 +1007,25 @@ static int fixup_mcu_gpio_in_eth_wan_node(void *blob)
 	return 0;
 }
 
+static void fixup_atsha_node(void *blob)
+{
+	int node;
+
+	if (!omnia_mcu_has_feature(FEAT_CRYPTO))
+		return;
+
+	node = fdt_node_offset_by_compatible(blob, -1, "atmel,atsha204a");
+	if (node < 0) {
+		printf("Cannot find ATSHA204A node!\n");
+		return;
+	}
+
+	if (fdt_status_disabled(blob, node) < 0)
+		printf("Cannot disable ATSHA204A node!\n");
+	else
+		debug("Disabled ATSHA204A node\n");
+}
+
 #endif
 
 #if IS_ENABLED(CONFIG_OF_BOARD_FIXUP)
@@ -1020,6 +1039,8 @@ int board_fix_fdt(void *blob)
 	fixup_msata_port_nodes(blob);
 	fixup_wwan_port_nodes(blob);
 
+	fixup_atsha_node(blob);
+
 	return 0;
 }
 #endif
@@ -1211,6 +1232,8 @@ int ft_board_setup(void *blob, struct bd_info *bd)
 	fixup_msata_port_nodes(blob);
 	fixup_wwan_port_nodes(blob);
 
+	fixup_atsha_node(blob);
+
 	return 0;
 }
 #endif
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 07/18] arm: mvebu: turris_omnia: Disable Atmel SHA node if not present

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> If the FEAT_CRYPTO feature bit is present in MCU features, the board
> crypto is implemented by MCU and the Atmel SHA chip is not present.
> Disable Atmel SHA device-tree node in that case.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   board/CZ.NIC/turris_omnia/turris_omnia.c | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index b2f0088e5e..3b7a71bdad 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -1007,6 +1007,25 @@ static int fixup_mcu_gpio_in_eth_wan_node(void *blob)
>   	return 0;
>   }
>   
> +static void fixup_atsha_node(void *blob)
> +{
> +	int node;
> +
> +	if (!omnia_mcu_has_feature(FEAT_CRYPTO))
> +		return;
> +
> +	node = fdt_node_offset_by_compatible(blob, -1, "atmel,atsha204a");
> +	if (node < 0) {
> +		printf("Cannot find ATSHA204A node!\n");
> +		return;
> +	}
> +
> +	if (fdt_status_disabled(blob, node) < 0)
> +		printf("Cannot disable ATSHA204A node!\n");
> +	else
> +		debug("Disabled ATSHA204A node\n");
> +}
> +
>   #endif
>   
>   #if IS_ENABLED(CONFIG_OF_BOARD_FIXUP)
> @@ -1020,6 +1039,8 @@ int board_fix_fdt(void *blob)
>   	fixup_msata_port_nodes(blob);
>   	fixup_wwan_port_nodes(blob);
>   
> +	fixup_atsha_node(blob);
> +
>   	return 0;
>   }
>   #endif
> @@ -1211,6 +1232,8 @@ int ft_board_setup(void *blob, struct bd_info *bd)
>   	fixup_msata_port_nodes(blob);
>   	fixup_wwan_port_nodes(blob);
>   
> +	fixup_atsha_node(blob);
> +
>   	return 0;
>   }
>   #endif

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 08/18] arm: mvebu: spl: Do not build mvebu-reset in SPL

[Marek Behún]

Commit 35e29e89a386 ("arm: mvebu: Implement simple mvebu-reset driver
for enabling/disabling PCIe ports") made it so that the mvebu reset
driver for enabling/disabling PCIe ports is build if CONFIG_DM_RESET is
enabled. This is because PCI_MVEBU depends on DM_RESET.

But the driver should not be built for SPL. Indeed the PCI_MVEBU driver
is not supported in SPL now, and so the mvebu-reset driver is not needed.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 arch/arm/mach-mvebu/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
index 0584ed2be5..ef790d97fe 100644
--- a/arch/arm/mach-mvebu/Makefile
+++ b/arch/arm/mach-mvebu/Makefile
@@ -22,13 +22,14 @@ else # CONFIG_ARCH_KIRKWOOD
 obj-y	= cpu.o
 obj-y	+= dram.o
 obj-y	+= lowlevel.o
-obj-$(CONFIG_DM_RESET) += system-controller.o
 ifndef CONFIG_SPL_BUILD
 obj-$(CONFIG_ARMADA_375) += ../../../drivers/ddr/marvell/axp/xor.o
 obj-$(CONFIG_ARMADA_38X) += ../../../drivers/ddr/marvell/a38x/xor.o
 obj-$(CONFIG_ARMADA_XP) += ../../../drivers/ddr/marvell/axp/xor.o
 obj-$(CONFIG_ARMADA_MSYS) += ../../../drivers/ddr/marvell/axp/xor.o
 
+obj-$(CONFIG_DM_RESET) += system-controller.o
+
 ifdef CONFIG_ARMADA_38X
 obj-$(CONFIG_MVEBU_EFUSE) += efuse.o
 endif
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 08/18] arm: mvebu: spl: Do not build mvebu-reset in SPL

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Commit 35e29e89a386 ("arm: mvebu: Implement simple mvebu-reset driver
> for enabling/disabling PCIe ports") made it so that the mvebu reset
> driver for enabling/disabling PCIe ports is build if CONFIG_DM_RESET is
> enabled. This is because PCI_MVEBU depends on DM_RESET.
> 
> But the driver should not be built for SPL. Indeed the PCI_MVEBU driver
> is not supported in SPL now, and so the mvebu-reset driver is not needed.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   arch/arm/mach-mvebu/Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index 0584ed2be5..ef790d97fe 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -22,13 +22,14 @@ else # CONFIG_ARCH_KIRKWOOD
>   obj-y	= cpu.o
>   obj-y	+= dram.o
>   obj-y	+= lowlevel.o
> -obj-$(CONFIG_DM_RESET) += system-controller.o
>   ifndef CONFIG_SPL_BUILD
>   obj-$(CONFIG_ARMADA_375) += ../../../drivers/ddr/marvell/axp/xor.o
>   obj-$(CONFIG_ARMADA_38X) += ../../../drivers/ddr/marvell/a38x/xor.o
>   obj-$(CONFIG_ARMADA_XP) += ../../../drivers/ddr/marvell/axp/xor.o
>   obj-$(CONFIG_ARMADA_MSYS) += ../../../drivers/ddr/marvell/axp/xor.o
>   
> +obj-$(CONFIG_DM_RESET) += system-controller.o
> +
>   ifdef CONFIG_ARMADA_38X
>   obj-$(CONFIG_MVEBU_EFUSE) += efuse.o
>   endif

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 09/18] arm: mvebu: system-controller: Rework to use UCLASS_SYSCON

[Marek Behún]

The system-controller driver for 32-bit Armada is currently registered
as UCLASS_RESET, since it only provides enabling/disabling PCIe ports.

Rework it as UCLASS_SYSCON and bind mvebu-reset as a child device.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 arch/arm/mach-mvebu/Kconfig             | 11 ++++
 arch/arm/mach-mvebu/Makefile            |  2 +-
 arch/arm/mach-mvebu/system-controller.c | 76 ++++++++++++++-----------
 3 files changed, 54 insertions(+), 35 deletions(-)

diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 2058c95ca2..62a2bc5958 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -18,6 +18,7 @@ config ARMADA_32BIT
 	select TOOLS_KWBIMAGE if SPL
 	select SPL_SYS_NO_VECTOR_TABLE if SPL
 	select ARCH_VERY_EARLY_INIT
+	select ARMADA_32BIT_SYSCON_RESET if DM_RESET
 
 # ARMv7 SoCs...
 config ARMADA_375
@@ -456,6 +457,16 @@ config SF_DEFAULT_MODE
 	default 0x0
 	depends on MVEBU_SPL_BOOT_DEVICE_SPI
 
+config ARMADA_32BIT_SYSCON_RESET
+	bool "Support Armada XP/375/38x/39x reset controller"
+	depends on ARMADA_32BIT
+	depends on DM_RESET
+	select REGMAP
+	select SYSCON
+	help
+	  Build support for Armada XP/375/38x/39x reset controller. This is
+	  needed for PCIe support.
+
 source "board/solidrun/clearfog/Kconfig"
 source "board/kobol/helios4/Kconfig"
 
diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
index ef790d97fe..d44ca3a0df 100644
--- a/arch/arm/mach-mvebu/Makefile
+++ b/arch/arm/mach-mvebu/Makefile
@@ -28,7 +28,7 @@ obj-$(CONFIG_ARMADA_38X) += ../../../drivers/ddr/marvell/a38x/xor.o
 obj-$(CONFIG_ARMADA_XP) += ../../../drivers/ddr/marvell/axp/xor.o
 obj-$(CONFIG_ARMADA_MSYS) += ../../../drivers/ddr/marvell/axp/xor.o
 
-obj-$(CONFIG_DM_RESET) += system-controller.o
+obj-$(CONFIG_ARMADA_32BIT_SYSCON_RESET) += system-controller.o
 
 ifdef CONFIG_ARMADA_38X
 obj-$(CONFIG_MVEBU_EFUSE) += efuse.o
diff --git a/arch/arm/mach-mvebu/system-controller.c b/arch/arm/mach-mvebu/system-controller.c
index 7cdde11cbd..c5c05922f2 100644
--- a/arch/arm/mach-mvebu/system-controller.c
+++ b/arch/arm/mach-mvebu/system-controller.c
@@ -1,19 +1,21 @@
 // SPDX-License-Identifier: GPL-2.0+
-// (C) 2021 Pali Rohár <pali@kernel.org>
+/*
+ * Copyright (C) 2021 Pali Rohár <pali@kernel.org>
+ * Copyright (C) 2024 Marek Behún <kabel@kernel.org>
+ */
 
 #include <common.h>
 #include <dm.h>
+#include <dm/lists.h>
+#include <regmap.h>
 #include <reset-uclass.h>
+#include <syscon.h>
 #include <asm/io.h>
 
 #define MVEBU_SOC_CONTROL_1_REG 0x4
 
 #define MVEBU_PCIE_ID 0
 
-struct mvebu_reset_data {
-	void *base;
-};
-
 static int mvebu_reset_of_xlate(struct reset_ctl *rst,
 				struct ofnode_phandle_args *args)
 {
@@ -46,46 +48,33 @@ static int mvebu_reset_free(struct reset_ctl *rst)
 
 static int mvebu_reset_assert(struct reset_ctl *rst)
 {
-	struct mvebu_reset_data *data = dev_get_priv(rst->dev);
+	struct regmap *regmap = syscon_get_regmap(rst->dev->parent);
 
-	clrbits_32(data->base + MVEBU_SOC_CONTROL_1_REG, BIT(rst->data));
-	return 0;
+	return regmap_update_bits(regmap, MVEBU_SOC_CONTROL_1_REG,
+				  BIT(rst->data), 0);
 }
 
 static int mvebu_reset_deassert(struct reset_ctl *rst)
 {
-	struct mvebu_reset_data *data = dev_get_priv(rst->dev);
+	struct regmap *regmap = syscon_get_regmap(rst->dev->parent);
 
-	setbits_32(data->base + MVEBU_SOC_CONTROL_1_REG, BIT(rst->data));
-	return 0;
+	return regmap_update_bits(regmap, MVEBU_SOC_CONTROL_1_REG,
+				  BIT(rst->data), BIT(rst->data));
 }
 
 static int mvebu_reset_status(struct reset_ctl *rst)
 {
-	struct mvebu_reset_data *data = dev_get_priv(rst->dev);
+	struct regmap *regmap = syscon_get_regmap(rst->dev->parent);
+	uint val;
+	int ret;
 
-	return !(readl(data->base + MVEBU_SOC_CONTROL_1_REG) & BIT(rst->data));
-}
-
-static int mvebu_reset_of_to_plat(struct udevice *dev)
-{
-	struct mvebu_reset_data *data = dev_get_priv(dev);
+	ret = regmap_read(regmap, MVEBU_SOC_CONTROL_1_REG, &val);
+	if (ret < 0)
+		return ret;
 
-	data->base = dev_read_addr_ptr(dev);
-	if (!data->base)
-		return -EINVAL;
-
-	return 0;
+	return !(val & BIT(rst->data));
 }
 
-static const struct udevice_id mvebu_reset_of_match[] = {
-	{ .compatible = "marvell,armada-370-xp-system-controller" },
-	{ .compatible = "marvell,armada-375-system-controller" },
-	{ .compatible = "marvell,armada-380-system-controller" },
-	{ .compatible = "marvell,armada-390-system-controller" },
-	{ },
-};
-
 static const struct reset_ops mvebu_reset_ops = {
 	.of_xlate = mvebu_reset_of_xlate,
 	.request = mvebu_reset_request,
@@ -98,8 +87,27 @@ static const struct reset_ops mvebu_reset_ops = {
 U_BOOT_DRIVER(mvebu_reset) = {
 	.name = "mvebu-reset",
 	.id = UCLASS_RESET,
-	.of_match = mvebu_reset_of_match,
-	.of_to_plat = mvebu_reset_of_to_plat,
-	.priv_auto = sizeof(struct mvebu_reset_data),
 	.ops = &mvebu_reset_ops,
 };
+
+static int mvebu_syscon_bind(struct udevice *dev)
+{
+	/* bind also mvebu-reset, with the same ofnode */
+	return device_bind_driver_to_node(dev, "mvebu-reset", "mvebu-reset",
+					  dev_ofnode(dev), NULL);
+}
+
+static const struct udevice_id mvebu_syscon_of_match[] = {
+	{ .compatible = "marvell,armada-370-xp-system-controller" },
+	{ .compatible = "marvell,armada-375-system-controller" },
+	{ .compatible = "marvell,armada-380-system-controller" },
+	{ .compatible = "marvell,armada-390-system-controller" },
+	{ },
+};
+
+U_BOOT_DRIVER(mvebu_syscon) = {
+	.name = "mvebu-system-controller",
+	.id = UCLASS_SYSCON,
+	.of_match = mvebu_syscon_of_match,
+	.bind = mvebu_syscon_bind,
+};
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 09/18] arm: mvebu: system-controller: Rework to use UCLASS_SYSCON

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> The system-controller driver for 32-bit Armada is currently registered
> as UCLASS_RESET, since it only provides enabling/disabling PCIe ports.
> 
> Rework it as UCLASS_SYSCON and bind mvebu-reset as a child device.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   arch/arm/mach-mvebu/Kconfig             | 11 ++++
>   arch/arm/mach-mvebu/Makefile            |  2 +-
>   arch/arm/mach-mvebu/system-controller.c | 76 ++++++++++++++-----------
>   3 files changed, 54 insertions(+), 35 deletions(-)
> 
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 2058c95ca2..62a2bc5958 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -18,6 +18,7 @@ config ARMADA_32BIT
>   	select TOOLS_KWBIMAGE if SPL
>   	select SPL_SYS_NO_VECTOR_TABLE if SPL
>   	select ARCH_VERY_EARLY_INIT
> +	select ARMADA_32BIT_SYSCON_RESET if DM_RESET
>   
>   # ARMv7 SoCs...
>   config ARMADA_375
> @@ -456,6 +457,16 @@ config SF_DEFAULT_MODE
>   	default 0x0
>   	depends on MVEBU_SPL_BOOT_DEVICE_SPI
>   
> +config ARMADA_32BIT_SYSCON_RESET
> +	bool "Support Armada XP/375/38x/39x reset controller"
> +	depends on ARMADA_32BIT
> +	depends on DM_RESET
> +	select REGMAP
> +	select SYSCON
> +	help
> +	  Build support for Armada XP/375/38x/39x reset controller. This is
> +	  needed for PCIe support.
> +
>   source "board/solidrun/clearfog/Kconfig"
>   source "board/kobol/helios4/Kconfig"
>   
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index ef790d97fe..d44ca3a0df 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -28,7 +28,7 @@ obj-$(CONFIG_ARMADA_38X) += ../../../drivers/ddr/marvell/a38x/xor.o
>   obj-$(CONFIG_ARMADA_XP) += ../../../drivers/ddr/marvell/axp/xor.o
>   obj-$(CONFIG_ARMADA_MSYS) += ../../../drivers/ddr/marvell/axp/xor.o
>   
> -obj-$(CONFIG_DM_RESET) += system-controller.o
> +obj-$(CONFIG_ARMADA_32BIT_SYSCON_RESET) += system-controller.o
>   
>   ifdef CONFIG_ARMADA_38X
>   obj-$(CONFIG_MVEBU_EFUSE) += efuse.o
> diff --git a/arch/arm/mach-mvebu/system-controller.c b/arch/arm/mach-mvebu/system-controller.c
> index 7cdde11cbd..c5c05922f2 100644
> --- a/arch/arm/mach-mvebu/system-controller.c
> +++ b/arch/arm/mach-mvebu/system-controller.c
> @@ -1,19 +1,21 @@
>   // SPDX-License-Identifier: GPL-2.0+
> -// (C) 2021 Pali Rohár <pali@kernel.org>
> +/*
> + * Copyright (C) 2021 Pali Rohár <pali@kernel.org>
> + * Copyright (C) 2024 Marek Behún <kabel@kernel.org>
> + */
>   
>   #include <common.h>
>   #include <dm.h>
> +#include <dm/lists.h>
> +#include <regmap.h>
>   #include <reset-uclass.h>
> +#include <syscon.h>
>   #include <asm/io.h>
>   
>   #define MVEBU_SOC_CONTROL_1_REG 0x4
>   
>   #define MVEBU_PCIE_ID 0
>   
> -struct mvebu_reset_data {
> -	void *base;
> -};
> -
>   static int mvebu_reset_of_xlate(struct reset_ctl *rst,
>   				struct ofnode_phandle_args *args)
>   {
> @@ -46,46 +48,33 @@ static int mvebu_reset_free(struct reset_ctl *rst)
>   
>   static int mvebu_reset_assert(struct reset_ctl *rst)
>   {
> -	struct mvebu_reset_data *data = dev_get_priv(rst->dev);
> +	struct regmap *regmap = syscon_get_regmap(rst->dev->parent);
>   
> -	clrbits_32(data->base + MVEBU_SOC_CONTROL_1_REG, BIT(rst->data));
> -	return 0;
> +	return regmap_update_bits(regmap, MVEBU_SOC_CONTROL_1_REG,
> +				  BIT(rst->data), 0);
>   }
>   
>   static int mvebu_reset_deassert(struct reset_ctl *rst)
>   {
> -	struct mvebu_reset_data *data = dev_get_priv(rst->dev);
> +	struct regmap *regmap = syscon_get_regmap(rst->dev->parent);
>   
> -	setbits_32(data->base + MVEBU_SOC_CONTROL_1_REG, BIT(rst->data));
> -	return 0;
> +	return regmap_update_bits(regmap, MVEBU_SOC_CONTROL_1_REG,
> +				  BIT(rst->data), BIT(rst->data));
>   }
>   
>   static int mvebu_reset_status(struct reset_ctl *rst)
>   {
> -	struct mvebu_reset_data *data = dev_get_priv(rst->dev);
> +	struct regmap *regmap = syscon_get_regmap(rst->dev->parent);
> +	uint val;
> +	int ret;
>   
> -	return !(readl(data->base + MVEBU_SOC_CONTROL_1_REG) & BIT(rst->data));
> -}
> -
> -static int mvebu_reset_of_to_plat(struct udevice *dev)
> -{
> -	struct mvebu_reset_data *data = dev_get_priv(dev);
> +	ret = regmap_read(regmap, MVEBU_SOC_CONTROL_1_REG, &val);
> +	if (ret < 0)
> +		return ret;
>   
> -	data->base = dev_read_addr_ptr(dev);
> -	if (!data->base)
> -		return -EINVAL;
> -
> -	return 0;
> +	return !(val & BIT(rst->data));
>   }
>   
> -static const struct udevice_id mvebu_reset_of_match[] = {
> -	{ .compatible = "marvell,armada-370-xp-system-controller" },
> -	{ .compatible = "marvell,armada-375-system-controller" },
> -	{ .compatible = "marvell,armada-380-system-controller" },
> -	{ .compatible = "marvell,armada-390-system-controller" },
> -	{ },
> -};
> -
>   static const struct reset_ops mvebu_reset_ops = {
>   	.of_xlate = mvebu_reset_of_xlate,
>   	.request = mvebu_reset_request,
> @@ -98,8 +87,27 @@ static const struct reset_ops mvebu_reset_ops = {
>   U_BOOT_DRIVER(mvebu_reset) = {
>   	.name = "mvebu-reset",
>   	.id = UCLASS_RESET,
> -	.of_match = mvebu_reset_of_match,
> -	.of_to_plat = mvebu_reset_of_to_plat,
> -	.priv_auto = sizeof(struct mvebu_reset_data),
>   	.ops = &mvebu_reset_ops,
>   };
> +
> +static int mvebu_syscon_bind(struct udevice *dev)
> +{
> +	/* bind also mvebu-reset, with the same ofnode */
> +	return device_bind_driver_to_node(dev, "mvebu-reset", "mvebu-reset",
> +					  dev_ofnode(dev), NULL);
> +}
> +
> +static const struct udevice_id mvebu_syscon_of_match[] = {
> +	{ .compatible = "marvell,armada-370-xp-system-controller" },
> +	{ .compatible = "marvell,armada-375-system-controller" },
> +	{ .compatible = "marvell,armada-380-system-controller" },
> +	{ .compatible = "marvell,armada-390-system-controller" },
> +	{ },
> +};
> +
> +U_BOOT_DRIVER(mvebu_syscon) = {
> +	.name = "mvebu-system-controller",
> +	.id = UCLASS_SYSCON,
> +	.of_match = mvebu_syscon_of_match,
> +	.bind = mvebu_syscon_bind,
> +};

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 10/18] arm: mvebu: system-controller: Select mvebu-reset if DM_RESET && PCI_MVEBU

[Marek Behún]

The mvebu-reset driver is only needed by the mvebu PCIe driver, but
currently it is automatically selected if DM_RESET is enabled. Add the
condition of PCI_MVEBU also being enabled for mvebu-reset to be
selected.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 arch/arm/mach-mvebu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 62a2bc5958..623432a60e 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -18,7 +18,7 @@ config ARMADA_32BIT
 	select TOOLS_KWBIMAGE if SPL
 	select SPL_SYS_NO_VECTOR_TABLE if SPL
 	select ARCH_VERY_EARLY_INIT
-	select ARMADA_32BIT_SYSCON_RESET if DM_RESET
+	select ARMADA_32BIT_SYSCON_RESET if DM_RESET && PCI_MVEBU
 
 # ARMv7 SoCs...
 config ARMADA_375
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 10/18] arm: mvebu: system-controller: Select mvebu-reset if DM_RESET && PCI_MVEBU

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> The mvebu-reset driver is only needed by the mvebu PCIe driver, but
> currently it is automatically selected if DM_RESET is enabled. Add the
> condition of PCI_MVEBU also being enabled for mvebu-reset to be
> selected.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   arch/arm/mach-mvebu/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 62a2bc5958..623432a60e 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -18,7 +18,7 @@ config ARMADA_32BIT
>   	select TOOLS_KWBIMAGE if SPL
>   	select SPL_SYS_NO_VECTOR_TABLE if SPL
>   	select ARCH_VERY_EARLY_INIT
> -	select ARMADA_32BIT_SYSCON_RESET if DM_RESET
> +	select ARMADA_32BIT_SYSCON_RESET if DM_RESET && PCI_MVEBU
>   
>   # ARMv7 SoCs...
>   config ARMADA_375

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

[Marek Behún]

Add driver model support for sysreset via mvebu system controller. This is
currently only available for U-Boot proper.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 arch/arm/mach-mvebu/Kconfig             | 18 +++++-
 arch/arm/mach-mvebu/Makefile            |  2 +-
 arch/arm/mach-mvebu/cpu.c               |  2 +
 arch/arm/mach-mvebu/system-controller.c | 74 +++++++++++++++++++++++--
 4 files changed, 89 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 623432a60e..f15d3cc5ed 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -19,6 +19,7 @@ config ARMADA_32BIT
 	select SPL_SYS_NO_VECTOR_TABLE if SPL
 	select ARCH_VERY_EARLY_INIT
 	select ARMADA_32BIT_SYSCON_RESET if DM_RESET && PCI_MVEBU
+	select ARMADA_32BIT_SYSCON_SYSRESET if SYSRESET
 
 # ARMv7 SoCs...
 config ARMADA_375
@@ -457,16 +458,29 @@ config SF_DEFAULT_MODE
 	default 0x0
 	depends on MVEBU_SPL_BOOT_DEVICE_SPI
 
+config ARMADA_32BIT_SYSCON
+	bool
+	depends on ARMADA_32BIT
+	select REGMAP
+	select SYSCON
+
 config ARMADA_32BIT_SYSCON_RESET
 	bool "Support Armada XP/375/38x/39x reset controller"
 	depends on ARMADA_32BIT
 	depends on DM_RESET
-	select REGMAP
-	select SYSCON
+	select ARMADA_32BIT_SYSCON
 	help
 	  Build support for Armada XP/375/38x/39x reset controller. This is
 	  needed for PCIe support.
 
+config ARMADA_32BIT_SYSCON_SYSRESET
+	bool "Support Armada XP/375/38x/39x sysreset via driver model"
+	depends on ARMADA_32BIT
+	depends on SYSRESET
+	select ARMADA_32BIT_SYSCON
+	help
+	  Build support for Armada XP/375/38x/39x system reset via driver model.
+
 source "board/solidrun/clearfog/Kconfig"
 source "board/kobol/helios4/Kconfig"
 
diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
index d44ca3a0df..329c2e4915 100644
--- a/arch/arm/mach-mvebu/Makefile
+++ b/arch/arm/mach-mvebu/Makefile
@@ -28,7 +28,7 @@ obj-$(CONFIG_ARMADA_38X) += ../../../drivers/ddr/marvell/a38x/xor.o
 obj-$(CONFIG_ARMADA_XP) += ../../../drivers/ddr/marvell/axp/xor.o
 obj-$(CONFIG_ARMADA_MSYS) += ../../../drivers/ddr/marvell/axp/xor.o
 
-obj-$(CONFIG_ARMADA_32BIT_SYSCON_RESET) += system-controller.o
+obj-$(CONFIG_ARMADA_32BIT_SYSCON) += system-controller.o
 
 ifdef CONFIG_ARMADA_38X
 obj-$(CONFIG_MVEBU_EFUSE) += efuse.o
diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu/cpu.c
index 8e0de93538..7c62a5dbb6 100644
--- a/arch/arm/mach-mvebu/cpu.c
+++ b/arch/arm/mach-mvebu/cpu.c
@@ -52,6 +52,7 @@ void lowlevel_init(void)
 	 */
 }
 
+#if defined(CONFIG_SPL_BUILD) || !defined(CONFIG_ARMADA_32BIT_SYSCON_SYSRESET)
 void reset_cpu(void)
 {
 	struct mvebu_system_registers *reg =
@@ -62,6 +63,7 @@ void reset_cpu(void)
 	while (1)
 		;
 }
+#endif
 
 u32 get_boot_device(void)
 {
diff --git a/arch/arm/mach-mvebu/system-controller.c b/arch/arm/mach-mvebu/system-controller.c
index c5c05922f2..b5f8afb96d 100644
--- a/arch/arm/mach-mvebu/system-controller.c
+++ b/arch/arm/mach-mvebu/system-controller.c
@@ -10,11 +10,24 @@
 #include <regmap.h>
 #include <reset-uclass.h>
 #include <syscon.h>
+#include <sysreset.h>
 #include <asm/io.h>
 
-#define MVEBU_SOC_CONTROL_1_REG 0x4
+#define MVEBU_SOC_CONTROL_1_REG		0x4
 
-#define MVEBU_PCIE_ID 0
+#if defined(CONFIG_ARMADA_375)
+# define MVEBU_RSTOUTN_MASK_REG		0x54
+# define MVEBU_SYS_SOFT_RST_REG		0x58
+#else
+# define MVEBU_RSTOUTN_MASK_REG		0x60
+# define MVEBU_SYS_SOFT_RST_REG		0x64
+#endif
+
+#define MVEBU_GLOBAL_SOFT_RST_BIT	BIT(0)
+
+#define MVEBU_PCIE_ID			0
+
+#if IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_RESET)
 
 static int mvebu_reset_of_xlate(struct reset_ctl *rst,
 				struct ofnode_phandle_args *args)
@@ -90,11 +103,64 @@ U_BOOT_DRIVER(mvebu_reset) = {
 	.ops = &mvebu_reset_ops,
 };
 
+#endif /* IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_RESET) */
+
+#if IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_SYSRESET)
+
+static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t type)
+{
+	struct regmap *regmap = syscon_get_regmap(dev->parent);
+	uint bit;
+
+	if (type != SYSRESET_COLD)
+		return -EPROTONOSUPPORT;
+
+	bit = MVEBU_GLOBAL_SOFT_RST_BIT;
+
+	regmap_update_bits(regmap, MVEBU_RSTOUTN_MASK_REG, bit, bit);
+	regmap_update_bits(regmap, MVEBU_SYS_SOFT_RST_REG, bit, bit);
+
+	while (1)
+		;
+
+	return 0;
+}
+
+static struct sysreset_ops mvebu_sysreset_ops = {
+	.request = mvebu_sysreset_request,
+};
+
+U_BOOT_DRIVER(mvebu_sysreset) = {
+	.name = "mvebu-sysreset",
+	.id = UCLASS_SYSRESET,
+	.ops = &mvebu_sysreset_ops,
+};
+
+#endif /* IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_SYSRESET) */
+
 static int mvebu_syscon_bind(struct udevice *dev)
 {
+	int ret = 0;
+
 	/* bind also mvebu-reset, with the same ofnode */
-	return device_bind_driver_to_node(dev, "mvebu-reset", "mvebu-reset",
-					  dev_ofnode(dev), NULL);
+	if (IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_RESET)) {
+		ret = device_bind_driver_to_node(dev, "mvebu-reset",
+						 "mvebu-reset", dev_ofnode(dev),
+						 NULL);
+		if (ret < 0)
+			return ret;
+	}
+
+	/* bind also mvebu-sysreset, with the same ofnode */
+	if (IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_SYSRESET)) {
+		ret = device_bind_driver_to_node(dev, "mvebu-sysreset",
+						 "mvebu-sysreset",
+						 dev_ofnode(dev), NULL);
+		if (ret < 0)
+			return ret;
+	}
+
+	return ret;
 }
 
 static const struct udevice_id mvebu_syscon_of_match[] = {
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Add driver model support for sysreset via mvebu system controller. This is
> currently only available for U-Boot proper.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Only a minor comment below. Other than this:

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   arch/arm/mach-mvebu/Kconfig             | 18 +++++-
>   arch/arm/mach-mvebu/Makefile            |  2 +-
>   arch/arm/mach-mvebu/cpu.c               |  2 +
>   arch/arm/mach-mvebu/system-controller.c | 74 +++++++++++++++++++++++--
>   4 files changed, 89 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 623432a60e..f15d3cc5ed 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -19,6 +19,7 @@ config ARMADA_32BIT
>   	select SPL_SYS_NO_VECTOR_TABLE if SPL
>   	select ARCH_VERY_EARLY_INIT
>   	select ARMADA_32BIT_SYSCON_RESET if DM_RESET && PCI_MVEBU
> +	select ARMADA_32BIT_SYSCON_SYSRESET if SYSRESET
>   
>   # ARMv7 SoCs...
>   config ARMADA_375
> @@ -457,16 +458,29 @@ config SF_DEFAULT_MODE
>   	default 0x0
>   	depends on MVEBU_SPL_BOOT_DEVICE_SPI
>   
> +config ARMADA_32BIT_SYSCON
> +	bool
> +	depends on ARMADA_32BIT
> +	select REGMAP
> +	select SYSCON
> +
>   config ARMADA_32BIT_SYSCON_RESET
>   	bool "Support Armada XP/375/38x/39x reset controller"
>   	depends on ARMADA_32BIT
>   	depends on DM_RESET
> -	select REGMAP
> -	select SYSCON
> +	select ARMADA_32BIT_SYSCON
>   	help
>   	  Build support for Armada XP/375/38x/39x reset controller. This is
>   	  needed for PCIe support.
>   
> +config ARMADA_32BIT_SYSCON_SYSRESET
> +	bool "Support Armada XP/375/38x/39x sysreset via driver model"
> +	depends on ARMADA_32BIT
> +	depends on SYSRESET
> +	select ARMADA_32BIT_SYSCON
> +	help
> +	  Build support for Armada XP/375/38x/39x system reset via driver model.
> +
>   source "board/solidrun/clearfog/Kconfig"
>   source "board/kobol/helios4/Kconfig"
>   
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index d44ca3a0df..329c2e4915 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -28,7 +28,7 @@ obj-$(CONFIG_ARMADA_38X) += ../../../drivers/ddr/marvell/a38x/xor.o
>   obj-$(CONFIG_ARMADA_XP) += ../../../drivers/ddr/marvell/axp/xor.o
>   obj-$(CONFIG_ARMADA_MSYS) += ../../../drivers/ddr/marvell/axp/xor.o
>   
> -obj-$(CONFIG_ARMADA_32BIT_SYSCON_RESET) += system-controller.o
> +obj-$(CONFIG_ARMADA_32BIT_SYSCON) += system-controller.o
>   
>   ifdef CONFIG_ARMADA_38X
>   obj-$(CONFIG_MVEBU_EFUSE) += efuse.o
> diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu/cpu.c
> index 8e0de93538..7c62a5dbb6 100644
> --- a/arch/arm/mach-mvebu/cpu.c
> +++ b/arch/arm/mach-mvebu/cpu.c
> @@ -52,6 +52,7 @@ void lowlevel_init(void)
>   	 */
>   }
>   
> +#if defined(CONFIG_SPL_BUILD) || !defined(CONFIG_ARMADA_32BIT_SYSCON_SYSRESET)
>   void reset_cpu(void)
>   {
>   	struct mvebu_system_registers *reg =
> @@ -62,6 +63,7 @@ void reset_cpu(void)
>   	while (1)
>   		;
>   }
> +#endif
>   
>   u32 get_boot_device(void)
>   {
> diff --git a/arch/arm/mach-mvebu/system-controller.c b/arch/arm/mach-mvebu/system-controller.c
> index c5c05922f2..b5f8afb96d 100644
> --- a/arch/arm/mach-mvebu/system-controller.c
> +++ b/arch/arm/mach-mvebu/system-controller.c
> @@ -10,11 +10,24 @@
>   #include <regmap.h>
>   #include <reset-uclass.h>
>   #include <syscon.h>
> +#include <sysreset.h>
>   #include <asm/io.h>
>   
> -#define MVEBU_SOC_CONTROL_1_REG 0x4
> +#define MVEBU_SOC_CONTROL_1_REG		0x4
>   
> -#define MVEBU_PCIE_ID 0
> +#if defined(CONFIG_ARMADA_375)
> +# define MVEBU_RSTOUTN_MASK_REG		0x54
> +# define MVEBU_SYS_SOFT_RST_REG		0x58
> +#else
> +# define MVEBU_RSTOUTN_MASK_REG		0x60
> +# define MVEBU_SYS_SOFT_RST_REG		0x64
> +#endif
> +
> +#define MVEBU_GLOBAL_SOFT_RST_BIT	BIT(0)
> +
> +#define MVEBU_PCIE_ID			0
> +
> +#if IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_RESET)
>   
>   static int mvebu_reset_of_xlate(struct reset_ctl *rst,
>   				struct ofnode_phandle_args *args)
> @@ -90,11 +103,64 @@ U_BOOT_DRIVER(mvebu_reset) = {
>   	.ops = &mvebu_reset_ops,
>   };
>   
> +#endif /* IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_RESET) */
> +
> +#if IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_SYSRESET)
> +
> +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t type)
> +{
> +	struct regmap *regmap = syscon_get_regmap(dev->parent);
> +	uint bit;
> +
> +	if (type != SYSRESET_COLD)
> +		return -EPROTONOSUPPORT;
> +
> +	bit = MVEBU_GLOBAL_SOFT_RST_BIT;
> +
> +	regmap_update_bits(regmap, MVEBU_RSTOUTN_MASK_REG, bit, bit);
> +	regmap_update_bits(regmap, MVEBU_SYS_SOFT_RST_REG, bit, bit);
> +
> +	while (1)
> +		;

A comment before this endless loop might be helpful here.

> +
> +	return 0;
> +}
> +
> +static struct sysreset_ops mvebu_sysreset_ops = {
> +	.request = mvebu_sysreset_request,
> +};
> +
> +U_BOOT_DRIVER(mvebu_sysreset) = {
> +	.name = "mvebu-sysreset",
> +	.id = UCLASS_SYSRESET,
> +	.ops = &mvebu_sysreset_ops,
> +};
> +
> +#endif /* IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_SYSRESET) */
> +
>   static int mvebu_syscon_bind(struct udevice *dev)
>   {
> +	int ret = 0;
> +
>   	/* bind also mvebu-reset, with the same ofnode */
> -	return device_bind_driver_to_node(dev, "mvebu-reset", "mvebu-reset",
> -					  dev_ofnode(dev), NULL);
> +	if (IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_RESET)) {
> +		ret = device_bind_driver_to_node(dev, "mvebu-reset",
> +						 "mvebu-reset", dev_ofnode(dev),
> +						 NULL);
> +		if (ret < 0)
> +			return ret;
> +	}
> +
> +	/* bind also mvebu-sysreset, with the same ofnode */
> +	if (IS_ENABLED(CONFIG_ARMADA_32BIT_SYSCON_SYSRESET)) {
> +		ret = device_bind_driver_to_node(dev, "mvebu-sysreset",
> +						 "mvebu-sysreset",
> +						 dev_ofnode(dev), NULL);
> +		if (ret < 0)
> +			return ret;
> +	}
> +
> +	return ret;
>   }
>   
>   static const struct udevice_id mvebu_syscon_of_match[] = {

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

[Marek Behún]

On Thu, 28 Mar 2024 11:04:45 +0100
Stefan Roese <sr@denx.de> wrote:

> > +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t type)
> > +{
> > +	struct regmap *regmap = syscon_get_regmap(dev->parent);
> > +	uint bit;
> > +
> > +	if (type != SYSRESET_COLD)
> > +		return -EPROTONOSUPPORT;
> > +
> > +	bit = MVEBU_GLOBAL_SOFT_RST_BIT;
> > +
> > +	regmap_update_bits(regmap, MVEBU_RSTOUTN_MASK_REG, bit, bit);
> > +	regmap_update_bits(regmap, MVEBU_SYS_SOFT_RST_REG, bit, bit);
> > +
> > +	while (1)
> > +		;  
> 
> A comment before this endless loop might be helpful here.

The code does the same as reset_cpu() in cpu.c, and the while() cycle
is not commented there.

But we can add something like
  /* something has gone wrong if we reach here, so we may as well stay
   * here */

What do you think? Could you amend the patch?

Marek

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

[Stefan Roese]

On 3/28/24 12:21, Marek Behún wrote:
> On Thu, 28 Mar 2024 11:04:45 +0100
> Stefan Roese <sr@denx.de> wrote:
> 
>>> +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t type)
>>> +{
>>> +	struct regmap *regmap = syscon_get_regmap(dev->parent);
>>> +	uint bit;
>>> +
>>> +	if (type != SYSRESET_COLD)
>>> +		return -EPROTONOSUPPORT;
>>> +
>>> +	bit = MVEBU_GLOBAL_SOFT_RST_BIT;
>>> +
>>> +	regmap_update_bits(regmap, MVEBU_RSTOUTN_MASK_REG, bit, bit);
>>> +	regmap_update_bits(regmap, MVEBU_SYS_SOFT_RST_REG, bit, bit);
>>> +
>>> +	while (1)
>>> +		;
>>
>> A comment before this endless loop might be helpful here.
> 
> The code does the same as reset_cpu() in cpu.c, and the while() cycle
> is not commented there.

Sure, other code might suffer this undocumented endless loop as well.
And again, this is more a nitpicking comment than a real requirement.

> But we can add something like
>    /* something has gone wrong if we reach here, so we may as well stay
>     * here */
> 
> What do you think? Could you amend the patch?

More something like this:

	/* Loop while waiting for the reset */
	while (1)
		;

And yes, I can fold this into your patchset, if I don't forget about
this. Still, if there is need for a v4, then please add it yourself.

Thanks,
Stefan

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

[Marek Behún]

On Thu, 28 Mar 2024 14:01:22 +0100
Stefan Roese <sr@denx.de> wrote:

> On 3/28/24 12:21, Marek Behún wrote:
> > On Thu, 28 Mar 2024 11:04:45 +0100
> > Stefan Roese <sr@denx.de> wrote:
> >   
> >>> +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t type)
> >>> +{
> >>> +	struct regmap *regmap = syscon_get_regmap(dev->parent);
> >>> +	uint bit;
> >>> +
> >>> +	if (type != SYSRESET_COLD)
> >>> +		return -EPROTONOSUPPORT;
> >>> +
> >>> +	bit = MVEBU_GLOBAL_SOFT_RST_BIT;
> >>> +
> >>> +	regmap_update_bits(regmap, MVEBU_RSTOUTN_MASK_REG, bit, bit);
> >>> +	regmap_update_bits(regmap, MVEBU_SYS_SOFT_RST_REG, bit, bit);
> >>> +
> >>> +	while (1)
> >>> +		;  
> >>
> >> A comment before this endless loop might be helpful here.  
> > 
> > The code does the same as reset_cpu() in cpu.c, and the while() cycle
> > is not commented there.  
> 
> Sure, other code might suffer this undocumented endless loop as well.
> And again, this is more a nitpicking comment than a real requirement.
> 
> > But we can add something like
> >    /* something has gone wrong if we reach here, so we may as well stay
> >     * here */
> > 
> > What do you think? Could you amend the patch?  
> 
> More something like this:
> 
> 	/* Loop while waiting for the reset */
> 	while (1)
> 		;

As of now I don't see a need for v4.

I may sent another patches regarding DDR training, but it will be
made on top of this series.

Marek

[PATCH u-boot-mvebu v3 12/18] gpio: turris_omnia_mcu: Use byteorder conversion functions

[Marek Behún]

Use byteorder conversion function instead of manually assembling data
from/to MCU.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/gpio/turris_omnia_mcu.c | 80 +++++++++++++++++++--------------
 1 file changed, 46 insertions(+), 34 deletions(-)

diff --git a/drivers/gpio/turris_omnia_mcu.c b/drivers/gpio/turris_omnia_mcu.c
index da9a6efe6d..c441d07d69 100644
--- a/drivers/gpio/turris_omnia_mcu.c
+++ b/drivers/gpio/turris_omnia_mcu.c
@@ -5,6 +5,7 @@
 #include <dm.h>
 #include <i2c.h>
 #include <turris-omnia-mcu-interface.h>
+#include <asm/byteorder.h>
 #include <asm/gpio.h>
 #include <linux/log2.h>
 
@@ -51,27 +52,31 @@ static int turris_omnia_mcu_get_function(struct udevice *dev, uint offset)
 static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
 {
 	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
-	u8 val16[2];
-	u8 val32[4];
+	u32 val32;
+	u16 val16;
 	int ret;
 
 	switch (offset) {
 	/* bank 0 */
 	case 0 ... 15:
-		ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, val16, 2);
+		ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&val16,
+				  sizeof(val16));
 		if (ret)
 			return ret;
-		return ((((u16)val16[1] << 8) | val16[0]) >> offset) & 0x1;
+
+		return !!(le16_to_cpu(val16) & BIT(offset));
 
 	/* bank 1 - supported only when FEAT_EXT_CMDS is set */
 	case (16 + 0) ... (16 + 31):
 		if (!(info->features & FEAT_EXT_CMDS))
 			return -EINVAL;
-		ret = dm_i2c_read(dev, CMD_GET_EXT_STATUS_DWORD, val32, 4);
+
+		ret = dm_i2c_read(dev, CMD_GET_EXT_STATUS_DWORD, (void *)&val32,
+				  sizeof(val32));
 		if (ret)
 			return ret;
-		return ((((u32)val32[3] << 24) | ((u32)val32[2] << 16) |
-			 ((u32)val32[1] << 8) | val32[0]) >> (offset - 16)) & 0x1;
+
+		return !!(le32_to_cpu(val32) & BIT(offset - 16));
 
 	/* bank 2 - supported only when FEAT_EXT_CMDS and FEAT_PERIPH_MCU is set */
 	case (16 + 32 + 0) ... (16 + 32 + 15):
@@ -79,10 +84,13 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
 			return -EINVAL;
 		if (!(info->features & FEAT_PERIPH_MCU))
 			return -EINVAL;
-		ret = dm_i2c_read(dev, CMD_GET_EXT_CONTROL_STATUS, val16, 2);
+
+		ret = dm_i2c_read(dev, CMD_GET_EXT_CONTROL_STATUS,
+				  (void *)&val16, sizeof(val16));
 		if (ret)
 			return ret;
-		return ((((u16)val16[1] << 8) | val16[0]) >> (offset - 16 - 32)) & 0x1;
+
+		return !!(le16_to_cpu(val16) & BIT(offset - 16 - 32));
 
 	default:
 		return -EINVAL;
@@ -92,30 +100,33 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
 static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int value)
 {
 	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
-	u8 val16[2];
-	u8 val32[4];
+	u16 valmask16[2];
+	u8 valmask8[2];
 
 	switch (offset) {
 	/* bank 0 */
 	case 0 ... 15:
 		switch (offset) {
 		case ilog2(STS_USB30_PWRON):
-			val16[1] = CTL_USB30_PWRON;
+			valmask8[1] = CTL_USB30_PWRON;
 			break;
 		case ilog2(STS_USB31_PWRON):
-			val16[1] = CTL_USB31_PWRON;
+			valmask8[1] = CTL_USB31_PWRON;
 			break;
 		case ilog2(STS_ENABLE_4V5):
-			val16[1] = CTL_ENABLE_4V5;
+			valmask8[1] = CTL_ENABLE_4V5;
 			break;
 		case ilog2(STS_BUTTON_MODE):
-			val16[1] = CTL_BUTTON_MODE;
+			valmask8[1] = CTL_BUTTON_MODE;
 			break;
 		default:
 			return -EINVAL;
 		}
-		val16[0] = value ? val16[1] : 0;
-		return dm_i2c_write(dev, CMD_GENERAL_CONTROL, val16, sizeof(val16));
+
+		valmask8[0] = value ? valmask8[1] : 0;
+
+		return dm_i2c_write(dev, CMD_GENERAL_CONTROL, valmask8,
+				    sizeof(valmask8));
 
 	/* bank 2 - supported only when FEAT_EXT_CMDS and FEAT_PERIPH_MCU is set */
 	case (16 + 32 + 0) ... (16 + 32 + 15):
@@ -123,11 +134,12 @@ static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int valu
 			return -EINVAL;
 		if (!(info->features & FEAT_PERIPH_MCU))
 			return -EINVAL;
-		val32[3] = BIT(offset - 16 - 32) >> 8;
-		val32[2] = BIT(offset - 16 - 32) & 0xff;
-		val32[1] = value ? val32[3] : 0;
-		val32[0] = value ? val32[2] : 0;
-		return dm_i2c_write(dev, CMD_EXT_CONTROL, val32, sizeof(val32));
+
+		valmask16[1] = cpu_to_le16(BIT(offset - 16 - 32));
+		valmask16[0] = value ? valmask16[1] : 0;
+
+		return dm_i2c_write(dev, CMD_EXT_CONTROL, (void *)valmask16,
+				    sizeof(valmask16));
 
 	default:
 		return -EINVAL;
@@ -216,25 +228,25 @@ static int turris_omnia_mcu_probe(struct udevice *dev)
 {
 	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
 	struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
-	u16 status;
-	u8 val[2];
+	u16 val;
 	int ret;
 
-	ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, val, 2);
-	if (ret) {
-		printf("Error: turris_omnia_mcu CMD_GET_STATUS_WORD failed: %d\n", ret);
+	ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&val, sizeof(val));
+	if (ret < 0) {
+		printf("Error: turris_omnia_mcu CMD_GET_STATUS_WORD failed: %d\n",
+		       ret);
 		return ret;
 	}
 
-	status = ((u16)val[1] << 8) | val[0];
-
-	if (status & STS_FEATURES_SUPPORTED) {
-		ret = dm_i2c_read(dev, CMD_GET_FEATURES, val, 2);
-		if (ret) {
-			printf("Error: turris_omnia_mcu CMD_GET_FEATURES failed: %d\n", ret);
+	if (le16_to_cpu(val) & STS_FEATURES_SUPPORTED) {
+		ret = dm_i2c_read(dev, CMD_GET_FEATURES, (void *)&val,
+				  sizeof(val));
+		if (ret < 0) {
+			printf("Error: turris_omnia_mcu CMD_GET_FEATURES failed: %d\n",
+			       ret);
 			return ret;
 		}
-		info->features = ((u16)val[1] << 8) | val[0];
+		info->features = le16_to_cpu(val);
 	}
 
 	uc_priv->bank_name = "mcu_";
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 12/18] gpio: turris_omnia_mcu: Use byteorder conversion functions

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Use byteorder conversion function instead of manually assembling data
> from/to MCU.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   drivers/gpio/turris_omnia_mcu.c | 80 +++++++++++++++++++--------------
>   1 file changed, 46 insertions(+), 34 deletions(-)
> 
> diff --git a/drivers/gpio/turris_omnia_mcu.c b/drivers/gpio/turris_omnia_mcu.c
> index da9a6efe6d..c441d07d69 100644
> --- a/drivers/gpio/turris_omnia_mcu.c
> +++ b/drivers/gpio/turris_omnia_mcu.c
> @@ -5,6 +5,7 @@
>   #include <dm.h>
>   #include <i2c.h>
>   #include <turris-omnia-mcu-interface.h>
> +#include <asm/byteorder.h>
>   #include <asm/gpio.h>
>   #include <linux/log2.h>
>   
> @@ -51,27 +52,31 @@ static int turris_omnia_mcu_get_function(struct udevice *dev, uint offset)
>   static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
>   {
>   	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
> -	u8 val16[2];
> -	u8 val32[4];
> +	u32 val32;
> +	u16 val16;
>   	int ret;
>   
>   	switch (offset) {
>   	/* bank 0 */
>   	case 0 ... 15:
> -		ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, val16, 2);
> +		ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&val16,
> +				  sizeof(val16));
>   		if (ret)
>   			return ret;
> -		return ((((u16)val16[1] << 8) | val16[0]) >> offset) & 0x1;
> +
> +		return !!(le16_to_cpu(val16) & BIT(offset));
>   
>   	/* bank 1 - supported only when FEAT_EXT_CMDS is set */
>   	case (16 + 0) ... (16 + 31):
>   		if (!(info->features & FEAT_EXT_CMDS))
>   			return -EINVAL;
> -		ret = dm_i2c_read(dev, CMD_GET_EXT_STATUS_DWORD, val32, 4);
> +
> +		ret = dm_i2c_read(dev, CMD_GET_EXT_STATUS_DWORD, (void *)&val32,
> +				  sizeof(val32));
>   		if (ret)
>   			return ret;
> -		return ((((u32)val32[3] << 24) | ((u32)val32[2] << 16) |
> -			 ((u32)val32[1] << 8) | val32[0]) >> (offset - 16)) & 0x1;
> +
> +		return !!(le32_to_cpu(val32) & BIT(offset - 16));
>   
>   	/* bank 2 - supported only when FEAT_EXT_CMDS and FEAT_PERIPH_MCU is set */
>   	case (16 + 32 + 0) ... (16 + 32 + 15):
> @@ -79,10 +84,13 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
>   			return -EINVAL;
>   		if (!(info->features & FEAT_PERIPH_MCU))
>   			return -EINVAL;
> -		ret = dm_i2c_read(dev, CMD_GET_EXT_CONTROL_STATUS, val16, 2);
> +
> +		ret = dm_i2c_read(dev, CMD_GET_EXT_CONTROL_STATUS,
> +				  (void *)&val16, sizeof(val16));
>   		if (ret)
>   			return ret;
> -		return ((((u16)val16[1] << 8) | val16[0]) >> (offset - 16 - 32)) & 0x1;
> +
> +		return !!(le16_to_cpu(val16) & BIT(offset - 16 - 32));
>   
>   	default:
>   		return -EINVAL;
> @@ -92,30 +100,33 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
>   static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int value)
>   {
>   	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
> -	u8 val16[2];
> -	u8 val32[4];
> +	u16 valmask16[2];
> +	u8 valmask8[2];
>   
>   	switch (offset) {
>   	/* bank 0 */
>   	case 0 ... 15:
>   		switch (offset) {
>   		case ilog2(STS_USB30_PWRON):
> -			val16[1] = CTL_USB30_PWRON;
> +			valmask8[1] = CTL_USB30_PWRON;
>   			break;
>   		case ilog2(STS_USB31_PWRON):
> -			val16[1] = CTL_USB31_PWRON;
> +			valmask8[1] = CTL_USB31_PWRON;
>   			break;
>   		case ilog2(STS_ENABLE_4V5):
> -			val16[1] = CTL_ENABLE_4V5;
> +			valmask8[1] = CTL_ENABLE_4V5;
>   			break;
>   		case ilog2(STS_BUTTON_MODE):
> -			val16[1] = CTL_BUTTON_MODE;
> +			valmask8[1] = CTL_BUTTON_MODE;
>   			break;
>   		default:
>   			return -EINVAL;
>   		}
> -		val16[0] = value ? val16[1] : 0;
> -		return dm_i2c_write(dev, CMD_GENERAL_CONTROL, val16, sizeof(val16));
> +
> +		valmask8[0] = value ? valmask8[1] : 0;
> +
> +		return dm_i2c_write(dev, CMD_GENERAL_CONTROL, valmask8,
> +				    sizeof(valmask8));
>   
>   	/* bank 2 - supported only when FEAT_EXT_CMDS and FEAT_PERIPH_MCU is set */
>   	case (16 + 32 + 0) ... (16 + 32 + 15):
> @@ -123,11 +134,12 @@ static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int valu
>   			return -EINVAL;
>   		if (!(info->features & FEAT_PERIPH_MCU))
>   			return -EINVAL;
> -		val32[3] = BIT(offset - 16 - 32) >> 8;
> -		val32[2] = BIT(offset - 16 - 32) & 0xff;
> -		val32[1] = value ? val32[3] : 0;
> -		val32[0] = value ? val32[2] : 0;
> -		return dm_i2c_write(dev, CMD_EXT_CONTROL, val32, sizeof(val32));
> +
> +		valmask16[1] = cpu_to_le16(BIT(offset - 16 - 32));
> +		valmask16[0] = value ? valmask16[1] : 0;
> +
> +		return dm_i2c_write(dev, CMD_EXT_CONTROL, (void *)valmask16,
> +				    sizeof(valmask16));
>   
>   	default:
>   		return -EINVAL;
> @@ -216,25 +228,25 @@ static int turris_omnia_mcu_probe(struct udevice *dev)
>   {
>   	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
>   	struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
> -	u16 status;
> -	u8 val[2];
> +	u16 val;
>   	int ret;
>   
> -	ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, val, 2);
> -	if (ret) {
> -		printf("Error: turris_omnia_mcu CMD_GET_STATUS_WORD failed: %d\n", ret);
> +	ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&val, sizeof(val));
> +	if (ret < 0) {
> +		printf("Error: turris_omnia_mcu CMD_GET_STATUS_WORD failed: %d\n",
> +		       ret);
>   		return ret;
>   	}
>   
> -	status = ((u16)val[1] << 8) | val[0];
> -
> -	if (status & STS_FEATURES_SUPPORTED) {
> -		ret = dm_i2c_read(dev, CMD_GET_FEATURES, val, 2);
> -		if (ret) {
> -			printf("Error: turris_omnia_mcu CMD_GET_FEATURES failed: %d\n", ret);
> +	if (le16_to_cpu(val) & STS_FEATURES_SUPPORTED) {
> +		ret = dm_i2c_read(dev, CMD_GET_FEATURES, (void *)&val,
> +				  sizeof(val));
> +		if (ret < 0) {
> +			printf("Error: turris_omnia_mcu CMD_GET_FEATURES failed: %d\n",
> +			       ret);
>   			return ret;
>   		}
> -		info->features = ((u16)val[1] << 8) | val[0];
> +		info->features = le16_to_cpu(val);
>   	}
>   
>   	uc_priv->bank_name = "mcu_";

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 13/18] gpio: turris_omnia_mcu: Update firmware features reading

[Marek Behún]

Update firmware features reading to try reading 32 bits of features and
fallback to reading 16 bits.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/gpio/turris_omnia_mcu.c | 32 ++++++++++++++++++++++----------
 1 file changed, 22 insertions(+), 10 deletions(-)

diff --git a/drivers/gpio/turris_omnia_mcu.c b/drivers/gpio/turris_omnia_mcu.c
index c441d07d69..40ced261e3 100644
--- a/drivers/gpio/turris_omnia_mcu.c
+++ b/drivers/gpio/turris_omnia_mcu.c
@@ -10,7 +10,7 @@
 #include <linux/log2.h>
 
 struct turris_omnia_mcu_info {
-	u16 features;
+	u32 features;
 };
 
 static int turris_omnia_mcu_get_function(struct udevice *dev, uint offset)
@@ -228,25 +228,37 @@ static int turris_omnia_mcu_probe(struct udevice *dev)
 {
 	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
 	struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
-	u16 val;
+	u32 dword;
+	u16 word;
 	int ret;
 
-	ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&val, sizeof(val));
+	ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&word, sizeof(word));
 	if (ret < 0) {
 		printf("Error: turris_omnia_mcu CMD_GET_STATUS_WORD failed: %d\n",
 		       ret);
 		return ret;
 	}
 
-	if (le16_to_cpu(val) & STS_FEATURES_SUPPORTED) {
-		ret = dm_i2c_read(dev, CMD_GET_FEATURES, (void *)&val,
-				  sizeof(val));
+	if (le16_to_cpu(word) & STS_FEATURES_SUPPORTED) {
+		/* try read 32-bit features */
+		ret = dm_i2c_read(dev, CMD_GET_FEATURES, (void *)&dword,
+				  sizeof(dword));
 		if (ret < 0) {
-			printf("Error: turris_omnia_mcu CMD_GET_FEATURES failed: %d\n",
-			       ret);
-			return ret;
+			/* try read 16-bit features */
+			ret = dm_i2c_read(dev, CMD_GET_FEATURES, (void *)&word,
+					  sizeof(word));
+			if (ret < 0) {
+				printf("Error: turris_omnia_mcu CMD_GET_FEATURES failed: %d\n",
+				       ret);
+				return ret;
+			}
+
+			info->features = le16_to_cpu(word);
+		} else {
+			info->features = le32_to_cpu(dword);
+			if (info->features & FEAT_FROM_BIT_16_INVALID)
+				info->features &= GENMASK(15, 0);
 		}
-		info->features = le16_to_cpu(val);
 	}
 
 	uc_priv->bank_name = "mcu_";
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 13/18] gpio: turris_omnia_mcu: Update firmware features reading

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Update firmware features reading to try reading 32 bits of features and
> fallback to reading 16 bits.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   drivers/gpio/turris_omnia_mcu.c | 32 ++++++++++++++++++++++----------
>   1 file changed, 22 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpio/turris_omnia_mcu.c b/drivers/gpio/turris_omnia_mcu.c
> index c441d07d69..40ced261e3 100644
> --- a/drivers/gpio/turris_omnia_mcu.c
> +++ b/drivers/gpio/turris_omnia_mcu.c
> @@ -10,7 +10,7 @@
>   #include <linux/log2.h>
>   
>   struct turris_omnia_mcu_info {
> -	u16 features;
> +	u32 features;
>   };
>   
>   static int turris_omnia_mcu_get_function(struct udevice *dev, uint offset)
> @@ -228,25 +228,37 @@ static int turris_omnia_mcu_probe(struct udevice *dev)
>   {
>   	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
>   	struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
> -	u16 val;
> +	u32 dword;
> +	u16 word;
>   	int ret;
>   
> -	ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&val, sizeof(val));
> +	ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&word, sizeof(word));
>   	if (ret < 0) {
>   		printf("Error: turris_omnia_mcu CMD_GET_STATUS_WORD failed: %d\n",
>   		       ret);
>   		return ret;
>   	}
>   
> -	if (le16_to_cpu(val) & STS_FEATURES_SUPPORTED) {
> -		ret = dm_i2c_read(dev, CMD_GET_FEATURES, (void *)&val,
> -				  sizeof(val));
> +	if (le16_to_cpu(word) & STS_FEATURES_SUPPORTED) {
> +		/* try read 32-bit features */
> +		ret = dm_i2c_read(dev, CMD_GET_FEATURES, (void *)&dword,
> +				  sizeof(dword));
>   		if (ret < 0) {
> -			printf("Error: turris_omnia_mcu CMD_GET_FEATURES failed: %d\n",
> -			       ret);
> -			return ret;
> +			/* try read 16-bit features */
> +			ret = dm_i2c_read(dev, CMD_GET_FEATURES, (void *)&word,
> +					  sizeof(word));
> +			if (ret < 0) {
> +				printf("Error: turris_omnia_mcu CMD_GET_FEATURES failed: %d\n",
> +				       ret);
> +				return ret;
> +			}
> +
> +			info->features = le16_to_cpu(word);
> +		} else {
> +			info->features = le32_to_cpu(dword);
> +			if (info->features & FEAT_FROM_BIT_16_INVALID)
> +				info->features &= GENMASK(15, 0);
>   		}
> -		info->features = le16_to_cpu(val);
>   	}
>   
>   	uc_priv->bank_name = "mcu_";

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 14/18] gpio: turris_omnia_mcu: Add support for system power off via sysreset

[Marek Behún]

Add support for system power off via UCLASS_SYSRESET. Newer versions of
Turris Omnia MCU firmware can power off the board (MCU will disable
almost all voltage regulators and go into low power mode).

Move the MCU driver into drivers/misc and register it under UCLASS_MISC.
The sysreset and gpio device are bound as child devices of the MCU device.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 configs/turris_omnia_defconfig            |   1 +
 drivers/gpio/Kconfig                      |   7 -
 drivers/gpio/Makefile                     |   1 -
 drivers/misc/Kconfig                      |  10 ++
 drivers/misc/Makefile                     |   1 +
 drivers/{gpio => misc}/turris_omnia_mcu.c | 150 ++++++++++++++++------
 6 files changed, 120 insertions(+), 50 deletions(-)
 rename drivers/{gpio => misc}/turris_omnia_mcu.c (60%)

diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index 39e15043df..9d5171c6a8 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -113,6 +113,7 @@ CONFIG_SPL_DEBUG_UART_BASE=0xd0012000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_KIRKWOOD_SPI=y
+CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_EHCI_HCD=y
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 2df3dc42d0..020c6ae74c 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -662,13 +662,6 @@ config SLG7XL45106_I2C_GPO
 	   8-bit gpo expander, all gpo lines are controlled by writing
 	   value into data register.
 
-config TURRIS_OMNIA_MCU
-	bool "Turris Omnia MCU GPIO driver"
-	depends on DM_GPIO
-	default y if TARGET_TURRIS_OMNIA
-	help
-	   Support for GPIOs on MCU connected to Turris Omnia via i2c.
-
 config FTGPIO010
 	bool "Faraday Technology FTGPIO010 driver"
 	depends on DM_GPIO
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index da3da5da2b..d637895c7a 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -73,7 +73,6 @@ obj-$(CONFIG_$(SPL_)MAX77663_GPIO)	+= max77663_gpio.o
 obj-$(CONFIG_SL28CPLD_GPIO)	+= sl28cpld-gpio.o
 obj-$(CONFIG_ZYNQMP_GPIO_MODEPIN)	+= zynqmp_gpio_modepin.o
 obj-$(CONFIG_SLG7XL45106_I2C_GPO)	+= gpio_slg7xl45106.o
-obj-$(CONFIG_$(SPL_TPL_)TURRIS_OMNIA_MCU)	+= turris_omnia_mcu.o
 obj-$(CONFIG_FTGPIO010)		+= ftgpio010.o
 obj-$(CONFIG_ADP5585_GPIO)	+= adp5585_gpio.o
 obj-$(CONFIG_RZG2L_GPIO)	+= rzg2l-gpio.o
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index f11ce72525..844a21be47 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -505,6 +505,16 @@ config TEST_DRV
 	  model. This should only be enabled for testing as it is not useful for
 	  anything else.
 
+config TURRIS_OMNIA_MCU
+	bool "Enable Turris Omnia MCU driver"
+	depends on DM_I2C
+	depends on DM_GPIO
+	depends on SYSRESET
+	default y if TARGET_TURRIS_OMNIA
+	help
+	  This enables support for Turris Omnia MCU connected GPIOs and
+	  board power off.
+
 config USB_HUB_USB251XB
 	tristate "USB251XB Hub Controller Configuration Driver"
 	depends on I2C
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 0432db6ed1..3cd8e2fd48 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -81,6 +81,7 @@ obj-$(CONFIG_SYS_DPAA_QBMAN) += fsl_portals.o
 obj-$(CONFIG_TEGRA186_BPMP) += tegra186_bpmp.o
 obj-$(CONFIG_TEGRA_CAR) += tegra_car.o
 obj-$(CONFIG_TEST_DRV) += test_drv.o
+obj-$(CONFIG_$(SPL_TPL_)TURRIS_OMNIA_MCU) += turris_omnia_mcu.o
 obj-$(CONFIG_TWL4030_LED) += twl4030_led.o
 obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress_config.o
 obj-$(CONFIG_WINBOND_W83627) += winbond_w83627.o
diff --git a/drivers/gpio/turris_omnia_mcu.c b/drivers/misc/turris_omnia_mcu.c
similarity index 60%
rename from drivers/gpio/turris_omnia_mcu.c
rename to drivers/misc/turris_omnia_mcu.c
index 40ced261e3..77a0424d61 100644
--- a/drivers/gpio/turris_omnia_mcu.c
+++ b/drivers/misc/turris_omnia_mcu.c
@@ -1,9 +1,14 @@
 // SPDX-License-Identifier: GPL-2.0+
-// (C) 2022 Pali Rohár <pali@kernel.org>
+/*
+ * Copyright (C) 2022 Pali Rohár <pali@kernel.org>
+ * Copyright (C) 2024 Marek Behún <kabel@kernel.org>
+ */
 
 #include <common.h>
 #include <dm.h>
+#include <dm/lists.h>
 #include <i2c.h>
+#include <sysreset.h>
 #include <turris-omnia-mcu-interface.h>
 #include <asm/byteorder.h>
 #include <asm/gpio.h>
@@ -13,9 +18,9 @@ struct turris_omnia_mcu_info {
 	u32 features;
 };
 
-static int turris_omnia_mcu_get_function(struct udevice *dev, uint offset)
+static int omnia_gpio_get_function(struct udevice *dev, uint offset)
 {
-	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
+	struct turris_omnia_mcu_info *info = dev_get_priv(dev->parent);
 
 	switch (offset) {
 	/* bank 0 */
@@ -49,9 +54,9 @@ static int turris_omnia_mcu_get_function(struct udevice *dev, uint offset)
 	}
 }
 
-static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
+static int omnia_gpio_get_value(struct udevice *dev, uint offset)
 {
-	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
+	struct turris_omnia_mcu_info *info = dev_get_priv(dev->parent);
 	u32 val32;
 	u16 val16;
 	int ret;
@@ -59,8 +64,8 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
 	switch (offset) {
 	/* bank 0 */
 	case 0 ... 15:
-		ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&val16,
-				  sizeof(val16));
+		ret = dm_i2c_read(dev->parent, CMD_GET_STATUS_WORD,
+				  (void *)&val16, sizeof(val16));
 		if (ret)
 			return ret;
 
@@ -71,8 +76,8 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
 		if (!(info->features & FEAT_EXT_CMDS))
 			return -EINVAL;
 
-		ret = dm_i2c_read(dev, CMD_GET_EXT_STATUS_DWORD, (void *)&val32,
-				  sizeof(val32));
+		ret = dm_i2c_read(dev->parent, CMD_GET_EXT_STATUS_DWORD,
+				  (void *)&val32, sizeof(val32));
 		if (ret)
 			return ret;
 
@@ -85,7 +90,7 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
 		if (!(info->features & FEAT_PERIPH_MCU))
 			return -EINVAL;
 
-		ret = dm_i2c_read(dev, CMD_GET_EXT_CONTROL_STATUS,
+		ret = dm_i2c_read(dev->parent, CMD_GET_EXT_CONTROL_STATUS,
 				  (void *)&val16, sizeof(val16));
 		if (ret)
 			return ret;
@@ -97,9 +102,9 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
 	}
 }
 
-static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int value)
+static int omnia_gpio_set_value(struct udevice *dev, uint offset, int value)
 {
-	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
+	struct turris_omnia_mcu_info *info = dev_get_priv(dev->parent);
 	u16 valmask16[2];
 	u8 valmask8[2];
 
@@ -125,7 +130,7 @@ static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int valu
 
 		valmask8[0] = value ? valmask8[1] : 0;
 
-		return dm_i2c_write(dev, CMD_GENERAL_CONTROL, valmask8,
+		return dm_i2c_write(dev->parent, CMD_GENERAL_CONTROL, valmask8,
 				    sizeof(valmask8));
 
 	/* bank 2 - supported only when FEAT_EXT_CMDS and FEAT_PERIPH_MCU is set */
@@ -138,19 +143,19 @@ static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int valu
 		valmask16[1] = cpu_to_le16(BIT(offset - 16 - 32));
 		valmask16[0] = value ? valmask16[1] : 0;
 
-		return dm_i2c_write(dev, CMD_EXT_CONTROL, (void *)valmask16,
-				    sizeof(valmask16));
+		return dm_i2c_write(dev->parent, CMD_EXT_CONTROL,
+				    (void *)valmask16, sizeof(valmask16));
 
 	default:
 		return -EINVAL;
 	}
 }
 
-static int turris_omnia_mcu_direction_input(struct udevice *dev, uint offset)
+static int omnia_gpio_direction_input(struct udevice *dev, uint offset)
 {
 	int ret;
 
-	ret = turris_omnia_mcu_get_function(dev, offset);
+	ret = omnia_gpio_get_function(dev, offset);
 	if (ret < 0)
 		return ret;
 	else if (ret != GPIOF_INPUT)
@@ -159,20 +164,20 @@ static int turris_omnia_mcu_direction_input(struct udevice *dev, uint offset)
 	return 0;
 }
 
-static int turris_omnia_mcu_direction_output(struct udevice *dev, uint offset, int value)
+static int omnia_gpio_direction_output(struct udevice *dev, uint offset, int value)
 {
 	int ret;
 
-	ret = turris_omnia_mcu_get_function(dev, offset);
+	ret = omnia_gpio_get_function(dev, offset);
 	if (ret < 0)
 		return ret;
 	else if (ret != GPIOF_OUTPUT)
 		return -EOPNOTSUPP;
 
-	return turris_omnia_mcu_set_value(dev, offset, value);
+	return omnia_gpio_set_value(dev, offset, value);
 }
 
-static int turris_omnia_mcu_xlate(struct udevice *dev, struct gpio_desc *desc,
+static int omnia_gpio_xlate(struct udevice *dev, struct gpio_desc *desc,
 				  struct ofnode_phandle_args *args)
 {
 	uint bank, gpio, flags, offset;
@@ -205,7 +210,7 @@ static int turris_omnia_mcu_xlate(struct udevice *dev, struct gpio_desc *desc,
 		return -EINVAL;
 	}
 
-	ret = turris_omnia_mcu_get_function(dev, offset);
+	ret = omnia_gpio_get_function(dev, offset);
 	if (ret < 0)
 		return ret;
 
@@ -215,19 +220,79 @@ static int turris_omnia_mcu_xlate(struct udevice *dev, struct gpio_desc *desc,
 	return 0;
 }
 
-static const struct dm_gpio_ops turris_omnia_mcu_ops = {
-	.direction_input	= turris_omnia_mcu_direction_input,
-	.direction_output	= turris_omnia_mcu_direction_output,
-	.get_value		= turris_omnia_mcu_get_value,
-	.set_value		= turris_omnia_mcu_set_value,
-	.get_function		= turris_omnia_mcu_get_function,
-	.xlate			= turris_omnia_mcu_xlate,
+static const struct dm_gpio_ops omnia_gpio_ops = {
+	.direction_input	= omnia_gpio_direction_input,
+	.direction_output	= omnia_gpio_direction_output,
+	.get_value		= omnia_gpio_get_value,
+	.set_value		= omnia_gpio_set_value,
+	.get_function		= omnia_gpio_get_function,
+	.xlate			= omnia_gpio_xlate,
 };
 
-static int turris_omnia_mcu_probe(struct udevice *dev)
+static int omnia_gpio_probe(struct udevice *dev)
 {
-	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
+	struct turris_omnia_mcu_info *info = dev_get_priv(dev->parent);
 	struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
+
+	uc_priv->bank_name = "mcu_";
+
+	if ((info->features & FEAT_EXT_CMDS) && (info->features & FEAT_PERIPH_MCU))
+		uc_priv->gpio_count = 16 + 32 + 16;
+	else if (info->features & FEAT_EXT_CMDS)
+		uc_priv->gpio_count = 16 + 32;
+	else
+		uc_priv->gpio_count = 16;
+
+	return 0;
+}
+
+U_BOOT_DRIVER(turris_omnia_mcu_gpio) = {
+	.name		= "turris-omnia-mcu-gpio",
+	.id		= UCLASS_GPIO,
+	.ops		= &omnia_gpio_ops,
+	.probe		= omnia_gpio_probe,
+};
+
+static int omnia_sysreset_request(struct udevice *dev, enum sysreset_t type)
+{
+	struct {
+		u16 magic;
+		u16 arg;
+		u32 csum;
+	} __packed args;
+
+	if (type != SYSRESET_POWER_OFF)
+		return -EPROTONOSUPPORT;
+
+	args.magic = CMD_POWER_OFF_MAGIC;
+	args.arg = CMD_POWER_OFF_POWERON_BUTTON;
+	args.csum = 0xba3b7212;
+
+	return dm_i2c_write(dev->parent, CMD_POWER_OFF, (void *)&args,
+			    sizeof(args));
+}
+
+static const struct sysreset_ops omnia_sysreset_ops = {
+	.request	= omnia_sysreset_request,
+};
+
+U_BOOT_DRIVER(turris_omnia_mcu_sysreset) = {
+	.name		= "turris-omnia-mcu-sysreset",
+	.id		= UCLASS_SYSRESET,
+	.ops		= &omnia_sysreset_ops,
+};
+
+static int turris_omnia_mcu_bind(struct udevice *dev)
+{
+	/* bind MCU GPIOs as a child device */
+	return device_bind_driver_to_node(dev, "turris-omnia-mcu-gpio",
+					  "turris-omnia-mcu-gpio",
+					  dev_ofnode(dev), NULL);
+}
+
+static int turris_omnia_mcu_probe(struct udevice *dev)
+{
+	struct turris_omnia_mcu_info *info = dev_get_priv(dev);
 	u32 dword;
 	u16 word;
 	int ret;
@@ -261,14 +326,15 @@ static int turris_omnia_mcu_probe(struct udevice *dev)
 		}
 	}
 
-	uc_priv->bank_name = "mcu_";
-
-	if ((info->features & FEAT_EXT_CMDS) && (info->features & FEAT_PERIPH_MCU))
-		uc_priv->gpio_count = 16 + 32 + 16;
-	else if (info->features & FEAT_EXT_CMDS)
-		uc_priv->gpio_count = 16 + 32;
-	else
-		uc_priv->gpio_count = 16;
+	/* bind sysreset if poweroff is supported */
+	if (info->features & FEAT_POWEROFF_WAKEUP) {
+		ret = device_bind_driver_to_node(dev,
+						 "turris-omnia-mcu-sysreset",
+						 "turris-omnia-mcu-sysreset",
+						 dev_ofnode(dev), NULL);
+		if (ret < 0)
+			return ret;
+	}
 
 	return 0;
 }
@@ -280,9 +346,9 @@ static const struct udevice_id turris_omnia_mcu_ids[] = {
 
 U_BOOT_DRIVER(turris_omnia_mcu) = {
 	.name		= "turris-omnia-mcu",
-	.id		= UCLASS_GPIO,
-	.ops		= &turris_omnia_mcu_ops,
+	.id		= UCLASS_MISC,
+	.bind		= turris_omnia_mcu_bind,
 	.probe		= turris_omnia_mcu_probe,
-	.plat_auto	= sizeof(struct turris_omnia_mcu_info),
+	.priv_auto	= sizeof(struct turris_omnia_mcu_info),
 	.of_match	= turris_omnia_mcu_ids,
 };
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 14/18] gpio: turris_omnia_mcu: Add support for system power off via sysreset

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Add support for system power off via UCLASS_SYSRESET. Newer versions of
> Turris Omnia MCU firmware can power off the board (MCU will disable
> almost all voltage regulators and go into low power mode).
> 
> Move the MCU driver into drivers/misc and register it under UCLASS_MISC.
> The sysreset and gpio device are bound as child devices of the MCU device.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   configs/turris_omnia_defconfig            |   1 +
>   drivers/gpio/Kconfig                      |   7 -
>   drivers/gpio/Makefile                     |   1 -
>   drivers/misc/Kconfig                      |  10 ++
>   drivers/misc/Makefile                     |   1 +
>   drivers/{gpio => misc}/turris_omnia_mcu.c | 150 ++++++++++++++++------
>   6 files changed, 120 insertions(+), 50 deletions(-)
>   rename drivers/{gpio => misc}/turris_omnia_mcu.c (60%)
> 
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index 39e15043df..9d5171c6a8 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -113,6 +113,7 @@ CONFIG_SPL_DEBUG_UART_BASE=0xd0012000
>   CONFIG_DEBUG_UART_SHIFT=2
>   CONFIG_SYS_NS16550=y
>   CONFIG_KIRKWOOD_SPI=y
> +CONFIG_SYSRESET=y
>   CONFIG_USB=y
>   CONFIG_USB_XHCI_HCD=y
>   CONFIG_USB_EHCI_HCD=y
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 2df3dc42d0..020c6ae74c 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -662,13 +662,6 @@ config SLG7XL45106_I2C_GPO
>   	   8-bit gpo expander, all gpo lines are controlled by writing
>   	   value into data register.
>   
> -config TURRIS_OMNIA_MCU
> -	bool "Turris Omnia MCU GPIO driver"
> -	depends on DM_GPIO
> -	default y if TARGET_TURRIS_OMNIA
> -	help
> -	   Support for GPIOs on MCU connected to Turris Omnia via i2c.
> -
>   config FTGPIO010
>   	bool "Faraday Technology FTGPIO010 driver"
>   	depends on DM_GPIO
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index da3da5da2b..d637895c7a 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -73,7 +73,6 @@ obj-$(CONFIG_$(SPL_)MAX77663_GPIO)	+= max77663_gpio.o
>   obj-$(CONFIG_SL28CPLD_GPIO)	+= sl28cpld-gpio.o
>   obj-$(CONFIG_ZYNQMP_GPIO_MODEPIN)	+= zynqmp_gpio_modepin.o
>   obj-$(CONFIG_SLG7XL45106_I2C_GPO)	+= gpio_slg7xl45106.o
> -obj-$(CONFIG_$(SPL_TPL_)TURRIS_OMNIA_MCU)	+= turris_omnia_mcu.o
>   obj-$(CONFIG_FTGPIO010)		+= ftgpio010.o
>   obj-$(CONFIG_ADP5585_GPIO)	+= adp5585_gpio.o
>   obj-$(CONFIG_RZG2L_GPIO)	+= rzg2l-gpio.o
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index f11ce72525..844a21be47 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -505,6 +505,16 @@ config TEST_DRV
>   	  model. This should only be enabled for testing as it is not useful for
>   	  anything else.
>   
> +config TURRIS_OMNIA_MCU
> +	bool "Enable Turris Omnia MCU driver"
> +	depends on DM_I2C
> +	depends on DM_GPIO
> +	depends on SYSRESET
> +	default y if TARGET_TURRIS_OMNIA
> +	help
> +	  This enables support for Turris Omnia MCU connected GPIOs and
> +	  board power off.
> +
>   config USB_HUB_USB251XB
>   	tristate "USB251XB Hub Controller Configuration Driver"
>   	depends on I2C
> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> index 0432db6ed1..3cd8e2fd48 100644
> --- a/drivers/misc/Makefile
> +++ b/drivers/misc/Makefile
> @@ -81,6 +81,7 @@ obj-$(CONFIG_SYS_DPAA_QBMAN) += fsl_portals.o
>   obj-$(CONFIG_TEGRA186_BPMP) += tegra186_bpmp.o
>   obj-$(CONFIG_TEGRA_CAR) += tegra_car.o
>   obj-$(CONFIG_TEST_DRV) += test_drv.o
> +obj-$(CONFIG_$(SPL_TPL_)TURRIS_OMNIA_MCU) += turris_omnia_mcu.o
>   obj-$(CONFIG_TWL4030_LED) += twl4030_led.o
>   obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress_config.o
>   obj-$(CONFIG_WINBOND_W83627) += winbond_w83627.o
> diff --git a/drivers/gpio/turris_omnia_mcu.c b/drivers/misc/turris_omnia_mcu.c
> similarity index 60%
> rename from drivers/gpio/turris_omnia_mcu.c
> rename to drivers/misc/turris_omnia_mcu.c
> index 40ced261e3..77a0424d61 100644
> --- a/drivers/gpio/turris_omnia_mcu.c
> +++ b/drivers/misc/turris_omnia_mcu.c
> @@ -1,9 +1,14 @@
>   // SPDX-License-Identifier: GPL-2.0+
> -// (C) 2022 Pali Rohár <pali@kernel.org>
> +/*
> + * Copyright (C) 2022 Pali Rohár <pali@kernel.org>
> + * Copyright (C) 2024 Marek Behún <kabel@kernel.org>
> + */
>   
>   #include <common.h>
>   #include <dm.h>
> +#include <dm/lists.h>
>   #include <i2c.h>
> +#include <sysreset.h>
>   #include <turris-omnia-mcu-interface.h>
>   #include <asm/byteorder.h>
>   #include <asm/gpio.h>
> @@ -13,9 +18,9 @@ struct turris_omnia_mcu_info {
>   	u32 features;
>   };
>   
> -static int turris_omnia_mcu_get_function(struct udevice *dev, uint offset)
> +static int omnia_gpio_get_function(struct udevice *dev, uint offset)
>   {
> -	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
> +	struct turris_omnia_mcu_info *info = dev_get_priv(dev->parent);
>   
>   	switch (offset) {
>   	/* bank 0 */
> @@ -49,9 +54,9 @@ static int turris_omnia_mcu_get_function(struct udevice *dev, uint offset)
>   	}
>   }
>   
> -static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
> +static int omnia_gpio_get_value(struct udevice *dev, uint offset)
>   {
> -	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
> +	struct turris_omnia_mcu_info *info = dev_get_priv(dev->parent);
>   	u32 val32;
>   	u16 val16;
>   	int ret;
> @@ -59,8 +64,8 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
>   	switch (offset) {
>   	/* bank 0 */
>   	case 0 ... 15:
> -		ret = dm_i2c_read(dev, CMD_GET_STATUS_WORD, (void *)&val16,
> -				  sizeof(val16));
> +		ret = dm_i2c_read(dev->parent, CMD_GET_STATUS_WORD,
> +				  (void *)&val16, sizeof(val16));
>   		if (ret)
>   			return ret;
>   
> @@ -71,8 +76,8 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
>   		if (!(info->features & FEAT_EXT_CMDS))
>   			return -EINVAL;
>   
> -		ret = dm_i2c_read(dev, CMD_GET_EXT_STATUS_DWORD, (void *)&val32,
> -				  sizeof(val32));
> +		ret = dm_i2c_read(dev->parent, CMD_GET_EXT_STATUS_DWORD,
> +				  (void *)&val32, sizeof(val32));
>   		if (ret)
>   			return ret;
>   
> @@ -85,7 +90,7 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
>   		if (!(info->features & FEAT_PERIPH_MCU))
>   			return -EINVAL;
>   
> -		ret = dm_i2c_read(dev, CMD_GET_EXT_CONTROL_STATUS,
> +		ret = dm_i2c_read(dev->parent, CMD_GET_EXT_CONTROL_STATUS,
>   				  (void *)&val16, sizeof(val16));
>   		if (ret)
>   			return ret;
> @@ -97,9 +102,9 @@ static int turris_omnia_mcu_get_value(struct udevice *dev, uint offset)
>   	}
>   }
>   
> -static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int value)
> +static int omnia_gpio_set_value(struct udevice *dev, uint offset, int value)
>   {
> -	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
> +	struct turris_omnia_mcu_info *info = dev_get_priv(dev->parent);
>   	u16 valmask16[2];
>   	u8 valmask8[2];
>   
> @@ -125,7 +130,7 @@ static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int valu
>   
>   		valmask8[0] = value ? valmask8[1] : 0;
>   
> -		return dm_i2c_write(dev, CMD_GENERAL_CONTROL, valmask8,
> +		return dm_i2c_write(dev->parent, CMD_GENERAL_CONTROL, valmask8,
>   				    sizeof(valmask8));
>   
>   	/* bank 2 - supported only when FEAT_EXT_CMDS and FEAT_PERIPH_MCU is set */
> @@ -138,19 +143,19 @@ static int turris_omnia_mcu_set_value(struct udevice *dev, uint offset, int valu
>   		valmask16[1] = cpu_to_le16(BIT(offset - 16 - 32));
>   		valmask16[0] = value ? valmask16[1] : 0;
>   
> -		return dm_i2c_write(dev, CMD_EXT_CONTROL, (void *)valmask16,
> -				    sizeof(valmask16));
> +		return dm_i2c_write(dev->parent, CMD_EXT_CONTROL,
> +				    (void *)valmask16, sizeof(valmask16));
>   
>   	default:
>   		return -EINVAL;
>   	}
>   }
>   
> -static int turris_omnia_mcu_direction_input(struct udevice *dev, uint offset)
> +static int omnia_gpio_direction_input(struct udevice *dev, uint offset)
>   {
>   	int ret;
>   
> -	ret = turris_omnia_mcu_get_function(dev, offset);
> +	ret = omnia_gpio_get_function(dev, offset);
>   	if (ret < 0)
>   		return ret;
>   	else if (ret != GPIOF_INPUT)
> @@ -159,20 +164,20 @@ static int turris_omnia_mcu_direction_input(struct udevice *dev, uint offset)
>   	return 0;
>   }
>   
> -static int turris_omnia_mcu_direction_output(struct udevice *dev, uint offset, int value)
> +static int omnia_gpio_direction_output(struct udevice *dev, uint offset, int value)
>   {
>   	int ret;
>   
> -	ret = turris_omnia_mcu_get_function(dev, offset);
> +	ret = omnia_gpio_get_function(dev, offset);
>   	if (ret < 0)
>   		return ret;
>   	else if (ret != GPIOF_OUTPUT)
>   		return -EOPNOTSUPP;
>   
> -	return turris_omnia_mcu_set_value(dev, offset, value);
> +	return omnia_gpio_set_value(dev, offset, value);
>   }
>   
> -static int turris_omnia_mcu_xlate(struct udevice *dev, struct gpio_desc *desc,
> +static int omnia_gpio_xlate(struct udevice *dev, struct gpio_desc *desc,
>   				  struct ofnode_phandle_args *args)
>   {
>   	uint bank, gpio, flags, offset;
> @@ -205,7 +210,7 @@ static int turris_omnia_mcu_xlate(struct udevice *dev, struct gpio_desc *desc,
>   		return -EINVAL;
>   	}
>   
> -	ret = turris_omnia_mcu_get_function(dev, offset);
> +	ret = omnia_gpio_get_function(dev, offset);
>   	if (ret < 0)
>   		return ret;
>   
> @@ -215,19 +220,79 @@ static int turris_omnia_mcu_xlate(struct udevice *dev, struct gpio_desc *desc,
>   	return 0;
>   }
>   
> -static const struct dm_gpio_ops turris_omnia_mcu_ops = {
> -	.direction_input	= turris_omnia_mcu_direction_input,
> -	.direction_output	= turris_omnia_mcu_direction_output,
> -	.get_value		= turris_omnia_mcu_get_value,
> -	.set_value		= turris_omnia_mcu_set_value,
> -	.get_function		= turris_omnia_mcu_get_function,
> -	.xlate			= turris_omnia_mcu_xlate,
> +static const struct dm_gpio_ops omnia_gpio_ops = {
> +	.direction_input	= omnia_gpio_direction_input,
> +	.direction_output	= omnia_gpio_direction_output,
> +	.get_value		= omnia_gpio_get_value,
> +	.set_value		= omnia_gpio_set_value,
> +	.get_function		= omnia_gpio_get_function,
> +	.xlate			= omnia_gpio_xlate,
>   };
>   
> -static int turris_omnia_mcu_probe(struct udevice *dev)
> +static int omnia_gpio_probe(struct udevice *dev)
>   {
> -	struct turris_omnia_mcu_info *info = dev_get_plat(dev);
> +	struct turris_omnia_mcu_info *info = dev_get_priv(dev->parent);
>   	struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
> +
> +	uc_priv->bank_name = "mcu_";
> +
> +	if ((info->features & FEAT_EXT_CMDS) && (info->features & FEAT_PERIPH_MCU))
> +		uc_priv->gpio_count = 16 + 32 + 16;
> +	else if (info->features & FEAT_EXT_CMDS)
> +		uc_priv->gpio_count = 16 + 32;
> +	else
> +		uc_priv->gpio_count = 16;
> +
> +	return 0;
> +}
> +
> +U_BOOT_DRIVER(turris_omnia_mcu_gpio) = {
> +	.name		= "turris-omnia-mcu-gpio",
> +	.id		= UCLASS_GPIO,
> +	.ops		= &omnia_gpio_ops,
> +	.probe		= omnia_gpio_probe,
> +};
> +
> +static int omnia_sysreset_request(struct udevice *dev, enum sysreset_t type)
> +{
> +	struct {
> +		u16 magic;
> +		u16 arg;
> +		u32 csum;
> +	} __packed args;
> +
> +	if (type != SYSRESET_POWER_OFF)
> +		return -EPROTONOSUPPORT;
> +
> +	args.magic = CMD_POWER_OFF_MAGIC;
> +	args.arg = CMD_POWER_OFF_POWERON_BUTTON;
> +	args.csum = 0xba3b7212;
> +
> +	return dm_i2c_write(dev->parent, CMD_POWER_OFF, (void *)&args,
> +			    sizeof(args));
> +}
> +
> +static const struct sysreset_ops omnia_sysreset_ops = {
> +	.request	= omnia_sysreset_request,
> +};
> +
> +U_BOOT_DRIVER(turris_omnia_mcu_sysreset) = {
> +	.name		= "turris-omnia-mcu-sysreset",
> +	.id		= UCLASS_SYSRESET,
> +	.ops		= &omnia_sysreset_ops,
> +};
> +
> +static int turris_omnia_mcu_bind(struct udevice *dev)
> +{
> +	/* bind MCU GPIOs as a child device */
> +	return device_bind_driver_to_node(dev, "turris-omnia-mcu-gpio",
> +					  "turris-omnia-mcu-gpio",
> +					  dev_ofnode(dev), NULL);
> +}
> +
> +static int turris_omnia_mcu_probe(struct udevice *dev)
> +{
> +	struct turris_omnia_mcu_info *info = dev_get_priv(dev);
>   	u32 dword;
>   	u16 word;
>   	int ret;
> @@ -261,14 +326,15 @@ static int turris_omnia_mcu_probe(struct udevice *dev)
>   		}
>   	}
>   
> -	uc_priv->bank_name = "mcu_";
> -
> -	if ((info->features & FEAT_EXT_CMDS) && (info->features & FEAT_PERIPH_MCU))
> -		uc_priv->gpio_count = 16 + 32 + 16;
> -	else if (info->features & FEAT_EXT_CMDS)
> -		uc_priv->gpio_count = 16 + 32;
> -	else
> -		uc_priv->gpio_count = 16;
> +	/* bind sysreset if poweroff is supported */
> +	if (info->features & FEAT_POWEROFF_WAKEUP) {
> +		ret = device_bind_driver_to_node(dev,
> +						 "turris-omnia-mcu-sysreset",
> +						 "turris-omnia-mcu-sysreset",
> +						 dev_ofnode(dev), NULL);
> +		if (ret < 0)
> +			return ret;
> +	}
>   
>   	return 0;
>   }
> @@ -280,9 +346,9 @@ static const struct udevice_id turris_omnia_mcu_ids[] = {
>   
>   U_BOOT_DRIVER(turris_omnia_mcu) = {
>   	.name		= "turris-omnia-mcu",
> -	.id		= UCLASS_GPIO,
> -	.ops		= &turris_omnia_mcu_ops,
> +	.id		= UCLASS_MISC,
> +	.bind		= turris_omnia_mcu_bind,
>   	.probe		= turris_omnia_mcu_probe,
> -	.plat_auto	= sizeof(struct turris_omnia_mcu_info),
> +	.priv_auto	= sizeof(struct turris_omnia_mcu_info),
>   	.of_match	= turris_omnia_mcu_ids,
>   };

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 15/18] arm: mvebu: turris_omnia: Enable poweroff command via sysreset in defconfig

[Marek Behún]

Enable support for the poweroff command via sysreset for Turris Omnia.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 configs/turris_omnia_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index 9d5171c6a8..0df0f3c90b 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -65,6 +65,7 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_MTD=y
 CONFIG_CMD_PCI=y
+CONFIG_CMD_POWEROFF=y
 CONFIG_CMD_SATA=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_USB=y
@@ -114,6 +115,7 @@ CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_KIRKWOOD_SPI=y
 CONFIG_SYSRESET=y
+CONFIG_SYSRESET_CMD_POWEROFF=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_EHCI_HCD=y
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 15/18] arm: mvebu: turris_omnia: Enable poweroff command via sysreset in defconfig

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Enable support for the poweroff command via sysreset for Turris Omnia.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   configs/turris_omnia_defconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index 9d5171c6a8..0df0f3c90b 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -65,6 +65,7 @@ CONFIG_CMD_I2C=y
>   CONFIG_CMD_MMC=y
>   CONFIG_CMD_MTD=y
>   CONFIG_CMD_PCI=y
> +CONFIG_CMD_POWEROFF=y
>   CONFIG_CMD_SATA=y
>   CONFIG_CMD_SPI=y
>   CONFIG_CMD_USB=y
> @@ -114,6 +115,7 @@ CONFIG_DEBUG_UART_SHIFT=2
>   CONFIG_SYS_NS16550=y
>   CONFIG_KIRKWOOD_SPI=y
>   CONFIG_SYSRESET=y
> +CONFIG_SYSRESET_CMD_POWEROFF=y
>   CONFIG_USB=y
>   CONFIG_USB_XHCI_HCD=y
>   CONFIG_USB_EHCI_HCD=y

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 16/18] cmd: rng: Print "Abort" on -EINTR

[Marek Behún]

In the rng command, print
  Abort
instead of
  Reading RNG failed
if the error number is -EINTR, which can happen if the user pressed
CTRL-C.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 cmd/rng.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/cmd/rng.c b/cmd/rng.c
index 52f722c7af..48ba67061b 100644
--- a/cmd/rng.c
+++ b/cmd/rng.c
@@ -17,7 +17,7 @@ static int do_rng(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 	u8 buf[64];
 	int devnum;
 	struct udevice *dev;
-	int ret = CMD_RET_SUCCESS;
+	int ret = CMD_RET_SUCCESS, err;
 
 	switch (argc) {
 	case 1:
@@ -46,8 +46,9 @@ static int do_rng(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 
 	n = min(n, sizeof(buf));
 
-	if (dm_rng_read(dev, buf, n)) {
-		printf("Reading RNG failed\n");
+	err = dm_rng_read(dev, buf, n);
+	if (err) {
+		puts(err == -EINTR ? "Abort\n" : "Reading RNG failed\n");
 		ret = CMD_RET_FAILURE;
 	} else {
 		print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, n);
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 16/18] cmd: rng: Print "Abort" on -EINTR

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> In the rng command, print
>    Abort
> instead of
>    Reading RNG failed
> if the error number is -EINTR, which can happen if the user pressed
> CTRL-C.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   cmd/rng.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/cmd/rng.c b/cmd/rng.c
> index 52f722c7af..48ba67061b 100644
> --- a/cmd/rng.c
> +++ b/cmd/rng.c
> @@ -17,7 +17,7 @@ static int do_rng(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
>   	u8 buf[64];
>   	int devnum;
>   	struct udevice *dev;
> -	int ret = CMD_RET_SUCCESS;
> +	int ret = CMD_RET_SUCCESS, err;
>   
>   	switch (argc) {
>   	case 1:
> @@ -46,8 +46,9 @@ static int do_rng(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
>   
>   	n = min(n, sizeof(buf));
>   
> -	if (dm_rng_read(dev, buf, n)) {
> -		printf("Reading RNG failed\n");
> +	err = dm_rng_read(dev, buf, n);
> +	if (err) {
> +		puts(err == -EINTR ? "Abort\n" : "Reading RNG failed\n");
>   		ret = CMD_RET_FAILURE;
>   	} else {
>   		print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, n);

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 17/18] misc: turris_omnia_mcu: Add support for rng provided by MCU

[Marek Behún]

Add support for true random number generator provided by the MCU on
Turris Omnia. The MCU firmware supports TRNG if the FEAT_TRNG bit is set
in features. In that case we bind the rng driver.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 configs/turris_omnia_defconfig  |  1 +
 drivers/misc/Kconfig            |  1 +
 drivers/misc/turris_omnia_mcu.c | 57 +++++++++++++++++++++++++++++++++
 3 files changed, 59 insertions(+)

diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index 0df0f3c90b..4c21635ec9 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -107,6 +107,7 @@ CONFIG_NVME_PCI=y
 CONFIG_PCI_MVEBU=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_ARMADA_38X=y
+CONFIG_DM_RNG=y
 CONFIG_DM_RTC=y
 CONFIG_RTC_ARMADA38X=y
 CONFIG_SERIAL_PROBE_ALL=y
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 844a21be47..a08f02196f 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -509,6 +509,7 @@ config TURRIS_OMNIA_MCU
 	bool "Enable Turris Omnia MCU driver"
 	depends on DM_I2C
 	depends on DM_GPIO
+	depends on DM_RNG
 	depends on SYSRESET
 	default y if TARGET_TURRIS_OMNIA
 	help
diff --git a/drivers/misc/turris_omnia_mcu.c b/drivers/misc/turris_omnia_mcu.c
index 77a0424d61..6b2f17c000 100644
--- a/drivers/misc/turris_omnia_mcu.c
+++ b/drivers/misc/turris_omnia_mcu.c
@@ -5,15 +5,20 @@
  */
 
 #include <common.h>
+#include <console.h>
 #include <dm.h>
 #include <dm/lists.h>
 #include <i2c.h>
+#include <rng.h>
 #include <sysreset.h>
 #include <turris-omnia-mcu-interface.h>
 #include <asm/byteorder.h>
 #include <asm/gpio.h>
+#include <linux/delay.h>
 #include <linux/log2.h>
 
+#define CMD_TRNG_MAX_ENTROPY_LEN	64
+
 struct turris_omnia_mcu_info {
 	u32 features;
 };
@@ -282,6 +287,49 @@ U_BOOT_DRIVER(turris_omnia_mcu_sysreset) = {
 	.ops		= &omnia_sysreset_ops,
 };
 
+static int omnia_rng_read(struct udevice *dev, void *data, size_t count)
+{
+	u8 buf[1 + CMD_TRNG_MAX_ENTROPY_LEN];
+	size_t len;
+	int ret;
+
+	while (count) {
+		ret = dm_i2c_read(dev->parent, CMD_TRNG_COLLECT_ENTROPY, buf,
+				  sizeof(buf));
+		if (ret)
+			return ret;
+
+		len = min_t(size_t, buf[0],
+			    min_t(size_t, CMD_TRNG_MAX_ENTROPY_LEN, count));
+
+		if (!len) {
+			/* wait 500ms (fail if interrupted), then try again */
+			for (int i = 0; i < 5; ++i) {
+				mdelay(100);
+				if (ctrlc())
+					return -EINTR;
+			}
+			continue;
+		}
+
+		memcpy(data, &buf[1], len);
+		data += len;
+		count -= len;
+	}
+
+	return 0;
+}
+
+static const struct dm_rng_ops omnia_rng_ops = {
+	.read		= omnia_rng_read,
+};
+
+U_BOOT_DRIVER(turris_omnia_mcu_trng) = {
+	.name		= "turris-omnia-mcu-trng",
+	.id		= UCLASS_RNG,
+	.ops		= &omnia_rng_ops,
+};
+
 static int turris_omnia_mcu_bind(struct udevice *dev)
 {
 	/* bind MCU GPIOs as a child device */
@@ -336,6 +384,15 @@ static int turris_omnia_mcu_probe(struct udevice *dev)
 			return ret;
 	}
 
+	/* bind rng if trng is supported */
+	if (info->features & FEAT_TRNG) {
+		ret = device_bind_driver_to_node(dev, "turris-omnia-mcu-trng",
+						 "turris-omnia-mcu-trng",
+						 dev_ofnode(dev), NULL);
+		if (ret < 0)
+			return ret;
+	}
+
 	return 0;
 }
 
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 17/18] misc: turris_omnia_mcu: Add support for rng provided by MCU

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Add support for true random number generator provided by the MCU on
> Turris Omnia. The MCU firmware supports TRNG if the FEAT_TRNG bit is set
> in features. In that case we bind the rng driver.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   configs/turris_omnia_defconfig  |  1 +
>   drivers/misc/Kconfig            |  1 +
>   drivers/misc/turris_omnia_mcu.c | 57 +++++++++++++++++++++++++++++++++
>   3 files changed, 59 insertions(+)
> 
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index 0df0f3c90b..4c21635ec9 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -107,6 +107,7 @@ CONFIG_NVME_PCI=y
>   CONFIG_PCI_MVEBU=y
>   CONFIG_PINCTRL=y
>   CONFIG_PINCTRL_ARMADA_38X=y
> +CONFIG_DM_RNG=y
>   CONFIG_DM_RTC=y
>   CONFIG_RTC_ARMADA38X=y
>   CONFIG_SERIAL_PROBE_ALL=y
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 844a21be47..a08f02196f 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -509,6 +509,7 @@ config TURRIS_OMNIA_MCU
>   	bool "Enable Turris Omnia MCU driver"
>   	depends on DM_I2C
>   	depends on DM_GPIO
> +	depends on DM_RNG
>   	depends on SYSRESET
>   	default y if TARGET_TURRIS_OMNIA
>   	help
> diff --git a/drivers/misc/turris_omnia_mcu.c b/drivers/misc/turris_omnia_mcu.c
> index 77a0424d61..6b2f17c000 100644
> --- a/drivers/misc/turris_omnia_mcu.c
> +++ b/drivers/misc/turris_omnia_mcu.c
> @@ -5,15 +5,20 @@
>    */
>   
>   #include <common.h>
> +#include <console.h>
>   #include <dm.h>
>   #include <dm/lists.h>
>   #include <i2c.h>
> +#include <rng.h>
>   #include <sysreset.h>
>   #include <turris-omnia-mcu-interface.h>
>   #include <asm/byteorder.h>
>   #include <asm/gpio.h>
> +#include <linux/delay.h>
>   #include <linux/log2.h>
>   
> +#define CMD_TRNG_MAX_ENTROPY_LEN	64
> +
>   struct turris_omnia_mcu_info {
>   	u32 features;
>   };
> @@ -282,6 +287,49 @@ U_BOOT_DRIVER(turris_omnia_mcu_sysreset) = {
>   	.ops		= &omnia_sysreset_ops,
>   };
>   
> +static int omnia_rng_read(struct udevice *dev, void *data, size_t count)
> +{
> +	u8 buf[1 + CMD_TRNG_MAX_ENTROPY_LEN];
> +	size_t len;
> +	int ret;
> +
> +	while (count) {
> +		ret = dm_i2c_read(dev->parent, CMD_TRNG_COLLECT_ENTROPY, buf,
> +				  sizeof(buf));
> +		if (ret)
> +			return ret;
> +
> +		len = min_t(size_t, buf[0],
> +			    min_t(size_t, CMD_TRNG_MAX_ENTROPY_LEN, count));
> +
> +		if (!len) {
> +			/* wait 500ms (fail if interrupted), then try again */
> +			for (int i = 0; i < 5; ++i) {
> +				mdelay(100);
> +				if (ctrlc())
> +					return -EINTR;
> +			}
> +			continue;
> +		}
> +
> +		memcpy(data, &buf[1], len);
> +		data += len;
> +		count -= len;
> +	}
> +
> +	return 0;
> +}
> +
> +static const struct dm_rng_ops omnia_rng_ops = {
> +	.read		= omnia_rng_read,
> +};
> +
> +U_BOOT_DRIVER(turris_omnia_mcu_trng) = {
> +	.name		= "turris-omnia-mcu-trng",
> +	.id		= UCLASS_RNG,
> +	.ops		= &omnia_rng_ops,
> +};
> +
>   static int turris_omnia_mcu_bind(struct udevice *dev)
>   {
>   	/* bind MCU GPIOs as a child device */
> @@ -336,6 +384,15 @@ static int turris_omnia_mcu_probe(struct udevice *dev)
>   			return ret;
>   	}
>   
> +	/* bind rng if trng is supported */
> +	if (info->features & FEAT_TRNG) {
> +		ret = device_bind_driver_to_node(dev, "turris-omnia-mcu-trng",
> +						 "turris-omnia-mcu-trng",
> +						 dev_ofnode(dev), NULL);
> +		if (ret < 0)
> +			return ret;
> +	}
> +
>   	return 0;
>   }
>   

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

[PATCH u-boot-mvebu v3 18/18] arm: mvebu: turris_omnia: Enable rng command in defconfig

[Marek Behún]

Now that Turris Omnia has a rng driver provided in the MCU driver,
enable the rng command in defconfig.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 configs/turris_omnia_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index 4c21635ec9..f2b39115fe 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -73,6 +73,7 @@ CONFIG_CMD_WDT=y
 CONFIG_CMD_TFTPPUT=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y
+CONFIG_CMD_RNG=y
 CONFIG_CMD_AES=y
 CONFIG_CMD_HASH=y
 CONFIG_CMD_BTRFS=y
-- 
2.43.2

Re: [PATCH u-boot-mvebu v3 18/18] arm: mvebu: turris_omnia: Enable rng command in defconfig

[Stefan Roese]

On 3/27/24 17:23, Marek Behún wrote:
> Now that Turris Omnia has a rng driver provided in the MCU driver,
> enable the rng command in defconfig.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   configs/turris_omnia_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index 4c21635ec9..f2b39115fe 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -73,6 +73,7 @@ CONFIG_CMD_WDT=y
>   CONFIG_CMD_TFTPPUT=y
>   CONFIG_CMD_CACHE=y
>   CONFIG_CMD_TIME=y
> +CONFIG_CMD_RNG=y
>   CONFIG_CMD_AES=y
>   CONFIG_CMD_HASH=y
>   CONFIG_CMD_BTRFS=y

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

Re: [PATCH u-boot-mvebu v3 00/18] Turris Omnia - New board revision support

[Stefan Roese]

Hi Marek,

On 3/27/24 17:23, Marek Behún wrote:
> Hi Stefan,
> 
> this is v3 of series adding support for new board revision of Turris
> Omnia.
> 
> Changes since v2:
> - patch 2: updated MCU command interface header
> - patch 6: fixed bug setting \0 as end of string in src array instead
>             of dst array after bin2hex() call
> - patch 16: updated commit message (added the bit about ctrl+c)
> 
> v1 and v2 at:
>    https://patchwork.ozlabs.org/project/uboot/cover/20240304152148.3847-1-kabel@kernel.org/
>    https://patchwork.ozlabs.org/project/uboot/cover/20240323180711.5498-1-kabel@kernel.org/

After pushing there changes in my current master I get these build
errors for "turris_omnia_defconfig":

make[1]: *** No rule to make target 
'board/CZ.NIC/turris_omnia/../turris_common.o', needed by 
'board/CZ.NIC/turris_omnia/built-in.o'.  Stop.
make[1]: *** Waiting for unfinished jobs....
board/CZ.NIC/turris_omnia/../turris_atsha_otp.c:14:10: fatal error: 
turris_common.h: No such file or directory
    14 | #include "turris_common.h"
       |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.build:257: 
board/CZ.NIC/turris_omnia/../turris_atsha_otp.o] Error 1
board/CZ.NIC/turris_omnia/turris_omnia.c:36:10: fatal error: 
../turris_common.h: No such file or directory
    36 | #include "../turris_common.h"
       |          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

Available here:

https://source.denx.de/u-boot/custodians/u-boot-marvell/-/commits/master?ref_type=heads

Could you please have a look?

Thanks,
Stefan

> Marek Behún (18):
>    arm: mvebu: turris_omnia: Enable LTO by default on Turris Omnia
>    arm: mvebu: turris_omnia: Add header containing MCU command interface
>      and use it
>    arm: mvebu: turris_{omnia, mox}: Don't print model two times
>    arm: mvebu: turris_omnia: Update MCU status and features reading
>    arm: mvebu: turris_omnia: Implement getting board information from MCU
>    arm: mvebu: turris_omnia: Print board ECDSA public key if available
>    arm: mvebu: turris_omnia: Disable Atmel SHA node if not present
>    arm: mvebu: spl: Do not build mvebu-reset in SPL
>    arm: mvebu: system-controller: Rework to use UCLASS_SYSCON
>    arm: mvebu: system-controller: Select mvebu-reset if DM_RESET &&
>      PCI_MVEBU
>    arm: mvebu: system-controller: Add support for SYSRESET
>    gpio: turris_omnia_mcu: Use byteorder conversion functions
>    gpio: turris_omnia_mcu: Update firmware features reading
>    gpio: turris_omnia_mcu: Add support for system power off via sysreset
>    arm: mvebu: turris_omnia: Enable poweroff command via sysreset in
>      defconfig
>    cmd: rng: Print "Abort" on -EINTR
>    misc: turris_omnia_mcu: Add support for rng provided by MCU
>    arm: mvebu: turris_omnia: Enable rng command in defconfig
> 
>   arch/arm/mach-mvebu/Kconfig              |  25 ++
>   arch/arm/mach-mvebu/Makefile             |   3 +-
>   arch/arm/mach-mvebu/cpu.c                |   2 +
>   arch/arm/mach-mvebu/system-controller.c  | 144 ++++++--
>   board/CZ.NIC/turris_atsha_otp.c          |  27 +-
>   board/CZ.NIC/turris_mox/turris_mox.c     |   5 +-
>   board/CZ.NIC/turris_omnia/Makefile       |   2 +-
>   board/CZ.NIC/turris_omnia/turris_omnia.c | 310 ++++++++++++-----
>   cmd/rng.c                                |   7 +-
>   configs/turris_omnia_defconfig           |   6 +
>   drivers/gpio/Kconfig                     |   7 -
>   drivers/gpio/Makefile                    |   1 -
>   drivers/gpio/turris_omnia_mcu.c          | 316 -----------------
>   drivers/misc/Kconfig                     |  11 +
>   drivers/misc/Makefile                    |   1 +
>   drivers/misc/turris_omnia_mcu.c          | 411 +++++++++++++++++++++++
>   include/turris-omnia-mcu-interface.h     | 248 ++++++++++++++
>   17 files changed, 1044 insertions(+), 482 deletions(-)
>   delete mode 100644 drivers/gpio/turris_omnia_mcu.c
>   create mode 100644 drivers/misc/turris_omnia_mcu.c
>   create mode 100644 include/turris-omnia-mcu-interface.h
> 

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

Re: [PATCH u-boot-mvebu v3 00/18] Turris Omnia - New board revision support

[Marek Behún]

On Thu, 4 Apr 2024 08:38:02 +0200
Stefan Roese <sr@denx.de> wrote:

> Hi Marek,
> 
> On 3/27/24 17:23, Marek Behún wrote:
> > Hi Stefan,
> > 
> > this is v3 of series adding support for new board revision of Turris
> > Omnia.
> > 
> > Changes since v2:
> > - patch 2: updated MCU command interface header
> > - patch 6: fixed bug setting \0 as end of string in src array instead
> >             of dst array after bin2hex() call
> > - patch 16: updated commit message (added the bit about ctrl+c)
> > 
> > v1 and v2 at:
> >    https://patchwork.ozlabs.org/project/uboot/cover/20240304152148.3847-1-kabel@kernel.org/
> >    https://patchwork.ozlabs.org/project/uboot/cover/20240323180711.5498-1-kabel@kernel.org/  
> 
> After pushing there changes in my current master I get these build
> errors for "turris_omnia_defconfig":
> 
> make[1]: *** No rule to make target 
> 'board/CZ.NIC/turris_omnia/../turris_common.o', needed by 
> 'board/CZ.NIC/turris_omnia/built-in.o'.  Stop.
> make[1]: *** Waiting for unfinished jobs....
> board/CZ.NIC/turris_omnia/../turris_atsha_otp.c:14:10: fatal error: 
> turris_common.h: No such file or directory
>     14 | #include "turris_common.h"
>        |          ^~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.build:257: 
> board/CZ.NIC/turris_omnia/../turris_atsha_otp.o] Error 1
> board/CZ.NIC/turris_omnia/turris_omnia.c:36:10: fatal error: 
> ../turris_common.h: No such file or directory
>     36 | #include "../turris_common.h"
>        |          ^~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> 
> Available here:
> 
> https://source.denx.de/u-boot/custodians/u-boot-marvell/-/commits/master?ref_type=heads
> 
> Could you please have a look?

I forgot to do a git add on the new files turris_common.c and
turris_common.h in patch 05/18. Will send v4.

Marek