Re: [PATCH u-boot-mvebu v3 08/18] arm: mvebu: spl: Do not build mvebu-reset in SPL

Stefan Roese
2024-03-28T09:58:09Z

On 3/27/24 17:23, Marek Behún wrote:
> Commit 35e29e89a386 ("arm: mvebu: Implement simple mvebu-reset driver
> for enabling/disabling PCIe ports") made it so that the mvebu reset
> driver for enabling/disabling PCIe ports is build if CONFIG_DM_RESET is
> enabled. This is because PCI_MVEBU depends on DM_RESET.
>
> But the driver should not be built for SPL. Indeed the PCI_MVEBU driver
> is not supported in SPL now, and so the mvebu-reset driver is not needed.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> arch/arm/mach-mvebu/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index 0584ed2be5..ef790d97fe 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -22,13 +22,14 @@ else # CONFIG_ARCH_KIRKWOOD
> obj-y = cpu.o
> obj-y += dram.o
> obj-y += lowlevel.o
> -obj-$(CONFIG_DM_RESET) += system-controller.o
> ifndef CONFIG_SPL_BUILD
> obj-$(CONFIG_ARMADA_375) += ../../../drivers/ddr/marvell/axp/xor.o
> obj-$(CONFIG_ARMADA_38X) += ../../../drivers/ddr/marvell/a38x/xor.o
> obj-$(CONFIG_ARMADA_XP) += ../../../drivers/ddr/marvell/axp/xor.o
> obj-$(CONFIG_ARMADA_MSYS) += ../../../drivers/ddr/marvell/axp/xor.o
>
> +obj-$(CONFIG_DM_RESET) += system-controller.o
> +
> ifdef CONFIG_ARMADA_38X
> obj-$(CONFIG_MVEBU_EFUSE) += efuse.o
> endif

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de