Re: [RFC PATCH v1 1/1] mmc: snps_sdhci: Add sdhci driver support for TH1520 SoC

Maxim Kiselev
2024-04-02T17:19:54Z

i, Heinrich!

вт, 2 апр. 2024 г. в 17:47, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com>:
>
> On 30.03.24 18:59, Maksim Kiselev wrote:
> > Add support for DesignWare SDHCI host controller on Alibaba TH1520 SoC
> >
> > Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>
>
> Thank you for driving the TH1520 support forward.
>
> Locally I updated the Lichee Pi4A device-tree based on the Linux
> device-tree and built th1520_lpi4a_defconfig with
>
> CONFIG_CMD_MMC=y
> CONFIG_MMC=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_SNPS=y

You can also enable following options:
CONFIG_MMC_IO_VOLTAGE=y
CONFIG_MMC_UHS_SUPPORT=y
CONFIG_MMC_HS400_ES_SUPPORT=y
CONFIG_MMC_HS400_SUPPORT=y

For HS400_ES mode also needs to add `mmc-hs400-enhanced-strobe`
line to the emmc node in the Lichee's DT.

HS200/HS400/HS400_ES modes work fine with eMMC on my Lichee Pi4A board.
MicroSD works fine at UHS SDR104 too.

Bus Speed for both devices is 198MHz

> I tested reading from eMMC and SD-card as well as writing to SD-card and
> found no problems.
>
> Tested-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Thanks for testing!