From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADDB9C6FD1F for ; Tue, 2 Apr 2024 20:09:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DCFD98817E; Tue, 2 Apr 2024 22:09:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="u1WyMfHn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A557788188; Tue, 2 Apr 2024 22:09:08 +0200 (CEST) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 971E28817C for ; Tue, 2 Apr 2024 22:09:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=laurent.pinchart@ideasonboard.com Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C40A1A2; Tue, 2 Apr 2024 22:08:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712088509; bh=yc0BwBoTCZ5tEddc955bJm4saggAfqFZ5HSLzJp3IVA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u1WyMfHnnS+waVwOihgzSVup5sICzBHaxeEj8Y1kIlKr2AtU6eS9PVz5EOl1x6qtR dNd7fmNDCtrn0pceWTamzXjArgu4bmkTNqX0tbIfrJ1mWMmdFTMeu6SRzbK6Zo+5ik w1E6U8utQr/rZrn47SBjuFgp+kl1cTOzgu55jEP0= Date: Tue, 2 Apr 2024 23:08:55 +0300 From: Laurent Pinchart To: Stefan Wahren Cc: "Ivan T. Ivanov" , Peter Robinson , Dave Stevenson , Naushir Patuck , Bartosz Golaszewski , Broadcom internal kernel review list , Conor Dooley , Florian Fainelli , Krzysztof Kozlowski , Linus Walleij , Nicolas Saenz Julienne , Ray Jui , Rob Herring , Scott Branden , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, u-boot@lists.denx.de Subject: Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes Message-ID: <20240402200855.GA32172@pendragon.ideasonboard.com> References: <20240326195807.15163-1-laurent.pinchart@ideasonboard.com> <20240327233700.GA21080@pendragon.ideasonboard.com> <2e15ab46-f29c-44ac-8a2a-8baa140ee1a3@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2e15ab46-f29c-44ac-8a2a-8baa140ee1a3@gmx.net> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hello, On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: > Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: > > On 2024-03-28 01:37, Laurent Pinchart wrote: > >> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: > >>> Hi, > >>> > >>> [add Peter and Ivan] > >>> > >>> Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > >>> > Hello, > >>> > > >>> > This small series includes a few drive-by fixes for DT validation > >>> > errors. > >>> > > >>> > The first patch has been posted previously in v1 ([1], and now addresses > >>> > a small review comment. I think it's good to go. > >>> > > >>> > The next two patches address the same issue as "[PATCH 1/2] dt-bindings: > >>> > arm: bcm: raspberrypi,bcm2835-firmware: Add missing properties" ([2]), > >>> > but this time with a (hopefully) correct approach. Patch 2/3 starts by > >>> > fixing the raspberrypi-bcm2835-firmware driver, removing the need for DT > >>> > properties that are specified in bcm2835-rpi.dtsi but not documented in > >>> > the corresponding bindings. Patch 3/3 can then drop those properties, > >>> > getting rid of the warnings. > >>> > >>> since this series drops properties from the device tree, does anyone > >>> have the chance to test it with a recent U-Boot? > >> > >> I don't have U-Boot running with my RPi, so I would appreciate if > >> someone could help :-) > > > > Sorry for taking me so long to verify this. > > > > I think on RPi U-Boot side we are fine. API used when accessing Mbox > > device do not follow DM model and do not use DMA, but just access > > device directly using this nice macros phys_to_bus/bus_to_phys. > > > > I build new DTB files with this patch included and U-Boot build > > from the latest sources. No obvious issues on RPi3 and RPi4. > > Devices boot fine. Thank you for testing Ivan. > Thanks you, Laurent and Ivan > > Reviewed-by: Stefan Wahren Stefan, I'm quite unfamiliar with the Raspberry Pi upstreaming process (despite having sent patches for ages :-)), do I understand correctly that this patch will go through your tree, or do I need to work with someone else to get it merged upstream ? -- Regards, Laurent Pinchart