Re: [PATCH u-boot-mvebu v3 00/18] Turris Omnia - New board revision support

Stefan Roese
2024-04-04T06:38:09Z

Hi Marek,

On 3/27/24 17:23, Marek Behún wrote:
> Hi Stefan,
>
> this is v3 of series adding support for new board revision of Turris
> Omnia.
>
> Changes since v2:
> - patch 2: updated MCU command interface header
> - patch 6: fixed bug setting \0 as end of string in src array instead
> of dst array after bin2hex() call
> - patch 16: updated commit message (added the bit about ctrl+c)
>
> v1 and v2 at:
> https://patchwork.ozlabs.org/project/uboot/cover/20240304152148.3847-1-kabel@kernel.org/
> https://patchwork.ozlabs.org/project/uboot/cover/20240323180711.5498-1-kabel@kernel.org/

After pushing there changes in my current master I get these build
errors for "turris_omnia_defconfig":

make[1]: *** No rule to make target
'board/CZ.NIC/turris_omnia/../turris_common.o', needed by
'board/CZ.NIC/turris_omnia/built-in.o'. Stop.
make[1]: *** Waiting for unfinished jobs....
board/CZ.NIC/turris_omnia/../turris_atsha_otp.c:14:10: fatal error:
turris_common.h: No such file or directory
14 | #include "turris_common.h"
| ^~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.build:257:
board/CZ.NIC/turris_omnia/../turris_atsha_otp.o] Error 1
board/CZ.NIC/turris_omnia/turris_omnia.c:36:10: fatal error:
../turris_common.h: No such file or directory
36 | #include "../turris_common.h"
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

Available here:

https://source.denx.de/u-boot/custodians/u-boot-marvell/-/commits/master?ref_type=heads

Could you please have a look?

Thanks,
Stefan

> Marek Behún (18):
> arm: mvebu: turris_omnia: Enable LTO by default on Turris Omnia
> arm: mvebu: turris_omnia: Add header containing MCU command interface
> and use it
> arm: mvebu: turris_{omnia, mox}: Don't print model two times
> arm: mvebu: turris_omnia: Update MCU status and features reading
> arm: mvebu: turris_omnia: Implement getting board information from MCU
> arm: mvebu: turris_omnia: Print board ECDSA public key if available
> arm: mvebu: turris_omnia: Disable Atmel SHA node if not present
> arm: mvebu: spl: Do not build mvebu-reset in SPL
> arm: mvebu: system-controller: Rework to use UCLASS_SYSCON
> arm: mvebu: system-controller: Select mvebu-reset if DM_RESET &&
> PCI_MVEBU
> arm: mvebu: system-controller: Add support for SYSRESET
> gpio: turris_omnia_mcu: Use byteorder conversion functions
> gpio: turris_omnia_mcu: Update firmware features reading
> gpio: turris_omnia_mcu: Add support for system power off via sysreset
> arm: mvebu: turris_omnia: Enable poweroff command via sysreset in
> defconfig
> cmd: rng: Print "Abort" on -EINTR
> misc: turris_omnia_mcu: Add support for rng provided by MCU
> arm: mvebu: turris_omnia: Enable rng command in defconfig
>
> arch/arm/mach-mvebu/Kconfig | 25 ++
> arch/arm/mach-mvebu/Makefile | 3 +-
> arch/arm/mach-mvebu/cpu.c | 2 +
> arch/arm/mach-mvebu/system-controller.c | 144 ++++++--
> board/CZ.NIC/turris_atsha_otp.c | 27 +-
> board/CZ.NIC/turris_mox/turris_mox.c | 5 +-
> board/CZ.NIC/turris_omnia/Makefile | 2 +-
> board/CZ.NIC/turris_omnia/turris_omnia.c | 310 ++++++++++++-----
> cmd/rng.c | 7 +-
> configs/turris_omnia_defconfig | 6 +
> drivers/gpio/Kconfig | 7 -
> drivers/gpio/Makefile | 1 -
> drivers/gpio/turris_omnia_mcu.c | 316 -----------------
> drivers/misc/Kconfig | 11 +
> drivers/misc/Makefile | 1 +
> drivers/misc/turris_omnia_mcu.c | 411 +++++++++++++++++++++++
> include/turris-omnia-mcu-interface.h | 248 ++++++++++++++
> 17 files changed, 1044 insertions(+), 482 deletions(-)
> delete mode 100644 drivers/gpio/turris_omnia_mcu.c
> create mode 100644 drivers/misc/turris_omnia_mcu.c
> create mode 100644 include/turris-omnia-mcu-interface.h
>

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de