From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc: u-boot@lists.denx.de, Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Marek Vasut <marex@denx.de>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Nishanth Menon <nm@ti.com>, Sjoerd Simons <sjoerd@collabora.com>
Subject: Re: [PATCH 6/6] usb: dwc3: gadget: Disable GUSB2PHYCFG.SUSPHY for End Transfer
Date: Sat, 13 Apr 2024 08:02:05 +0200 [thread overview]
Message-ID: <2024041354-exciting-suggest-b896@gregkh> (raw)
In-Reply-To: <20240412202611.3565052-7-alexander.sverdlin@siemens.com>
On Fri, Apr 12, 2024 at 10:26:06PM +0200, A. Sverdlin wrote:
> From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
>
> Upstream Linux commit 3aa07f72894d.
>
> If there's a disconnection while operating in eSS, there may be a delay
> in VBUS drop response from the connector. In that case, the internal
> link state may drop to operate in usb2 speed while the controller thinks
> the VBUS is still high. The driver must make sure to disable
> GUSB2PHYCFG.SUSPHY when sending endpoint command while in usb2 speed.
> The End Transfer command may be called, and only that command needs to
> go through at this point. Let's keep it simple and unconditionally
> disable GUSB2PHYCFG.SUSPHY whenever we issue the command.
>
> This scenario is not seen in real hardware. In a rare case, our
> prototype type-c controller/interface may have a slow response
> triggerring this issue.
>
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> Link: https://lore.kernel.org/r/5651117207803c26e2f22ddf4e5ce9e865dcf7c7.1668045468.git.Thinh.Nguyen@synopsys.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Confused, why did you resend this to us?
next prev parent reply other threads:[~2024-04-13 6:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 20:26 [PATCH 0/6] usb: dwc3: gadget: avoid EP command timeout A. Sverdlin
2024-04-12 20:26 ` [PATCH 1/6] usb: dwc3: gadget: combine return points into a single one A. Sverdlin
2024-05-14 12:48 ` Mattijs Korpershoek
2024-04-12 20:26 ` [PATCH 2/6] usb: dwc3: gadget: clear SUSPHY bit before ep cmds A. Sverdlin
2024-05-14 12:52 ` Mattijs Korpershoek
2024-04-12 20:26 ` [PATCH 3/6] usb: dwc3: gadget: only resume USB2 PHY in <=HIGHSPEED A. Sverdlin
2024-05-14 12:55 ` Mattijs Korpershoek
2024-04-12 20:26 ` [PATCH 4/6] usb: dwc3: gadget: Check ENBLSLPM before sending ep command A. Sverdlin
2024-05-14 12:57 ` Mattijs Korpershoek
2024-04-12 20:26 ` [PATCH 5/6] usb: dwc3: gadget: properly check ep cmd A. Sverdlin
2024-05-14 13:00 ` Mattijs Korpershoek
2024-04-12 20:26 ` [PATCH 6/6] usb: dwc3: gadget: Disable GUSB2PHYCFG.SUSPHY for End Transfer A. Sverdlin
2024-04-13 6:02 ` Greg Kroah-Hartman [this message]
2024-05-14 13:05 ` Mattijs Korpershoek
2024-05-16 6:40 ` [PATCH 0/6] usb: dwc3: gadget: avoid EP command timeout Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024041354-exciting-suggest-b896@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=alexander.sverdlin@siemens.com \
--cc=felipe.balbi@linux.intel.com \
--cc=marex@denx.de \
--cc=nm@ti.com \
--cc=sjoerd@collabora.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox