public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Michal Simek <michal.simek@amd.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Andre Przywara <andre.przywara@arm.com>,
	Angelo Dureghello <angelo@kernel-space.org>,
	Elon Zhang <zhangzj@rock-chips.com>,
	Eugen Hristev <eugen.hristev@collabora.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	John Clark <inindev@gmail.com>, Jonas Karlman <jonas@kwiboo.se>,
	Joshua Riek <jjriek@verizon.net>,
	Kever Yang <kever.yang@rock-chips.com>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	Simon Glass <sjg@chromium.org>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	Tim Lunn <tim@feathertop.org>,
	Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>,
	Vignesh R <vigneshr@ti.com>,
	u-boot@lists.denx.de, git@xilinx.com
Subject: Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii
Date: Tue, 16 Apr 2024 02:36:19 +0200	[thread overview]
Message-ID: <20240416003619.GK1054907@bill-the-cat> (raw)
In-Reply-To: <3df9f51d-d37b-41da-94a1-f05936ebd0d6@amd.com>

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

On Mon, Apr 15, 2024 at 02:49:13PM +0200, Michal Simek wrote:
> 
> 
> On 4/15/24 14:22, Heinrich Schuchardt wrote:
> > On 15.04.24 13:35, Michal Simek wrote:
> > > Some of Kconfigs are using utf-8 encoding because of used chars. Convert
> > > all of them to ascii enconging.
> > > 
> > > Signed-off-by: Michal Simek <michal.simek@amd.com>
> > > ---
> > > 
> > > There are other files which are using utf-8 enconding and pretty much I
> > > think we should convert all of them because there is no reason to use utf-8
> > > encoding.
> > 
> > Hello Michal,
> > 
> > The commit message does not explain why we should refrain from using UTF-8.
> 
> that's a good point. I was thinking about the reason for it and pretty much
> wanted to get feedback from Tom about it.
> 
> In doc/develop/sending_patches.rst is said that patches should be sent as
> plain text but encoding is not specified. Traditionally this was ASCII and I
> pretty much don't see the reason to use UTF encoding (even my name has
> special czech char which I am not using, the same is for Marek Vasut).

My point of view is that I think ASCII should be used in general, with
the exception being names (I won't force people to ASCII-ize their
names, modern systems handle UTF-8 just fine). I actually don't know if
we should also exclude rST doc files from this rule as well as UTF-8
should render fine and for example "°C" reads nicely in web/PDF/etc.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2024-04-16  0:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 11:35 [PATCH 0/4] Kconfig: some cleanups Michal Simek
2024-04-15 11:35 ` [PATCH 1/4] Kconfig: Remove trailing whitespace in its prompt Michal Simek
2024-04-15 11:35 ` [PATCH 2/4] Kconfig: Add missing quotes around source file Michal Simek
2024-04-15 12:44   ` Heinrich Schuchardt
2024-04-15 12:45     ` Michal Simek
2024-04-15 11:35 ` [PATCH 3/4] Kconfig: Add missing quotes around default string value Michal Simek
2024-04-15 12:41   ` Heinrich Schuchardt
2024-04-15 11:35 ` [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii Michal Simek
2024-04-15 12:22   ` Heinrich Schuchardt
2024-04-15 12:49     ` Michal Simek
2024-04-16  0:36       ` Tom Rini [this message]
2024-04-16  6:32         ` Michal Simek
2024-04-16  0:36     ` Tom Rini
2024-04-16  6:59       ` Francesco Dolcini
2024-04-16 10:09         ` Michal Simek
2024-04-16 13:18         ` Dragan Simic
2024-04-16 14:51           ` Francesco Dolcini
2024-04-16 16:53             ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240416003619.GK1054907@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=andre.przywara@arm.com \
    --cc=angelo@kernel-space.org \
    --cc=clamor95@gmail.com \
    --cc=eugen.hristev@collabora.com \
    --cc=git@xilinx.com \
    --cc=inindev@gmail.com \
    --cc=jagan@amarulasolutions.com \
    --cc=jjriek@verizon.net \
    --cc=jonas@kwiboo.se \
    --cc=kever.yang@rock-chips.com \
    --cc=michal.simek@amd.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=sjg@chromium.org \
    --cc=tim@feathertop.org \
    --cc=u-boot@lists.denx.de \
    --cc=venkatesh.abbarapu@amd.com \
    --cc=vigneshr@ti.com \
    --cc=xypron.glpk@gmx.de \
    --cc=zhangzj@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox