public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: 路辉 <luhux76@gmail.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] drivers: pinctrl-sunxi: add suniv spi1 function
Date: Thu, 18 Apr 2024 23:42:53 +0100	[thread overview]
Message-ID: <20240418234253.3cf07c9a@minigeek.lan> (raw)
In-Reply-To: <CAGNyvehMbDenbnZdSbV9m5LkEkqE_dix0+XZQwJU_qDAcfJZXw@mail.gmail.com>

On Fri, 9 Jun 2023 13:37:16 +0000
路辉 <luhux76@gmail.com> wrote:

Hi,

> From 570b40e19de75511d9ce066e1a28333ada04baf2 Mon Sep 17 00:00:00 2001
> From: Lu Hui <luhux76@gmail.com>
> Date: Mon, 29 May 2023 22:26:25 +0800
> Subject: [PATCH] drivers: pinctrl-sunxi: add suniv spi1 function

There should be a commit message, explaining *why* this is needed.
So which device on which board do you use in U-Boot that requires SPI1?

Also you need a "Signed-off-by:" line with your real name and email
address.

Cheers,
Andre

> ---
>  drivers/pinctrl/sunxi/pinctrl-sunxi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> index e510218090..c448e40ab0 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> @@ -240,6 +240,7 @@ static const struct sunxi_pinctrl_function
> suniv_f1c100s_pinctrl_functions[] = {
>      { "mmc0",    2 },    /* PF0-PF5 */
>      { "mmc1",    3 },    /* PC0-PC2 */
>      { "spi0",    2 },    /* PC0-PC3 */
> +    { "spi1",    6 },    /* PA0-PA3 */
>  #if IS_ENABLED(CONFIG_UART0_PORT_F)
>      { "uart0",    3 },    /* PF2-PF4 */
>  #else


      reply	other threads:[~2024-04-18 22:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 13:37 [PATCH] drivers: pinctrl-sunxi: add suniv spi1 function 路辉
2024-04-18 22:42 ` Andre Przywara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418234253.3cf07c9a@minigeek.lan \
    --to=andre.przywara@arm.com \
    --cc=luhux76@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox