public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] drivers: pinctrl-sunxi: add suniv spi1 function
@ 2023-06-09 13:37 路辉
  2024-04-18 22:42 ` Andre Przywara
  0 siblings, 1 reply; 2+ messages in thread
From: 路辉 @ 2023-06-09 13:37 UTC (permalink / raw)
  To: u-boot

From 570b40e19de75511d9ce066e1a28333ada04baf2 Mon Sep 17 00:00:00 2001
From: Lu Hui <luhux76@gmail.com>
Date: Mon, 29 May 2023 22:26:25 +0800
Subject: [PATCH] drivers: pinctrl-sunxi: add suniv spi1 function

---
 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index e510218090..c448e40ab0 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -240,6 +240,7 @@ static const struct sunxi_pinctrl_function
suniv_f1c100s_pinctrl_functions[] = {
     { "mmc0",    2 },    /* PF0-PF5 */
     { "mmc1",    3 },    /* PC0-PC2 */
     { "spi0",    2 },    /* PC0-PC3 */
+    { "spi1",    6 },    /* PA0-PA3 */
 #if IS_ENABLED(CONFIG_UART0_PORT_F)
     { "uart0",    3 },    /* PF2-PF4 */
 #else
-- 
2.40.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: pinctrl-sunxi: add suniv spi1 function
  2023-06-09 13:37 [PATCH] drivers: pinctrl-sunxi: add suniv spi1 function 路辉
@ 2024-04-18 22:42 ` Andre Przywara
  0 siblings, 0 replies; 2+ messages in thread
From: Andre Przywara @ 2024-04-18 22:42 UTC (permalink / raw)
  To: 路辉; +Cc: u-boot

On Fri, 9 Jun 2023 13:37:16 +0000
路辉 <luhux76@gmail.com> wrote:

Hi,

> From 570b40e19de75511d9ce066e1a28333ada04baf2 Mon Sep 17 00:00:00 2001
> From: Lu Hui <luhux76@gmail.com>
> Date: Mon, 29 May 2023 22:26:25 +0800
> Subject: [PATCH] drivers: pinctrl-sunxi: add suniv spi1 function

There should be a commit message, explaining *why* this is needed.
So which device on which board do you use in U-Boot that requires SPI1?

Also you need a "Signed-off-by:" line with your real name and email
address.

Cheers,
Andre

> ---
>  drivers/pinctrl/sunxi/pinctrl-sunxi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> index e510218090..c448e40ab0 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> @@ -240,6 +240,7 @@ static const struct sunxi_pinctrl_function
> suniv_f1c100s_pinctrl_functions[] = {
>      { "mmc0",    2 },    /* PF0-PF5 */
>      { "mmc1",    3 },    /* PC0-PC2 */
>      { "spi0",    2 },    /* PC0-PC3 */
> +    { "spi1",    6 },    /* PA0-PA3 */
>  #if IS_ENABLED(CONFIG_UART0_PORT_F)
>      { "uart0",    3 },    /* PF2-PF4 */
>  #else


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-18 22:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-09 13:37 [PATCH] drivers: pinctrl-sunxi: add suniv spi1 function 路辉
2024-04-18 22:42 ` Andre Przywara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox