From: "Marek Behún" <kabel@kernel.org>
To: lukas.funke-oss@weidmueller.com
Cc: u-boot@lists.denx.de, Michal Simek <michal.simek@amd.com>,
Lukas Funke <lukas.funke@weidmueller.com>,
Algapally Santosh Sagar <santoshsagar.algapally@amd.com>,
Ashok Reddy Soma <ashok.reddy.soma@amd.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Christian Taedcke <christian.taedcke@weidmueller.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jonas Karlman <jonas@kwiboo.se>,
Kever Yang <kever.yang@rock-chips.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Peng Fan <peng.fan@nxp.com>, Qu Wenruo <wqu@suse.com>,
Simon Glass <sjg@chromium.org>,
Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,
Stefan Roese <sr@denx.de>, Tanmay Shah <tanmay.shah@amd.com>,
Tom Rini <trini@konsulko.com>,
Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>,
Wan Yee Lau <wan.yee.lau@intel.com>
Subject: Re: [PATCH 0/3] Add eFuse access for ZynqMP
Date: Wed, 15 May 2024 09:08:38 +0200 [thread overview]
Message-ID: <20240515090838.6cfc424d@dellmb> (raw)
In-Reply-To: <20240514140416.156747-1-lukas.funke-oss@weidmueller.com>
On Tue, 14 May 2024 16:04:13 +0200
lukas.funke-oss@weidmueller.com wrote:
> From: Lukas Funke <lukas.funke@weidmueller.com>
>
>
> This series adds a driver to read and write ZynqMP eFuses [1]. The
> driver can be accessed by the 'efuse_read' and 'efuse_write' subcommands
> of the 'zynqmp' command.
Vendor specific commands aren't great.
There is the 'fuse' command in u-boot. You need to implement the
fuse_read()
fuse_sense()
fuse_prog()
fuse_override()
functions.
See for example arch/arm/mach-mvebu/efuse.c, or other implementations.
Please don't invent new vendor specific commands in new code, it is an
antipattern.
Marek
prev parent reply other threads:[~2024-05-15 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 14:04 [PATCH 0/3] Add eFuse access for ZynqMP lukas.funke-oss
2024-05-14 14:04 ` [PATCH 1/3] firmware: zynqmp: Add support to access efuses lukas.funke-oss
2024-05-15 6:04 ` Stefan Roese
2024-05-14 14:04 ` [PATCH 2/3] amd64: zynqmp: Add command to program efuses lukas.funke-oss
2024-05-14 14:04 ` [PATCH 3/3] drivers: misc: Add driver to access ZynqMP efuses lukas.funke-oss
2024-05-15 6:12 ` Stefan Roese
2024-05-15 6:33 ` Lukas Funke
2024-05-15 9:19 ` Stefan Roese
2024-05-15 7:08 ` Marek Behún [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515090838.6cfc424d@dellmb \
--to=kabel@kernel.org \
--cc=ashok.reddy.soma@amd.com \
--cc=caleb.connolly@linaro.org \
--cc=christian.taedcke@weidmueller.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=lukas.funke-oss@weidmueller.com \
--cc=lukas.funke@weidmueller.com \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=peng.fan@nxp.com \
--cc=santoshsagar.algapally@amd.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=stefan.herbrechtsmeier@weidmueller.com \
--cc=tanmay.shah@amd.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
--cc=wan.yee.lau@intel.com \
--cc=wqu@suse.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox