U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tim Harvey <tharvey@gateworks.com>
Cc: u-boot@lists.denx.de,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Jorge Ramirez-Ortiz <jorge@foundries.io>,
	Adam Ford <aford173@gmail.com>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH v5 2/2] tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend
Date: Mon, 27 May 2024 10:59:10 +0200	[thread overview]
Message-ID: <20240527105910.3bb425d1@xps-13> (raw)
In-Reply-To: <20240525200049.3904124-2-tharvey@gateworks.com>

Hi Tim,

tharvey@gateworks.com wrote on Sat, 25 May 2024 13:00:49 -0700:

> For pcr_read and pcr_extend commands allow the digest algorithm to be
> specified by an additional argument. If not specified it will default to
> SHA256 for backwards compatibility.
> 
> Additionally update test_tpm2.py for the changes in output in pcr_read
> which now shows the algo and algo length in the output.
> 
> A follow-on to this could be to extend all PCR banks with the detected
> algo when the <digest_algo> argument is 'auto'.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

LGTM,

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

  reply	other threads:[~2024-05-27  8:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-25 20:00 [PATCH v5 1/2] tpm-v2: add support for mapping algorithm names to algos Tim Harvey
2024-05-25 20:00 ` [PATCH v5 2/2] tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend Tim Harvey
2024-05-27  8:59   ` Miquel Raynal [this message]
2024-05-27  9:44     ` Ilias Apalodimas
2024-05-27 11:48       ` Miquel Raynal
2024-05-27 12:02         ` Ilias Apalodimas
2024-05-27  8:58 ` [PATCH v5 1/2] tpm-v2: add support for mapping algorithm names to algos Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240527105910.3bb425d1@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=aford173@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jorge@foundries.io \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox