Re: [PATCH 2/2] net: phy: Replace PHY_ANEG_TIMEOUT with Kconfig symbol

[Francesco Dolcini <francesco@dolcini.it>]

Hello Marek,

On Fri, May 31, 2024 at 06:47:17PM +0200, Marek Vasut wrote:
> Switch PHY_ANEG_TIMEOUT to CONFIG_PHY_ANEG_TIMEOUT Kconfig symbol.
> This removes one more configuration headers option finalizes its
> Kconfig symbol conversion. No functional change expected.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
...

> diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
> index 0df3917e200..6fd43511ee4 100644
> --- a/include/configs/apalis_imx6.h
> +++ b/include/configs/apalis_imx6.h
> @@ -22,7 +22,6 @@
>  #define CFG_SYS_FSL_USDHC_NUM	3
>  
>  /* Network */
> -#define PHY_ANEG_TIMEOUT		15000 /* PHY needs longer aneg time */

You should remove also the line before, after removing the define it's
just a stale comment.

> diff --git a/include/configs/ds414.h b/include/configs/ds414.h
> index 9446acba792..f1921dac5e7 100644
> --- a/include/configs/ds414.h
> +++ b/include/configs/ds414.h
> @@ -55,6 +55,5 @@
>  
>  
>  /* increase autoneg timeout, my NIC sucks */
> -#define PHY_ANEG_TIMEOUT	16000

same here.

> diff --git a/include/configs/hmibsc.h b/include/configs/hmibsc.h
> index 27404c80fdf..950ec8b190d 100644
> --- a/include/configs/hmibsc.h
> +++ b/include/configs/hmibsc.h
> @@ -9,7 +9,6 @@
>  #define __CONFIGS_HMIBSC_H
>  
>  /* PHY needs a longer aneg time */
> -#define PHY_ANEG_TIMEOUT		8000

and here, and also in some of the following files.

Francesco