From: Tom Rini <trini@konsulko.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: hs@denx.de, pro@denx.de, vasileios.amoiridis@cern.ch,
u-boot@lists.denx.de
Subject: Re: [RFC PATCH 0/1] drivers: bootcount: Add support for FAT filesystem
Date: Wed, 5 Jun 2024 12:48:32 -0600 [thread overview]
Message-ID: <20240605184832.GV68077@bill-the-cat> (raw)
In-Reply-To: <20240605181041.68317-1-vassilisamir@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Wed, Jun 05, 2024 at 08:10:40PM +0200, Vasileios Amoiridis wrote:
> From: Vasileios Amoiridis <vasileios.amoiridis@cern.ch>
>
> This patch adds support to save the bootcount variable in a file located in
> FAT filesystem. Up to now, there was support only for EXT filesystem.
>
> The reason I put this as RFC is because the file "bootcount_ext.c" will no
> longer represent the implementation for the EXT filesystem, but also for the
> FAT filesystem. Should it be renamed? If not, wouldn't it be inconsistent?
Yeah, lets call it bootcount_fs.c ? It otherwise all looks good to me,
thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2024-06-05 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 18:10 [RFC PATCH 0/1] drivers: bootcount: Add support for FAT filesystem Vasileios Amoiridis
2024-06-05 18:10 ` [RFC PATCH] " Vasileios Amoiridis
2024-06-06 7:58 ` Philip Oberfichtner
2024-06-06 17:11 ` Vasileios Amoiridis
2024-06-06 15:34 ` Quentin Schulz
2024-06-06 17:33 ` Vasileios Amoiridis
2024-06-05 18:48 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605184832.GV68077@bill-the-cat \
--to=trini@konsulko.com \
--cc=hs@denx.de \
--cc=pro@denx.de \
--cc=u-boot@lists.denx.de \
--cc=vasileios.amoiridis@cern.ch \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox