From: Anatolij Gustschin <agust@denx.de>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] board: beagle: convert to CONFIG_DM_I2C
Date: Sat, 20 Jul 2024 15:09:34 +0200 [thread overview]
Message-ID: <20240720150934.40349259@crub> (raw)
In-Reply-To: <CAFLszTjjgvFePwsMO-u-bKRjaCREXy1PCpOCmfH=Atvm2ThAqg@mail.gmail.com>
Hi Simon,
On Sat, 20 Jul 2024 13:36:04 +0100
Simon Glass sjg@chromium.org wrote:
...
> > - /* return BEAGLE_NO_EEPROM if eeprom doesn't respond */
> > - if (i2c_probe(EXPANSION_EEPROM_I2C_ADDRESS) == 1) {
> > - i2c_set_bus_num(TWL4030_I2C_BUS);
> > + ret = i2c_get_chip_for_busnum(EXPANSION_EEPROM_I2C_BUS,
> > + EXPANSION_EEPROM_I2C_ADDRESS, 1, &eeprom);
> > + if (ret)
> > return BEAGLE_NO_EEPROM;
>
> Isn't this in the devicetree? It should be possible to use
> i2c_eeprom_read(). See for example sysinfo_rcar_probe().
No, it isn't in the devicetree. This EEPROM is on an optional
expansion board.
Thanks,
Anatolij
next prev parent reply other threads:[~2024-07-20 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 21:51 [PATCH] board: beagle: convert to CONFIG_DM_I2C Anatolij Gustschin
2024-07-20 12:36 ` Simon Glass
2024-07-20 13:09 ` Anatolij Gustschin [this message]
2024-07-20 18:08 ` Robert Nelson
2024-07-20 17:11 ` Tom Rini
2024-07-23 21:04 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240720150934.40349259@crub \
--to=agust@denx.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox