From: Tom Rini <trini@konsulko.com>
To: Jerome Forissier <jerome.forissier@linaro.org>
Cc: u-boot@lists.denx.de,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Javier Tia <javier.tia@linaro.org>,
Raymond Mao <raymond.mao@linaro.org>,
Maxim Uvarov <muvarov@gmail.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Michal Simek <michal.simek@amd.com>,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH v5 06/20] net: eth-uclass: add function eth_start_udev()
Date: Thu, 25 Jul 2024 12:27:32 -0600 [thread overview]
Message-ID: <20240725182732.GC989285@bill-the-cat> (raw)
In-Reply-To: <c012639090f4a45f004768b8e7840e3e81867ca1.1721910373.git.jerome.forissier@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
On Thu, Jul 25, 2024 at 02:57:27PM +0200, Jerome Forissier wrote:
> Add a function to start a given etwork device, and update eth_init()
Typo, "network".
> to use it.
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
And this is where most of the tiny and acceptable growth comes from in
the legacy network case.
Reviewed-by: Tom Rini <trini@konsulko.com>
But, does the lwIP side end up calling this too then, and so the need to
split this out and not have it be static?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-07-25 18:27 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 12:57 [PATCH v5 00/20] Introduce the lwIP network stack Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 01/20] flash: prefix error codes with FL_ Jerome Forissier
2024-07-25 18:18 ` Tom Rini
2024-07-26 8:51 ` Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 02/20] net: introduce alternative implementation as net-lwip/ Jerome Forissier
2024-07-25 13:46 ` Maxim Uvarov
2024-07-25 16:17 ` Tom Rini
2024-07-26 12:08 ` Jerome Forissier
2024-07-26 8:44 ` Michal Simek
2024-07-26 12:39 ` Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 03/20] configs: replace '# CONFIG_NET is not set' with CONFIG_NO_NET=y Jerome Forissier
2024-08-07 13:58 ` Felix Brack
2024-07-25 12:57 ` [PATCH v5 04/20] net: fec_mxc_init(): do not ignore return status of fec_open() Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 05/20] net: split include/net.h into net{, -common, -legacy, -lwip}.h Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 06/20] net: eth-uclass: add function eth_start_udev() Jerome Forissier
2024-07-25 18:27 ` Tom Rini [this message]
2024-07-26 8:38 ` Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 07/20] net-lwip: build lwIP Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 08/20] net-lwip: add DHCP support and dhcp commmand Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 09/20] net-lwip: add TFTP support and tftpboot command Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 10/20] net-lwip: add ping command Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 11/20] net-lwip: add dns command Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 12/20] net: split cmd/net.c into cmd/net.c and cmd/net-common.c Jerome Forissier
2024-07-29 12:41 ` Ilias Apalodimas
2024-07-25 12:57 ` [PATCH v5 13/20] net-lwip: add wget command Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 14/20] net-lwip: lwIP wget supports user defined port in the uri, so allow it Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 15/20] cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 16/20] configs: add qemu_arm64_lwip_defconfig Jerome Forissier
2024-07-25 15:58 ` Tom Rini
2024-07-25 16:10 ` Jerome Forissier
2024-07-25 16:25 ` Tom Rini
2024-07-26 12:27 ` Jerome Forissier
2024-07-26 14:05 ` Tom Rini
2024-07-25 12:57 ` [PATCH v5 17/20] lwip: tftp: add support of blksize option to client Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 18/20] net-lwip: add TFTP_BLOCKSIZE Jerome Forissier
2024-07-29 12:29 ` Ilias Apalodimas
2024-07-29 15:18 ` Jerome Forissier
2024-07-30 9:57 ` Ilias Apalodimas
2024-07-25 12:57 ` [PATCH v5 19/20] CI: add qemu_arm64_lwip to the test matrix Jerome Forissier
2024-07-25 12:57 ` [PATCH v5 20/20] MAINTAINERS: net-lwip: add myself as a maintainer Jerome Forissier
2024-07-25 13:03 ` [PATCH v5 00/20] Introduce the lwIP network stack Fabio Estevam
2024-07-25 17:22 ` Tom Rini
2024-07-25 22:34 ` Tom Rini
2024-08-01 14:40 ` Jerome Forissier
2024-08-01 14:43 ` Tom Rini
2024-08-01 15:15 ` Jerome Forissier
2024-08-01 15:21 ` Tom Rini
2024-08-02 20:16 ` Tom Rini
2024-08-07 15:06 ` Jerome Forissier
2024-07-30 9:48 ` Jerome Forissier
2024-07-30 14:02 ` Tom Rini
2024-07-30 14:23 ` Jerome Forissier
2024-08-07 18:54 ` Michael Nazzareno Trimarchi
2024-08-07 19:08 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725182732.GC989285@bill-the-cat \
--to=trini@konsulko.com \
--cc=festevam@denx.de \
--cc=ilias.apalodimas@linaro.org \
--cc=javier.tia@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=michal.simek@amd.com \
--cc=muvarov@gmail.com \
--cc=raymond.mao@linaro.org \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox