Re: [PATCH v5 01/20] flash: prefix error codes with FL_

Jerome Forissier
2024-07-26T08:51:36Z

On 7/25/24 20:18, Tom Rini wrote:
> On Thu, Jul 25, 2024 at 02:57:22PM +0200, Jerome Forissier wrote:
>
>> Prefix the flash status codes (ERR_*) with FL_ in order to avoid clashes
>> with third-party libraries. Case in point: including the lwIP library
>> header file <lwip/err.h> which defines err_enum_t as an enum with values
>> being ERR_*.
>>
>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
>
> This is incomplete as for example 10m50 fails to build due to
> drivers/mtd/altera_qspi.c. It might be worth doing a world build with
> just this commit applied to check for other problems as well, in v6.
Fixed in v6. I have now grepped -w all the ERR_ codes and it was the only
one I missed.

Thanks,
--
Jerome