Re: [PATCH v5 01/20] flash: prefix error codes with FL_

Tom Rini
2024-07-25T18:18:12Z

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

On Thu, Jul 25, 2024 at 02:57:22PM +0200, Jerome Forissier wrote:

> Prefix the flash status codes (ERR_*) with FL_ in order to avoid clashes
> with third-party libraries. Case in point: including the lwIP library
> header file <lwip/err.h> which defines err_enum_t as an enum with values
> being ERR_*.
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

This is incomplete as for example 10m50 fails to build due to
drivers/mtd/altera_qspi.c. It might be worth doing a world build with
just this commit applied to check for other problems as well, in v6.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]