Re: [PATCH v5 16/20] configs: add qemu_arm64_lwip_defconfig

Tom Rini
2024-07-25T16:25:41Z

[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]

On Thu, Jul 25, 2024 at 06:10:48PM +0200, Jerome Forissier wrote:
>
>
> On 7/25/24 17:58, Tom Rini wrote:
> > On Thu, Jul 25, 2024 at 02:57:37PM +0200, Jerome Forissier wrote:
> >
> >> Add qemu_arm64_lwip_defconfig which #include's qemu_arm64_defconfig and
> >> selects NET_LWIP instead of NET. This config has all the supported net
> >> commands enabled.
> >>
> >> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> >> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> >> ---
> >> configs/qemu_arm64_lwip_defconfig | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >> create mode 100644 configs/qemu_arm64_lwip_defconfig
> >>
> >> diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig
> >> new file mode 100644
> >> index 00000000000..1afef04d7a0
> >> --- /dev/null
> >> +++ b/configs/qemu_arm64_lwip_defconfig
> >> @@ -0,0 +1,5 @@
> >> +#include <configs/qemu_arm64_defconfig>
> >> +CONFIG_NET_LWIP=y
> >> +CONFIG_CMD_DNS=y
> >> +CONFIG_CMD_WGET=y
> >> +CONFIG_EFI_HTTP_BOOT=y
> >
> > This doesn't work,
>
> How so? I've used "make qemu_arm64_lwip_defconfig" hundreds of time to build for
> arm64 QEMU :o

Yes, but buildman (and CI) are in a chicken-and-egg situation without a
few more details in the new defconfig, sadly.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]