Re: [PATCH v5 06/20] net: eth-uclass: add function eth_start_udev()

Jerome Forissier
2024-07-26T08:38:16Z

On 7/25/24 20:27, Tom Rini wrote:
> On Thu, Jul 25, 2024 at 02:57:27PM +0200, Jerome Forissier wrote:
>
>> Add a function to start a given etwork device, and update eth_init()
>
> Typo, "network".

Fixed in v6.

>> to use it.
>>
>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
>
> And this is where most of the tiny and acceptable growth comes from in
> the legacy network case.
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> But, does the lwIP side end up calling this too then, and so the need to
> split this out and not have it be static?

Yes, eth_start_udev() is called by new_netif() in net/lwip/net-lwip.c.

Thanks,
--
Jerome