From: Tom Rini <trini@konsulko.com>
To: Jerome Forissier <jerome.forissier@linaro.org>
Cc: u-boot@lists.denx.de,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Javier Tia <javier.tia@linaro.org>,
Raymond Mao <raymond.mao@linaro.org>,
Maxim Uvarov <muvarov@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Manoj Sai <abbaraju.manojsai@amarulasolutions.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
Gilles Talis <gilles.talis@gmail.com>,
Michal Simek <michal.simek@amd.com>, Marek Vasut <marex@denx.de>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>, Peng Fan <peng.fan@nxp.com>,
Nishanth Menon <nm@ti.com>, Simon Glass <sjg@chromium.org>,
Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>,
Leo Yu-Chi Liang <ycliang@andestech.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Algapally Santosh Sagar <santoshsagar.algapally@amd.com>,
James Hilliard <james.hilliard1@gmail.com>,
Petr Zejdl <petr.zejdl@cern.ch>,
Shiji Yang <yangshiji66@outlook.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Eddie James <eajames@linux.ibm.com>,
AKASHI Takahiro <akashi.tkhro@gmail.com>,
Francis Laniel <francis.laniel@amarulasolutions.com>,
Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>,
Maxim Moskalets <maximmosk4@gmail.com>,
Artur Rojek <artur@conclusive.pl>,
Sean Anderson <sean.anderson@seco.com>,
Neal Gompa <neal@gompa.dev>, Janne Grunau <j@jannau.net>,
Yang Xiwen <forbidden405@outlook.com>,
Gabor Juhos <j4g8y7@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>,
Boon Khai Ng <boon.khai.ng@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jonas Karlman <jonas@kwiboo.se>,
Robert Marko <robert.marko@sartura.hr>
Subject: Re: [PATCH v7 08/20] net-lwip: add DHCP support and dhcp commmand
Date: Fri, 2 Aug 2024 13:33:28 -0600 [thread overview]
Message-ID: <20240802193328.GP3794063@bill-the-cat> (raw)
In-Reply-To: <46b1fff7bc5088c1b7dfc75a4faca8b229749c68.1722615735.git.jerome.forissier@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Fri, Aug 02, 2024 at 06:26:35PM +0200, Jerome Forissier wrote:
> Add what it takes to enable NETDEVICES with NET_LWIP and enable DHCP as
> well as the dhcp command. CMD_TFTPBOOT is selected by BOOTMETH_EFI due
> to this code having an implicit dependency on do_tftpb().
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
[snip]
> diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c
> index 9a70c6095b3..c2492b69a13 100644
> --- a/lib/tiny-printf.c
> +++ b/lib/tiny-printf.c
> @@ -269,7 +269,7 @@ static int _vprintf(struct printf_info *info, const char *fmt, va_list va)
> }
> break;
> case 'p':
> - if (CONFIG_IS_ENABLED(NET) || _DEBUG) {
> + if (!CONFIG_IS_ENABLED(NO_NET) || _DEBUG) {
> pointer(info, fmt, va_arg(va, void *));
> /*
> * Skip this because it pulls in _ctype which is
This is subtly wrong, and you can see for example that _vsprintf grows
in TPL in pinephone-pro-rk3399.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-08-03 6:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 16:26 [PATCH v7 00/20] Introduce the lwIP network stack Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 01/20] flash: prefix error codes with FL_ Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 02/20] net: introduce alternative implementation as net-lwip/ Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 03/20] configs: replace '# CONFIG_NET is not set' with CONFIG_NO_NET=y Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 04/20] net: fec_mxc_init(): do not ignore return status of fec_open() Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 05/20] net: split include/net.h into net{, -common, -legacy, -lwip}.h Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 06/20] net: eth-uclass: add function eth_start_udev() Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 07/20] net-lwip: build lwIP Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 08/20] net-lwip: add DHCP support and dhcp commmand Jerome Forissier
2024-08-02 19:33 ` Tom Rini [this message]
2024-08-07 12:41 ` Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 09/20] net-lwip: add TFTP support and tftpboot command Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 10/20] net-lwip: add ping command Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 11/20] net-lwip: add dns command Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 12/20] net: split cmd/net.c into cmd/net.c and cmd/net-common.c Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 13/20] net-lwip: add wget command Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 14/20] net-lwip: lwIP wget supports user defined port in the uri, so allow it Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 15/20] cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 16/20] configs: add qemu_arm64_lwip_defconfig Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 17/20] lwip: tftp: add support of blksize option to client Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 18/20] net-lwip: add TFTP_BLOCKSIZE Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 19/20] CI: add qemu_arm64_lwip to the test matrix Jerome Forissier
2024-08-02 16:26 ` [PATCH v7 20/20] MAINTAINERS: net-lwip: add myself as a maintainer Jerome Forissier
2024-08-02 18:32 ` [PATCH v7 00/20] Introduce the lwIP network stack Tom Rini
2024-08-05 18:18 ` Jerome Forissier
2024-08-05 18:20 ` Tom Rini
2024-08-06 22:29 ` Jerome Forissier
2024-08-06 21:12 ` Simon Glass
2024-08-06 21:19 ` Tom Rini
2024-08-06 21:51 ` Simon Glass
2024-08-06 22:28 ` Jerome Forissier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802193328.GP3794063@bill-the-cat \
--to=trini@konsulko.com \
--cc=abbaraju.manojsai@amarulasolutions.com \
--cc=abdellatif.elkhlifi@arm.com \
--cc=akashi.tkhro@gmail.com \
--cc=artur@conclusive.pl \
--cc=boon.khai.ng@intel.com \
--cc=eajames@linux.ibm.com \
--cc=forbidden405@outlook.com \
--cc=francis.laniel@amarulasolutions.com \
--cc=gilles.talis@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=j4g8y7@gmail.com \
--cc=j@jannau.net \
--cc=james.hilliard1@gmail.com \
--cc=javier.tia@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=marex@denx.de \
--cc=matteo.lisi@engicam.com \
--cc=maximmosk4@gmail.com \
--cc=michal.simek@amd.com \
--cc=mkorpershoek@baylibre.com \
--cc=muvarov@gmail.com \
--cc=neal@gompa.dev \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=peng.fan@nxp.com \
--cc=petr.zejdl@cern.ch \
--cc=raymond.mao@linaro.org \
--cc=rfried.dev@gmail.com \
--cc=robert.marko@sartura.hr \
--cc=santoshsagar.algapally@amd.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
--cc=xypron.glpk@gmx.de \
--cc=yangshiji66@outlook.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox