From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01B89C3DA7F for ; Mon, 5 Aug 2024 05:32:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5BC23879C1; Mon, 5 Aug 2024 07:32:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=dolcini.it header.i=@dolcini.it header.b="y1IbWV86"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 76CC988806; Mon, 5 Aug 2024 07:32:06 +0200 (CEST) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 52666878ED for ; Mon, 5 Aug 2024 07:32:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francesco@dolcini.it Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id C4A161FC02; Mon, 5 Aug 2024 07:32:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1722835922; bh=UU0k/T7PvbAmft1e6ii0M1Oiq6d6dQpPaWXiuOO72Ao=; h=From:To:Subject; b=y1IbWV867K4DBNdywzGj6cCnJIa1x+jvJfD0dB4dmAaugdOXqcCexTaJrzni0w2Bv cqTHus4FdzIX5FIm3sJlh0J7UQWWyZHAM0qRKDYZq00J2AAhJeOrpjQ09MfdiJfQH8 s922hyo07zeeG5ftEMetkCO7Q+NpWLlqnVXvxa0d6RFUmxQSHJBhTmeEChdom7ikwV oKNgWAmG2PU7J+mnttmigqgpx994A4KntR+9x7E8OPJK4poZkPop+sM1hiQ+HgX+Ul 2RhgxVgUVclgOMhCULI+co63R5Z74FvIjVG/ONGaRofPliliSgyAhwD7wMKhZj+CgM e7+BmxF+F5UoA== Date: Mon, 5 Aug 2024 07:31:57 +0200 From: Francesco Dolcini To: Svyatoslav Ryhel Cc: Tom Rini , Jonas =?iso-8859-1?Q?Schw=F6bel?= , Thierry Reding , Francesco Dolcini , Joe Hershberger , Marcel Ziswiler , Fabio Estevam , Simon Glass , Emanuele Ghidoli , Martyn Welch , u-boot@lists.denx.de Subject: Re: [PATCH v1 1/1] board: tegra: convert tegra-based boards to text env Message-ID: <20240805053157.GA7516@francesco-nb> References: <20240801055738.7601-1-clamor95@gmail.com> <20240801055738.7601-2-clamor95@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801055738.7601-2-clamor95@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hello Clamor, On Thu, Aug 01, 2024 at 08:57:38AM +0300, Svyatoslav Ryhel wrote: > Convert boards to use text based env. This is the first stage of > conversion, common inclusions should be converted next. > > Signed-off-by: Svyatoslav Ryhel > --- > board/asus/grouper/grouper.env | 15 +++ > .../asus/transformer-t20/transformer-t20.env | 16 ++++ > .../transformer-t30/configs/tf600t.config | 1 + > board/asus/transformer-t30/tf600t.env | 16 ++++ > .../asus/transformer-t30/transformer-t30.env | 16 ++++ > board/htc/endeavoru/endeavoru.env | 13 +++ > .../ideapad-yoga-11/ideapad-yoga-11.env | 16 ++++ > board/lg/x3-t30/configs/p880.config | 1 + > board/lg/x3-t30/configs/p895.config | 1 + > board/lg/x3-t30/p880.env | 14 +++ > board/lg/x3-t30/p895.env | 13 +++ > board/microsoft/surface-rt/surface-rt.env | 14 +++ > board/nvidia/cardhu/cardhu.env | 2 + > board/nvidia/p2771-0000/p2771-0000.env | 22 +++++ > board/nvidia/p3450-0000/p3450-0000.env | 7 ++ > board/toradex/apalis-tk1/apalis_tk1.env | 45 +++++++++ > board/toradex/apalis_t30/apalis_t30.env | 9 ++ > board/toradex/colibri_t20/colibri_t20.env | 3 + > board/toradex/colibri_t30/colibri_t30.env | 9 ++ > board/wexler/qc750/qc750.env | 14 +++ > configs/apalis-tk1_defconfig | 1 + > configs/apalis_t30_defconfig | 1 + > configs/cardhu_defconfig | 1 + > configs/colibri_t20_defconfig | 1 + > configs/colibri_t30_defconfig | 1 + ... > diff --git a/board/toradex/apalis-tk1/apalis_tk1.env b/board/toradex/apalis-tk1/apalis_tk1.env > new file mode 100644 > index 0000000000..90db361be3 > --- /dev/null > +++ b/board/toradex/apalis-tk1/apalis_tk1.env > @@ -0,0 +1,45 @@ > +/* > + * Custom Distro Boot configuration: > + * 1. 8bit SD port (MMC1) > + * 2. 4bit SD port (MMC2) > + * 3. eMMC (MMC0) > + */ > +boot_targets=mmc1 mmc2 mmc0 usb pxe dhcp > + > +boot_file=zImage > +boot_script_dhcp=boot.scr > +console=ttyS0 > +defargs=lp0_vec=2064@0xf46ff000 core_edp_mv=1150 core_edp_ma=4000 > + usb_port_owner_info=2 lane_owner_info=6 emc_max_dvfs=0 > + user_debug=30 pcie_aspm=off > +dfu_alt_info=apalis-tk1.img raw 0x0 0x500 mmcpart 1; > + boot part 0 1 mmcpart 0; > + rootfs part 0 2 mmcpart 0; > + zImage fat 0 1 mmcpart 0; > + tegra124-apalis-eval.dtb fat 0 1 mmcpart 0 > +fdt_board=eval > +fdt_fixup=; > +fdt_module=apalis-v1.2 > +uboot_hwpart=1 > +uboot_blk=0 > +set_blkcnt=setexpr blkcnt ${filesize} + 0x1ff && > + setexpr blkcnt ${blkcnt} / 0x200 > +update_uboot=run set_blkcnt && mmc dev 0 ${uboot_hwpart} && > + mmc write ${loadaddr} ${uboot_blk} ${blkcnt} > +setethupdate=if env exists ethaddr; then; else setenv ethaddr > + 00:14:2d:00:00:00; fi; pci enum && tftpboot ${loadaddr} > + flash_eth.img && source ${loadaddr} > +setsdupdate=setenv interface mmc; setenv drive 1; mmc rescan; > + load ${interface} ${drive}:1 ${loadaddr} flash_blk.img > + || setenv drive 2; mmc rescan; load ${interface} ${drive}:1 > + ${loadaddr} flash_blk.img && > + source ${loadaddr} > +setup=setenv setupargs igb_mac=${ethaddr} > + consoleblank=0 no_console_suspend=1 console=tty1 > + console=${console},${baudrate}n8 debug_uartport=lsport,0 > + ${memargs} > +setupdate=run setsdupdate || run setusbupdate || run setethupdate > +setusbupdate=usb start && setenv interface usb; setenv drive 0; > + load ${interface} ${drive}:1 ${loadaddr} flash_blk.img && > + source ${loadaddr} > +vidargs=fbcon=map:1 ... > diff --git a/include/configs/apalis-tk1.h b/include/configs/apalis-tk1.h > index 71d4727ca9..4c690a1785 100644 > --- a/include/configs/apalis-tk1.h > +++ b/include/configs/apalis-tk1.h > @@ -18,64 +18,6 @@ > #define FDT_MODULE "apalis-v1.2" > #define FDT_MODULE_V1_0 "apalis" > > -/* > - * Custom Distro Boot configuration: > - * 1. 8bit SD port (MMC1) > - * 2. 4bit SD port (MMC2) > - * 3. eMMC (MMC0) > - */ > -#define BOOT_TARGET_DEVICES(func) \ > - func(MMC, mmc, 1) \ > - func(MMC, mmc, 2) \ > - func(MMC, mmc, 0) \ > - func(USB, usb, 0) \ > - func(PXE, pxe, na) \ > - func(DHCP, dhcp, na) > - I do recall that to transition to text env file it was required to move from standard boot to distroboot. Did I recall incorrectly? I commented on apalis-tk1, but from a quick look other boards would have the same issue. Thanks, Francesco