U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Teresa Remmet <t.remmet@phytec.de>,
	u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,
	Benjamin Hahn <B.Hahn@phytec.de>, Cem Tenruh <c.tenruh@phytec.de>,
	Martyn Welch <martyn.welch@collabora.com>,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v2] config: Add 'update_bootimg' command to update flash.bin on Phytec's imx8mm
Date: Tue, 6 Aug 2024 10:08:05 +0200	[thread overview]
Message-ID: <20240806100805.38f61c38@wsk> (raw)
In-Reply-To: <CAOMZO5B6F3LZcs=eYpZwOmDGctRqrnJDby2hH_343vczpk_uJQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

Hi Fabio,

> Hi Lukasz,
> 
> On Mon, Aug 5, 2024 at 5:42 AM Lukasz Majewski <lukma@denx.de> wrote:
> 
> > +       "update_offset=0x42\0" \
> > +       "update_filename=flash.bin\0" \
> > +       "hostname=/srv/tftp/\0" \
> > +       "update_bootimg="
> >     \
> > +               "mmc dev ${mmcdev} ; "          \
> > +               "if dhcp ${loadaddr} ${hostname}/${update_filename}
> > ; then "    \
> > +               "setexpr fw_sz ${filesize} / 0x200 ; "  /* SD block
> > size */ \
> > +               "setexpr fw_sz ${fw_sz} + 1 ; "  
> 
> As Benjamin pointed out earlier this increment by one is not
> necessary.
> 
> All other i.MX8M docs don't have this increment.

So apparently the BSP build scripts in OE/Yocto take always care to
have 0x200 aligned binaries (imx-boot and flash.bin).

OK, I will remove it.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2024-08-06  8:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-05  8:42 [PATCH v2] config: Add 'update_bootimg' command to update flash.bin on Phytec's imx8mm Lukasz Majewski
2024-08-05 23:24 ` Fabio Estevam
2024-08-06  8:08   ` Lukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240806100805.38f61c38@wsk \
    --to=lukma@denx.de \
    --cc=B.Hahn@phytec.de \
    --cc=c.tenruh@phytec.de \
    --cc=festevam@gmail.com \
    --cc=martyn.welch@collabora.com \
    --cc=sjg@chromium.org \
    --cc=t.remmet@phytec.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox