From: Christian Marangi <ansuelsmth@gmail.com>
To: Tom Rini <trini@konsulko.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Arseniy Krasnov <avkrasnov@salutedevices.com>,
Martin Kurbanov <mmkurbanov@salutedevices.com>,
Dmitry Dunaev <dunaev@tecon.ru>, Simon Glass <sjg@chromium.org>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Sean Anderson <sean.anderson@seco.com>,
Shiji Yang <yangshiji66@outlook.com>,
Vasileios Amoiridis <vassilisamir@gmail.com>,
Leo Yu-Chi Liang <ycliang@andestech.com>,
Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Michael Polyntsov <michael.polyntsov@iopsys.eu>,
Doug Zobel <douglas.zobel@climate.com>,
u-boot@lists.denx.de
Subject: [PATCH v2 1/9] led: turn LED ON on initial SW blink
Date: Wed, 7 Aug 2024 21:54:04 +0200 [thread overview]
Message-ID: <20240807195413.30456-2-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20240807195413.30456-1-ansuelsmth@gmail.com>
We currently init the LED OFF when SW blink is triggered when
on_state_change() is called. This can be problematic for very short
period as the ON/OFF blink might never trigger.
Turn LED ON on initial SW blink to handle this corner case and better
display a LED blink from the user.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/led/led_sw_blink.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/led/led_sw_blink.c b/drivers/led/led_sw_blink.c
index 9e36edbee47..853278670b9 100644
--- a/drivers/led/led_sw_blink.c
+++ b/drivers/led/led_sw_blink.c
@@ -103,8 +103,11 @@ bool led_sw_on_state_change(struct udevice *dev, enum led_state_t state)
return false;
if (state == LEDST_BLINK) {
+ struct led_ops *ops = led_get_ops(dev);
+
+ ops->set_state(dev, LEDST_ON);
/* start blinking on next led_sw_blink() call */
- sw_blink->state = LED_SW_BLINK_ST_OFF;
+ sw_blink->state = LED_SW_BLINK_ST_ON;
return true;
}
--
2.45.2
next prev parent reply other threads:[~2024-08-07 19:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 19:54 [PATCH v2 0/9] led: introduce LED boot and activity function Christian Marangi
2024-08-07 19:54 ` Christian Marangi [this message]
2024-08-07 19:54 ` [PATCH v2 2/9] led: implement led_set_state/period_by_label Christian Marangi
2024-08-07 19:54 ` [PATCH v2 3/9] led: implement LED boot API Christian Marangi
2024-08-07 19:54 ` [PATCH v2 4/9] common: board_r: rework BOOT LED handling Christian Marangi
2024-08-07 19:54 ` [PATCH v2 5/9] led: implement LED activity API Christian Marangi
2024-08-07 19:54 ` [PATCH v2 6/9] tftp: implement support for LED activity Christian Marangi
2024-08-07 19:54 ` [PATCH v2 7/9] mtd: " Christian Marangi
2024-08-07 19:54 ` [PATCH v2 8/9] ubi: " Christian Marangi
2024-08-07 19:54 ` [PATCH v2 9/9] doc: introduce led.rst documentation Christian Marangi
2024-08-08 6:34 ` Alexander Dahl
2024-08-09 13:59 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807195413.30456-2-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=avkrasnov@salutedevices.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=douglas.zobel@climate.com \
--cc=dunaev@tecon.ru \
--cc=joe.hershberger@ni.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=michael.polyntsov@iopsys.eu \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=miquel.raynal@bootlin.com \
--cc=mmkurbanov@salutedevices.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=rfried.dev@gmail.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vassilisamir@gmail.com \
--cc=xypron.glpk@gmx.de \
--cc=yangshiji66@outlook.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox