From: Christian Marangi <ansuelsmth@gmail.com>
To: Tom Rini <trini@konsulko.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Arseniy Krasnov <avkrasnov@salutedevices.com>,
Martin Kurbanov <mmkurbanov@salutedevices.com>,
Dmitry Dunaev <dunaev@tecon.ru>, Simon Glass <sjg@chromium.org>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Sean Anderson <sean.anderson@seco.com>,
Shiji Yang <yangshiji66@outlook.com>,
Vasileios Amoiridis <vassilisamir@gmail.com>,
Leo Yu-Chi Liang <ycliang@andestech.com>,
Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Michael Polyntsov <michael.polyntsov@iopsys.eu>,
Doug Zobel <douglas.zobel@climate.com>,
u-boot@lists.denx.de
Subject: [PATCH v2 4/9] common: board_r: rework BOOT LED handling
Date: Wed, 7 Aug 2024 21:54:07 +0200 [thread overview]
Message-ID: <20240807195413.30456-5-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20240807195413.30456-1-ansuelsmth@gmail.com>
Rework BOOT LED handling. There is currently one legacy implementation
for BOOT LED from Status Led API.
This work on ancient implementation wused by BOOTP by setting the LED
to Blink on boot and to turn it OFF when the firmware was correctly
received by network.
Now that we new LED implementation have support for LED boot, rework
this by also set the new BOOT LED to blink and also set it to ON before
entering main loop to confirm successful boot.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
common/board_r.c | 25 ++++++++++++++++++++++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index d4ba245ac69..57957b4e99b 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -39,6 +39,7 @@
#include <initcall.h>
#include <kgdb.h>
#include <irq_func.h>
+#include <led.h>
#include <malloc.h>
#include <mapmem.h>
#include <miiphy.h>
@@ -462,14 +463,30 @@ static int initr_malloc_bootparams(void)
#if defined(CONFIG_LED_STATUS)
static int initr_status_led(void)
{
-#if defined(CONFIG_LED_STATUS_BOOT)
- status_led_set(CONFIG_LED_STATUS_BOOT, CONFIG_LED_STATUS_BLINKING);
-#else
status_led_init();
+
+ return 0;
+}
+#endif
+
+static int initr_boot_led_blink(void)
+{
+#ifdef CONFIG_LED_STATUS_BOOT
+ status_led_set(CONFIG_LED_STATUS_BOOT, CONFIG_LED_STATUS_BLINKING);
+#endif
+#ifdef CONFIG_LED_BOOT_ENABLE
+ led_boot_blink();
#endif
return 0;
}
+
+static int initr_boot_led_on(void)
+{
+#ifdef CONFIG_LED_BOOT_ENABLE
+ led_boot_on();
#endif
+ return 0;
+}
#ifdef CONFIG_CMD_NET
static int initr_net(void)
@@ -716,6 +733,7 @@ static init_fnc_t init_sequence_r[] = {
#if defined(CONFIG_LED_STATUS)
initr_status_led,
#endif
+ initr_boot_led_blink,
/* PPC has a udelay(20) here dating from 2002. Why? */
#ifdef CONFIG_BOARD_LATE_INIT
board_late_init,
@@ -738,6 +756,7 @@ static init_fnc_t init_sequence_r[] = {
#if defined(CFG_PRAM)
initr_mem,
#endif
+ initr_boot_led_on,
run_main_loop,
};
--
2.45.2
next prev parent reply other threads:[~2024-08-07 19:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 19:54 [PATCH v2 0/9] led: introduce LED boot and activity function Christian Marangi
2024-08-07 19:54 ` [PATCH v2 1/9] led: turn LED ON on initial SW blink Christian Marangi
2024-08-07 19:54 ` [PATCH v2 2/9] led: implement led_set_state/period_by_label Christian Marangi
2024-08-07 19:54 ` [PATCH v2 3/9] led: implement LED boot API Christian Marangi
2024-08-07 19:54 ` Christian Marangi [this message]
2024-08-07 19:54 ` [PATCH v2 5/9] led: implement LED activity API Christian Marangi
2024-08-07 19:54 ` [PATCH v2 6/9] tftp: implement support for LED activity Christian Marangi
2024-08-07 19:54 ` [PATCH v2 7/9] mtd: " Christian Marangi
2024-08-07 19:54 ` [PATCH v2 8/9] ubi: " Christian Marangi
2024-08-07 19:54 ` [PATCH v2 9/9] doc: introduce led.rst documentation Christian Marangi
2024-08-08 6:34 ` Alexander Dahl
2024-08-09 13:59 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807195413.30456-5-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=avkrasnov@salutedevices.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=douglas.zobel@climate.com \
--cc=dunaev@tecon.ru \
--cc=joe.hershberger@ni.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=michael.polyntsov@iopsys.eu \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=miquel.raynal@bootlin.com \
--cc=mmkurbanov@salutedevices.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=rfried.dev@gmail.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vassilisamir@gmail.com \
--cc=xypron.glpk@gmx.de \
--cc=yangshiji66@outlook.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox