U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>
Cc: u-boot@lists.denx.de, upstream+uboot@sigma-star.at,
	trini@konsulko.com, thomas.petazzoni@bootlin.com,
	jmcosta944@gmail.com
Subject: Re: [PATCH v2 4/4] squashfs: Fix stack overflow while symlink resolving
Date: Mon, 12 Aug 2024 09:51:39 +0200	[thread overview]
Message-ID: <20240812095139.32c5cf66@xps-13> (raw)
In-Reply-To: <20240802163647.26674-4-richard@nod.at>

Hi Richard,

richard@nod.at wrote on Fri,  2 Aug 2024 18:36:47 +0200:

> The squashfs driver blindly follows symlinks, and calls sqfs_size()
> recursively. So an attacker can create a crafted filesystem and with
> a deep enough nesting level a stack overflow can be achieved.
> 
> Fix by limiting the nesting level to 8.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

  reply	other threads:[~2024-08-12  7:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 16:36 [PATCH v2 1/4] squashfs: Fix integer overflow in sqfs_resolve_symlink() Richard Weinberger
2024-08-02 16:36 ` [PATCH v2 2/4] squashfs: Fix integer overflow in sqfs_inode_size() Richard Weinberger
2024-08-02 16:36 ` [PATCH v2 3/4] squashfs: Check sqfs_find_inode() return value Richard Weinberger
2024-08-02 16:36 ` [PATCH v2 4/4] squashfs: Fix stack overflow while symlink resolving Richard Weinberger
2024-08-12  7:51   ` Miquel Raynal [this message]
2024-08-16  3:47 ` [PATCH v2 1/4] squashfs: Fix integer overflow in sqfs_resolve_symlink() Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240812095139.32c5cf66@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=jmcosta944@gmail.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=upstream+uboot@sigma-star.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox