U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>
Cc: u-boot@lists.denx.de, upstream+uboot@sigma-star.at,
	trini@konsulko.com, thomas.petazzoni@bootlin.com,
	jmcosta944@gmail.com
Subject: Re: [PATCH] squashfs: Fix heap corruption in sqfs_search_dir()
Date: Mon, 12 Aug 2024 09:52:54 +0200	[thread overview]
Message-ID: <20240812095254.54a82ad4@xps-13> (raw)
In-Reply-To: <20240802200509.2471-1-richard@nod.at>

Hi Richard,

richard@nod.at wrote on Fri,  2 Aug 2024 22:05:09 +0200:

> res needs to be large enough to store both strings rem and target,
> plus the path separator and the terminator.
> Currently the space for the path separator is not accounted, so
> the heap is corrupted by one byte.

Mmm, subtle.

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks for the fix!
Miquèl

  reply	other threads:[~2024-08-12  7:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 20:05 [PATCH] squashfs: Fix heap corruption in sqfs_search_dir() Richard Weinberger
2024-08-12  7:52 ` Miquel Raynal [this message]
2024-08-16  3:47 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240812095254.54a82ad4@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=jmcosta944@gmail.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=upstream+uboot@sigma-star.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox