From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v2 26/35] global_data: Reduce size of early-malloc vars
Date: Fri, 23 Aug 2024 07:34:50 -0600 [thread overview]
Message-ID: <20240823133450.GA1627158@bill-the-cat> (raw)
In-Reply-To: <20240821161927.695717-27-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Wed, Aug 21, 2024 at 10:19:18AM -0600, Simon Glass wrote:
> The early malloc region is normally quite small and is certainly less
> than 4GB, so use a 32-bit value for the limit and pointer. Update the
> comment for clarity while we are here.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v1)
>
> arch/arm/lib/bdinfo.c | 2 +-
> common/board_r.c | 2 +-
> common/malloc_simple.c | 7 ++++---
> common/spl/spl.c | 4 ++--
> include/asm-generic/global_data.h | 6 +++---
> 5 files changed, 11 insertions(+), 10 deletions(-)
This breaks booting on am64x_evm_a53 which is an odd platform that does
SPL->SPL->U-Boot.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-08-23 13:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 16:18 [PATCH v2 00/35] global_data: Reduce size of struct global_data Simon Glass
2024-08-21 16:18 ` [PATCH v2 01/35] global_data: Move pci_clk to m68k and powerpc Simon Glass
2024-08-21 16:18 ` [PATCH v2 02/35] x86: Drop use of global_data fb_base Simon Glass
2024-08-21 16:18 ` [PATCH v2 03/35] video: Add a function to obtain the framebuffer address Simon Glass
2024-08-21 16:18 ` [PATCH v2 04/35] video: mxc: Avoid setting global_data fb_base Simon Glass
2024-08-21 16:18 ` [PATCH v2 05/35] video: mxs: " Simon Glass
2024-08-21 16:18 ` [PATCH v2 06/35] arm: friendlyarm: Avoid accessing " Simon Glass
2024-08-21 16:18 ` [PATCH v2 07/35] arm: ronetix: " Simon Glass
2024-08-21 16:19 ` [PATCH v2 08/35] zynqmp: Avoid setting the framebuffer address Simon Glass
2024-08-21 16:19 ` [PATCH v2 09/35] video: Avoid setting global_data fb_base from SPL handoff Simon Glass
2024-08-21 16:19 ` [PATCH v2 10/35] video: Avoid setting global_data fb_base in video setup Simon Glass
2024-08-21 16:19 ` [PATCH v2 11/35] global_data: Drop fb_base Simon Glass
2024-08-21 16:19 ` [PATCH v2 12/35] global_data: Convert have_console into a flag Simon Glass
2024-08-21 16:19 ` [PATCH v2 13/35] global_data: Remove pci_ram_top Simon Glass
2024-08-21 16:19 ` [PATCH v2 14/35] global_data: Drop global_data hose Simon Glass
2024-08-21 16:19 ` [PATCH v2 15/35] global_data: Drop pci_bootdelay Simon Glass
2024-08-21 16:19 ` [PATCH v2 16/35] global_data: Use less space for environment fields Simon Glass
2024-08-21 16:19 ` [PATCH v2 17/35] board_f: Add a new struct to hold pre-relocation info Simon Glass
2024-08-21 16:19 ` [PATCH v2 18/35] board_f: Move fdt_size to board Simon Glass
2024-08-21 16:19 ` [PATCH v2 19/35] board_f: Move new_bootstage to boardf Simon Glass
2024-08-21 16:19 ` [PATCH v2 20/35] board_f: Move new_bloblist " Simon Glass
2024-08-21 16:19 ` [PATCH v2 21/35] global_data: Drop spl_handoff Simon Glass
2024-08-21 16:19 ` [PATCH v2 22/35] global_data: Collect common fields at the top Simon Glass
2024-08-21 16:19 ` [PATCH v2 23/35] global_data: Reduce the size of bus_clk and mem_clk Simon Glass
2024-08-21 16:19 ` [PATCH v2 24/35] global_data: Reduce the size of mon_len Simon Glass
2024-08-21 16:19 ` [PATCH v2 25/35] global_data: log: Reorder and shrink fields Simon Glass
2024-08-21 16:19 ` [PATCH v2 26/35] global_data: Reduce size of early-malloc vars Simon Glass
2024-08-23 13:34 ` Tom Rini [this message]
2024-08-23 20:30 ` Simon Glass
2024-08-23 21:07 ` Tom Rini
2024-08-23 21:44 ` Simon Glass
2024-08-23 21:49 ` Tom Rini
2024-08-23 23:30 ` Simon Glass
2024-08-26 18:33 ` Tom Rini
2024-08-27 19:25 ` Simon Glass
2024-08-21 16:19 ` [PATCH v2 27/35] global_data: Move baud_rate field lower Simon Glass
2024-08-21 16:19 ` [PATCH v2 28/35] global_data: Move env_addr field higher Simon Glass
2024-08-21 16:19 ` [PATCH v2 29/35] global_data: Put phys_addr fields near the top Simon Glass
2024-08-21 16:19 ` [PATCH v2 30/35] global_data: Move ulong fields together Simon Glass
2024-08-21 16:19 ` [PATCH v2 31/35] global_data: Move pointer members together Simon Glass
2024-08-21 16:19 ` [PATCH v2 32/35] global_data: Remove jump table in SPL Simon Glass
2024-08-21 16:19 ` [PATCH v2 33/35] global_data: Remove environment members if not used Simon Glass
2024-08-21 16:19 ` [PATCH v2 34/35] doc: Move generic-board documentation into rst Simon Glass
2024-08-21 16:19 ` [PATCH v2 35/35] doc: Add some guidelines about global data Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823133450.GA1627158@bill-the-cat \
--to=trini@konsulko.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox