U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Teresa Remmet <t.remmet@phytec.de>,
	Stefano Babic <sbabic@denx.de>,
	uboot-imx@nxp.com, Cem Tenruh <c.tenruh@phytec.de>,
	Tom Rini <trini@konsulko.com>,
	u-boot@lists.denx.de, Yannic Moog <y.moog@phytec.de>,
	Benjamin Hahn <B.Hahn@phytec.de>
Subject: Re: [PATCH v2] config: imx: Define CFG_SYS_UBOOT_BASE for Phytec's imx8mm SoM QSPI boot
Date: Wed, 28 Aug 2024 09:55:20 +0200	[thread overview]
Message-ID: <20240828095520.76f904bc@wsk> (raw)
In-Reply-To: <CAOMZO5AAfn7zw1+VEGjdS6UAQLv5kTVT97_dy_oxhauntYeHvQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

Hi Fabio,

> Hi Lukasz,
> 
> On Tue, Aug 20, 2024 at 12:00 PM Lukasz Majewski <lukma@denx.de>
> wrote:
> >
> > The image offset when booting from SPI-NOR (QSPI, FSPI driver) is
> > different than one for SD card / eMMC as extra space (0x1000) is
> > consumed by FSPI configuration header (CONFIG_FSPI_CONF_HEADER).
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> > Changes for v2:
> > - Avoid line breaks with defines  
> 
> From the other thread, my understanding is that QSPI boot is still not
> working with this patch applied.
> 

But this is an orthogonal problem - the problem is with binman image
generation.

This patch follows the code already present in e.g. imx8mm_beacon*
boards.

> Please resend this patch when the QSPI boot problem is resolved.
> 

As I've written above - problem is solely with binman code generation -
after reverting 3 last commits from imx8mm-u-boot.dtsi the image is
correctly generated.

> Thanks




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2024-08-28  7:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20 14:59 [PATCH v2] config: imx: Define CFG_SYS_UBOOT_BASE for Phytec's imx8mm SoM QSPI boot Lukasz Majewski
2024-08-27 18:49 ` Fabio Estevam
2024-08-28  7:55   ` Lukasz Majewski [this message]
2024-08-30 13:23     ` Benjamin Hahn
2024-08-30 15:19       ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240828095520.76f904bc@wsk \
    --to=lukma@denx.de \
    --cc=B.Hahn@phytec.de \
    --cc=c.tenruh@phytec.de \
    --cc=festevam@gmail.com \
    --cc=sbabic@denx.de \
    --cc=t.remmet@phytec.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=y.moog@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox