Re: [PATCH 12/35] global_data: Convert have_console into a flag

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

On Thu, Aug 29, 2024 at 08:05:35AM -0600, Simon Glass wrote:
> Hi Alexander,
> 
> On Fri, 16 Aug 2024 at 07:08, Sverdlin, Alexander
> <alexander.sverdlin@siemens.com> wrote:
> >
> > Hi Simon,
> >
> > On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote:
> > > We don't need a full word for this boolean value. Convert it into a flag
> > > to save space in global_data.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > ---
> > >
> > >  arch/arm/cpu/arm926ejs/mxs/spl_boot.c |  2 +-
> > >  arch/arm/mach-exynos/spl_boot.c       |  2 +-
> > >  arch/arm/mach-k3/common.c             |  2 +-
> > >  arch/arm/mach-k3/r5/sysfw-loader.c    |  2 +-
> > >  board/siemens/common/board_am335x.c   |  2 +-
> > >  common/board_f.c                      |  2 +-
> > >  common/console.c                      | 14 +++++++-------
> > >  common/spl/spl.c                      |  2 +-
> > >  include/asm-generic/global_data.h     | 17 +++++++----------
> > >  9 files changed, 21 insertions(+), 24 deletions(-)
> > >
> > > diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
> > > index 76a69d7f958..dd748328293 100644
> > > --- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
> > > +++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
> >
> > [...]
> >
> > > @@ -219,7 +210,7 @@ struct global_data {
> > >  #endif
> > >  #ifdef CONFIG_TIMER
> > >       /**
> > > -      * @timer: timer instance for Driver Model
> > > +s     * @timer: timer instance for Driver Model
> >
> > an unintentional change?
> >
> > >        */
> > >       struct udevice *timer;
> > >  #endif
> >
> > the rest looks good to me and you can add my
> > Reviewed-by: if you remove the above chunk.
> >
> 
> Thank you. I'm not sure where that came from, but it seems to be gone now.

I fixed this up manually when applying (and added the tag).

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]