From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>,
Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>,
Hugues Kamba Mpiana <hugues.kambampiana@arm.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH v4 02/23] nvmxip: Avoid probing on boot
Date: Mon, 2 Sep 2024 10:10:47 -0600 [thread overview]
Message-ID: <20240902161047.GC2479150@bill-the-cat> (raw)
In-Reply-To: <20240901222634.460873-3-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
On Sun, Sep 01, 2024 at 04:26:13PM -0600, Simon Glass wrote:
> Devices should be probed when they are used, not before. Drop this
> boot-time probing.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v1)
>
> drivers/mtd/nvmxip/nvmxip-uclass.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/mtd/nvmxip/nvmxip-uclass.c b/drivers/mtd/nvmxip/nvmxip-uclass.c
> index 58e8c3fb74b..d18bd0e3d6b 100644
> --- a/drivers/mtd/nvmxip/nvmxip-uclass.c
> +++ b/drivers/mtd/nvmxip/nvmxip-uclass.c
> @@ -53,14 +53,7 @@ int nvmxip_probe(struct udevice *udev)
> return 0;
> }
>
> -static int nvmxip_post_bind(struct udevice *udev)
> -{
> - dev_or_flags(udev, DM_FLAG_PROBE_AFTER_BIND);
> - return 0;
> -}
> -
> UCLASS_DRIVER(nvmxip) = {
> .name = "nvmxip",
> .id = UCLASS_NVMXIP,
> - .post_bind = nvmxip_post_bind,
> };
Once again, adding in the corstone1000 maintainers as the platform that
actually uses this.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-09-02 16:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 22:26 [PATCH v4 00/23] Fix various bugs Simon Glass
2024-09-01 22:26 ` [PATCH v4 01/23] nvmxip: Drop the message on probe Simon Glass
2024-09-01 22:26 ` [PATCH v4 02/23] nvmxip: Avoid probing on boot Simon Glass
2024-09-02 16:10 ` Tom Rini [this message]
2024-09-10 18:41 ` Simon Glass
2024-09-12 15:59 ` Abdellatif El Khlifi
2024-09-01 22:26 ` [PATCH v4 03/23] test/py: Fix some pylint warnings in test_ut.py Simon Glass
2024-09-01 22:26 ` [PATCH v4 04/23] scripts: Update pylint.base Simon Glass
2024-09-01 22:26 ` [PATCH v4 05/23] bootstd: Create a function to reset USB Simon Glass
2024-09-01 22:26 ` [PATCH v4 06/23] usb: Drop old non-DM code Simon Glass
2024-09-01 22:26 ` [PATCH v4 07/23] log: Add a new log category for the console Simon Glass
2024-09-01 22:26 ` [PATCH v4 08/23] usb: Add DEV_FLAGS_DM to stdio for USB keyboard Simon Glass
2024-09-01 22:26 ` [PATCH v4 09/23] dm: usb: Deal with USB keyboard persisting across tests Simon Glass
2024-09-01 22:26 ` [PATCH v4 10/23] test: mbr: Adjust test to use lower-case hex Simon Glass
2024-09-01 22:26 ` [PATCH v4 11/23] test: mbr: Adjust test to drop 0x Simon Glass
2024-09-01 22:26 ` [PATCH v4 12/23] sandbox: Change the range used for memory-mapping tags Simon Glass
2024-09-01 22:26 ` [PATCH v4 13/23] sandbox: Update cpu to use logging Simon Glass
2024-09-01 22:26 ` [PATCH v4 14/23] sandbox: Unmap old tags Simon Glass
2024-09-01 22:26 ` [PATCH v4 15/23] sandbox: Add some debugging to pci_io Simon Glass
2024-09-01 22:26 ` [PATCH v4 16/23] sandbox: Implement reference counting for address mapping Simon Glass
2024-09-01 22:26 ` [PATCH v4 17/23] mmc: Use map_sysmem() with buffers in the mmc command Simon Glass
2024-09-01 22:26 ` [PATCH v4 18/23] read: Tidy up use of map_sysmem() in the read command Simon Glass
2024-09-01 22:26 ` [PATCH v4 19/23] cmd: Fix memory-mapping in cmp command Simon Glass
2024-09-03 9:42 ` Quentin Schulz
2024-09-20 15:59 ` Simon Glass
2024-09-01 22:26 ` [PATCH v4 20/23] test: mbr: Unmap the buffers after use Simon Glass
2024-09-01 22:26 ` [PATCH v4 21/23] test: mbr: Use a constant for the block size Simon Glass
2024-09-01 22:26 ` [PATCH v4 22/23] test: mbr: Use RAM for the buffers Simon Glass
2024-09-01 22:26 ` [PATCH v4 23/23] test: mbr: Drop a duplicate test Simon Glass
2024-09-19 0:01 ` [PATCH v4 00/23] Fix various bugs Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902161047.GC2479150@bill-the-cat \
--to=trini@konsulko.com \
--cc=abdellatif.elkhlifi@arm.com \
--cc=hugues.kambampiana@arm.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox