From: Tom Rini <trini@konsulko.com>
To: Jerome Forissier <jerome.forissier@linaro.org>
Cc: u-boot@lists.denx.de,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Javier Tia <javier.tia@linaro.org>,
Raymond Mao <raymond.mao@linaro.org>,
Maxim Uvarov <muvarov@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Anton Antonov <Anton.Antonov@arm.com>,
Lukasz Majewski <lukma@denx.de>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Marek Vasut <marex@denx.de>,
Jaehoon Chung <jh80.chung@samsung.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Jonas Karlman <jonas@kwiboo.se>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v10 21/25] Kconfig: fix undefined symbols (g_dnl*) when NET_LWIP is default enabled
Date: Mon, 9 Sep 2024 08:32:28 -0600 [thread overview]
Message-ID: <20240909143228.GA4252@bill-the-cat> (raw)
In-Reply-To: <9462e25d33d93c670a882e6ee329ca7e6668d7ab.1725625913.git.jerome.forissier@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Fri, Sep 06, 2024 at 02:33:37PM +0200, Jerome Forissier wrote:
> Fix for link errors on am62px_evm_a53and other platforms when NET_LWIP
> is enabled:
>
> common/dfu.c:34:(.text.run_usb_dnl_gadget+0x68): undefined reference to `g_dnl_clear_detach
> [...]
> common/spl/spl_dfu.c:29:(.text.spl_dfu_cmd+0xb0): undefined reference to `run_usb_dnl_gadget'
>
> - DFU_OVER_USB compiles common/dfu.c which calls g_dnl_clear_detach()
> which is implemented in drivers/usb/gadget/g_dnl.c which needs
> USB_GADGET_DOWNLOAD
> - SPL_DFU compiles common/spl/spl_dfu.c which calls run_usb_dnl_gadget()
> which is implemented in common/dfu.c which needs DFU_OVER_USB
>
> Therefore add these dependencies to Kconfig.
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-09-09 14:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 12:33 [PATCH v10 00/25] Introduce the lwIP network stack Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 01/25] Miscellaneous fixes Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 02/25] net: introduce alternative implementation as net-lwip/ Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 03/25] configs: replace '# CONFIG_NET is not set' with CONFIG_NO_NET=y Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 04/25] net: split include/net.h into net{, -common, -legacy, -lwip}.h Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 05/25] net: move copy_filename() to new file net/net-common.c Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 06/25] net: eth-uclass: add function eth_start_udev() Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 07/25] net-lwip: build lwIP Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 08/25] net-lwip: add DHCP support and dhcp commmand Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 09/25] net-lwip: add TFTP support and tftpboot command Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 10/25] net-lwip: add ping command Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 11/25] net-lwip: add dns command Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 12/25] net: split cmd/net.c into cmd/net.c and cmd/net-common.c Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 13/25] net-lwip: add wget command Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 14/25] net-lwip: lwIP wget supports user defined port in the uri, so allow it Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 15/25] cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 16/25] configs: add qemu_arm64_lwip_defconfig Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 17/25] lwip: tftp: add support of blksize option to client Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 18/25] net-lwip: add TFTP_BLOCKSIZE Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 19/25] CI: add qemu_arm64_lwip to the test matrix Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 20/25] MAINTAINERS: net-lwip: add myself as a maintainer Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 21/25] Kconfig: fix undefined symbols (g_dnl*) when NET_LWIP is default enabled Jerome Forissier
2024-09-09 14:32 ` Tom Rini [this message]
2024-09-09 14:35 ` Marek Vasut
2024-09-10 9:50 ` Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 22/25] configs: use syntax CONFIG_FOO=n in tools-only_defconfig Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 23/25] [TESTING] configs: set CONFIG_NET=y for FTGMAC100 Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 24/25] [TESTING] configs: set CONFIG_NET=y when PXE is enabled Jerome Forissier
2024-09-06 12:33 ` [PATCH v10 25/25] [TESTING] Kconfig: enable NET_LWIP by default except for SANDBOX Jerome Forissier
2024-09-06 17:54 ` [PATCH v10 00/25] Introduce the lwIP network stack Tom Rini
2024-09-09 14:11 ` Jerome Forissier
2024-09-09 16:19 ` Tom Rini
2024-09-13 9:33 ` Jerome Forissier
2024-09-13 13:59 ` Tom Rini
2024-09-13 14:37 ` Jerome Forissier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909143228.GA4252@bill-the-cat \
--to=trini@konsulko.com \
--cc=Anton.Antonov@arm.com \
--cc=ilias.apalodimas@linaro.org \
--cc=javier.tia@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=jonas@kwiboo.se \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=miquel.raynal@bootlin.com \
--cc=mkorpershoek@baylibre.com \
--cc=muvarov@gmail.com \
--cc=raymond.mao@linaro.org \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox