public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: al.kochet@gmail.com
To: u-boot@lists.denx.de
Cc: Alexander Kochetkov <al.kochet@gmail.com>
Subject: [PATCH 2/3] image-host: fix 'unknown error' error message
Date: Mon, 16 Sep 2024 11:24:45 +0300	[thread overview]
Message-ID: <20240916082446.32082-3-al.kochet@gmail.com> (raw)
In-Reply-To: <20240916082446.32082-1-al.kochet@gmail.com>

From: Alexander Kochetkov <al.kochet@gmail.com>

Fix error message like this:
Can't add verification data for node 'fdt-1' (<unknown error>)

We get unknown error because we decode error as fdt error
but actually it is system error.

Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
---
 tools/image-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/image-host.c b/tools/image-host.c
index 7bfc0cb6b1..ac14d9aa86 100644
--- a/tools/image-host.c
+++ b/tools/image-host.c
@@ -1333,7 +1333,7 @@ int fit_add_verification_data(const char *keydir, const char *keyfile,
 		if (ret) {
 			fprintf(stderr, "Can't add verification data for node '%s' (%s)\n",
 				fdt_get_name(fit, noffset, NULL),
-				fdt_strerror(ret));
+				strerror(-ret));
 			return ret;
 		}
 	}
-- 
2.17.1


  parent reply	other threads:[~2024-09-16  8:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16  8:24 [PATCH 0/3] Implement signing FIT images during image build al.kochet
2024-09-16  8:24 ` [PATCH 1/3] binman: fix passing loadables to mkimage on first run al.kochet
2024-10-09  1:50   ` Simon Glass
2024-10-17 23:12     ` Simon Glass
2024-09-16  8:24 ` al.kochet [this message]
2024-10-09  1:50   ` [PATCH 2/3] image-host: fix 'unknown error' error message Simon Glass
2024-10-17 23:12     ` Simon Glass
2024-09-16  8:24 ` [PATCH 3/3] binman: implement signing FIT images during image build al.kochet
2024-10-09  1:50   ` Simon Glass
2024-10-17 23:12     ` Simon Glass
2024-10-09  1:50 ` [PATCH 0/3] Implement " Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240916082446.32082-3-al.kochet@gmail.com \
    --to=al.kochet@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox