Re: [PATCH v5 10/14] efi_loader: Disable ANSI output for tests

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

On Mon, Sep 16, 2024 at 05:42:12PM +0200, Simon Glass wrote:
> Hi Heinrich,
> 
> On Thu, 12 Sept 2024 at 08:58, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > On 02.09.24 03:18, Simon Glass wrote:
> > > We don't want ANSI characters written in tests since it is a pain to
> > > check the output with ut_assert_nextline() et al.
> > >
> > > Provide a way to tests to request that ANSI characters not be sent.
> > >
> > > Add a proper function comment while we are here, to encourage others.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> >
> > This patch was already NAKed in the last version.
> >
> > Please, adjust the test framework if you need filtering.
> 
> In what way should it be adjusted? I hope you are not suggesting that
> sandbox should try to filter out ANSI characters in its assertions?

Well, perhaps the pytest framework should be filtering it out? And
again and to be clear, I can't reliably run these tests on _hardware_
because of the ANSI characters tripping things up, this is not a
"sandbox" problem.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]