Re: [PATCH 3/9] ARM: socfpga: add Enclustra AA1 SoM support

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]

On Sat, Sep 14, 2024 at 10:03:02PM +0200, Lothar Rubusch wrote:
> On Thu, Sep 12, 2024 at 7:45 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Sep 12, 2024 at 06:06:43AM +0000, Lothar Rubusch wrote:
> >
> > > Introduce initial support for the Enclustra SoMs:
> > >
> > > - Mercury AA1
> > >
> > > Cover general board files for SD/MMC and QSPI boot modes. Integrate the
> > > boards to kconfig. All build variants will depend on Quartus handoff
> > > files, thus they depend on the particular Quartus design. The approach is
> > > covered in the according documentation part.
> > >
> > > Additionally add configuration for SD/MMC boot and QSPI bootmodes. Register
> > > additional targets in kconfig.
> > >
> > > Signed-off-by: Andreas Buerkler <andreas.buerkler@enclustra.com>
> > > Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
> > [snip]
[snip]
> > > +U_BOOT_CMD(altera_set_storage, 2, 0, altera_set_storage_cmd,
> > > +        "Set non volatile memory access",
> > > +        "<MMC|QSPI|EMMC> - Set access for the selected memory device");
> > > +
> > > +#endif
> >
> > The entire file seems to be for just adding the cmd. Perhaps rename this
> > file to reflect that and have the Makefile only even build this when
> > CONFIG_SPL_BUILD is not set.
> 
> Agree. It looks cleaner now. I prepare this in the next version of
> this patch set. Thank you for the hint. I would name it as
> aa1_set_storage_cmd() is this ok?

Yes, the name sounds fine. Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]