public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: bigunclemax@gmail.com
Cc: bigunclemax@gmail.com, Marek Vasut <marex@denx.de>,
	Tom Rini <trini@konsulko.com>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	Caleb Connolly <caleb.connolly@linaro.org>,
	u-boot@lists.denx.de
Subject: [PATCH v1] eth: asix88179: drop ADVERTISE_LPACK and ADVERTISE_NPAGE advertise flags
Date: Thu, 19 Sep 2024 16:58:45 +0300	[thread overview]
Message-ID: <20240919135851.153120-1-bigunclemax@gmail.com> (raw)

From: Maksim Kiselev <bigunclemax@gmail.com>

Some USB-ETH adapters based on the AX88179 (ex. D-link DUB-2312)
has link issue if ADVERTISE_NPAGE flag is set.

Also Linux drivers for ASIX chips doesn't use these flags.

Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>
---
 drivers/usb/eth/asix88179.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/eth/asix88179.c b/drivers/usb/eth/asix88179.c
index 4bd3b9d10d..1f469a1a7d 100644
--- a/drivers/usb/eth/asix88179.c
+++ b/drivers/usb/eth/asix88179.c
@@ -345,8 +345,8 @@ static int asix_basic_reset(struct ueth_data *dev,
 	asix_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, tmp16);
 
 	u16 adv = 0;
-	adv = ADVERTISE_ALL | ADVERTISE_CSMA | ADVERTISE_LPACK |
-	      ADVERTISE_NPAGE | ADVERTISE_PAUSE_ASYM | ADVERTISE_PAUSE_CAP;
+	adv = ADVERTISE_ALL | ADVERTISE_CSMA | ADVERTISE_PAUSE_ASYM |
+	      ADVERTISE_PAUSE_CAP;
 	asix_write_cmd(dev, AX_ACCESS_PHY, 0x03, MII_ADVERTISE, 2, &adv);
 
 	adv = ADVERTISE_1000FULL;
-- 
2.45.2


             reply	other threads:[~2024-09-19 13:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19 13:58 bigunclemax [this message]
2024-10-08 12:58 ` [PATCH v1] eth: asix88179: drop ADVERTISE_LPACK and ADVERTISE_NPAGE advertise flags Mattijs Korpershoek
2024-10-09 21:09   ` Maxim Kiselev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240919135851.153120-1-bigunclemax@gmail.com \
    --to=bigunclemax@gmail.com \
    --cc=caleb.connolly@linaro.org \
    --cc=marex@denx.de \
    --cc=mkorpershoek@baylibre.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox