Re: [PATCH 01/19] spl: Reduce the size of the bl_len field

Tom Rini
2024-09-26T23:23:17Z

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

On Thu, Sep 26, 2024 at 11:36:17PM +0200, Simon Glass wrote:
> Hi Tom,
>
> On Thu, 26 Sept 2024 at 06:06, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Wed, Sep 25, 2024 at 02:55:27PM +0200, Simon Glass wrote:
> >
> > > This is a block length, so typicaly 512 bytes. Reduce the size to
> > > 16 bits to save space, before more fields are added in future work.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > ---
> > >
> > > include/spl.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > I don't think this works as intended:
> > 02: spl: Reduce the size of the bl_len field
> > arm: (for 1/1 boards) spl/u-boot-spl:all +8.0 spl/u-boot-spl:text +8.0
> > chiliboard : spl/u-boot-spl:all +8 spl/u-boot-spl:text +8
> > spl-u-boot-spl: add: 0/0, grow: 2/0 bytes: 8/0 (8)
> > function old new delta
> > spl_nand_load_image 60 64 +4
> > spl_mmc_load 320 324 +4
>
> Yes, unfortunately some ARM devices need more code to access a 16-bit
> value. Perhaps this optimisation is not worth it?

Seems not worth it, yeah.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]