Re: [PATCH 06/19] lib: Mark lz4 as relocation code

Tom Rini
2024-09-26T04:07:35Z

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

On Wed, Sep 25, 2024 at 02:55:32PM +0200, Simon Glass wrote:

> Mark the lz4 decompression code as needed by relocation. This is used to
> decompress the next-phase image.
>
> Drop the 'safe' versions from SPL as they are not needed. Change the
> static array to a local one, to avoid link errors when trying to access
> the data.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> lib/lz4.c | 27 +++++++++++++++------------

Some amount of how you're restructuring here leads to (a number of
platforms):
puma-rk3399 : all +132 bss +16 rodata -64 text +180
u-boot: add: 0/-2, grow: 3/0 bytes: 180/-64 (116)
function old new delta
ulz4fn 1396 1456 +60
LZ4_decompress_safe_partial 1056 1116 +60
LZ4_decompress_safe 1020 1080 +60
static.inc32table 32 - -32
static.dec64table 32 - -32

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]