From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Devarsh Thakkar <devarsht@ti.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Sean Anderson <seanga2@gmail.com>
Subject: Re: [PATCH 11/19] spl: Support jumping to VPL from TPL
Date: Wed, 25 Sep 2024 22:07:10 -0600 [thread overview]
Message-ID: <20240926040710.GI4252@bill-the-cat> (raw)
In-Reply-To: <20240925125622.197915-12-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]
On Wed, Sep 25, 2024 at 02:55:37PM +0200, Simon Glass wrote:
> Use spl_get_image_pos() to obtain the image position to jump to. Add
> the symbols used for VPL so that the correct image can be loaded.
>
> Use the functions provided for accessing these symbols and add a few
> comments too.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> common/spl/spl.c | 22 ++++++++++++++++------
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index d01e9861f88..623e486c210 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -50,15 +50,19 @@ u32 *boot_params_ptr = NULL;
>
> #if CONFIG_IS_ENABLED(BINMAN_UBOOT_SYMBOLS)
> /* See spl.h for information about this */
> +#if defined(CONFIG_SPL_BUILD) && !defined(CONFIG_TPL_BUILD) && !defined(CONFIG_VPL_BUILD)
> binman_sym_declare(ulong, u_boot_any, image_pos);
> binman_sym_declare(ulong, u_boot_any, size);
> +#endif
>
> -#ifdef CONFIG_TPL
> +#if defined(CONFIG_TPL)
> +/* TPL jumps straight to SPL */
> binman_sym_declare(ulong, u_boot_spl_any, image_pos);
> binman_sym_declare(ulong, u_boot_spl_any, size);
> #endif
>
> #ifdef CONFIG_VPL
> +/* TPL jumps to VPL */
> binman_sym_declare(ulong, u_boot_vpl_any, image_pos);
> binman_sym_declare(ulong, u_boot_vpl_any, size);
> #endif
So I see on a64-olinuxino and others a size reduction here, as those
symbols aren't included now. Do we have something in the tooling to
ensure that we aren't now referencing / dereferencing invalid links?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-09-26 4:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 12:55 [PATCH 00/19] spl: Support a relocating jump between phases (VBE part F) Simon Glass
2024-09-25 12:55 ` [PATCH 01/19] spl: Reduce the size of the bl_len field Simon Glass
2024-09-26 4:06 ` Tom Rini
2024-09-26 21:36 ` Simon Glass
2024-09-26 23:23 ` Tom Rini
2024-09-25 12:55 ` [PATCH 02/19] spl: Provide a way of indicating the phase to load Simon Glass
2024-09-25 12:55 ` [PATCH 03/19] spl: Avoid including hash algorithms which are not wanted Simon Glass
2024-09-25 12:55 ` [PATCH 04/19] spl: Provide a way to mark code needed for relocation Simon Glass
2024-09-26 4:06 ` Tom Rini
2024-09-26 21:36 ` Simon Glass
2024-09-25 12:55 ` [PATCH 05/19] lib: Mark crc8 as relocation code Simon Glass
2024-09-25 12:55 ` [PATCH 06/19] lib: Mark lz4 " Simon Glass
2024-09-26 4:06 ` Tom Rini
2024-09-25 12:55 ` [PATCH 07/19] lib: Mark memcpy() and memmove() " Simon Glass
2024-09-25 12:55 ` [PATCH 08/19] spl: Add a type for the jumper function Simon Glass
2024-09-25 12:55 ` [PATCH 09/19] spl: Add support for a relocating jump to the next phase Simon Glass
2024-09-25 12:55 ` [PATCH 10/19] spl: Plumb in the relocating loader Simon Glass
2024-09-25 12:55 ` [PATCH 11/19] spl: Support jumping to VPL from TPL Simon Glass
2024-09-26 4:07 ` Tom Rini [this message]
2024-09-26 21:33 ` Simon Glass
2024-09-26 23:22 ` Tom Rini
2024-09-25 12:55 ` [PATCH 12/19] spl: Record the correct name of the next phase Simon Glass
2024-09-25 12:55 ` [PATCH 13/19] spl: Show how to fill in the size of the next image Simon Glass
2024-09-25 12:55 ` [PATCH 14/19] spl: Add debugging in spl_set_header_raw_uboot() Simon Glass
2024-09-25 12:55 ` [PATCH 15/19] arm: qemu: Allow SPL and TPL Simon Glass
2024-09-25 12:55 ` [PATCH 16/19] arm: Add a new qemu_arm64_tpl board Simon Glass
2024-09-25 12:55 ` [PATCH 17/19] arm: Provide an rcode section in ARMv8 link script Simon Glass
2024-09-25 12:55 ` [PATCH 18/19] arm: qemu_arm64_tpl: Enable the relocating loader Simon Glass
2024-09-25 12:55 ` [PATCH 19/19] CI: Add new test for reloc loader Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926040710.GI4252@bill-the-cat \
--to=trini@konsulko.com \
--cc=devarsht@ti.com \
--cc=quentin.schulz@cherry.de \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox