From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A0AFCDE038 for ; Thu, 26 Sep 2024 20:48:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2DAF988DBA; Thu, 26 Sep 2024 22:48:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="HixVqMX5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2547D88DBA; Thu, 26 Sep 2024 22:48:09 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5CD6E88363 for ; Thu, 26 Sep 2024 22:48:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-6c5ab2de184so9033736d6.0 for ; Thu, 26 Sep 2024 13:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727383685; x=1727988485; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZoipwiaJLKGpPVfD7oV9SC0oKU+FxmUkE55h+HpP6L8=; b=HixVqMX57yNyel0+amuHQvFlc2LB+UBArI544kUq//K5+eIXtPcKAWnFuEldVsJdO1 uzxZa9ZORqMk/u2E7kPqXg9GsfZTdTENfolDFdIuDJ05tnjYo6WCfBg5SA1TyAHS/0/G 9toQFrdon4aLMosAlOLY8ipgSk5sZmb2NDuEc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727383685; x=1727988485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZoipwiaJLKGpPVfD7oV9SC0oKU+FxmUkE55h+HpP6L8=; b=meAQe0grsVPAHb6YbsKkiCMQ04NfNmQYKwBsfmxDwGbAZceyCPDWUtkx6Y1uKBn5v+ EMS12IQiYSdscT6NAxXzF6Lz1xzlG/AY6IQeAartax/aEOHHdEsnEuO42KW65sYWpQmj h3d+aNZVh6IhRZpxlXMqWo9vRjfV/dtXziMIaGxi9Lle/2rZzFjkuNJpmCo3gIAt3sJI Fv5X1GWNr8fcjvy55urZm2if4RLaIPy5SSxFN8pnfEzs1P6R0sUe0z92t3XKtZ6TJvHw GHIeCP28W3Ks/fx3FkDt8b3rw9BNkBBWgUnhkDbrc4JsrBHyB31WZVe8IZGqM9WcXOhl QGgQ== X-Gm-Message-State: AOJu0Ywiuqkj+FU95GGPkQleX35mcmbwGrPyrYVX8sI3xRb9xgq+IGpa /ys3uhNQnSPnu3B+R64uRjZ+enQO7Sbi9XkQBR5KYi7jFS3XOM0NkmdMlzOpctM/A3aXnONTIvw ZCnRQMp8= X-Google-Smtp-Source: AGHT+IEyt7dPuRKEwQbWBlyBzQKjVUD62u5lbjY97PnB03XTKFl7YngsQqkOtrpsQa+9c0SEe9Zk5A== X-Received: by 2002:a05:6214:4982:b0:6cb:36bc:197a with SMTP id 6a1803df08f44-6cb3b67d9f1mr11103756d6.4.1727383684852; Thu, 26 Sep 2024 13:48:04 -0700 (PDT) Received: from chromium.org ([205.220.129.31]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b66cff5sm2538696d6.77.2024.09.26.13.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 13:48:04 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Devarsh Thakkar , Jonas Karlman , Raymond Mao , Richard Weinberger , This contributor prefers not to receive mails Subject: [PATCH 03/27] common: doc: Drop old LED support Date: Thu, 26 Sep 2024 22:44:23 +0200 Message-ID: <20240926204455.963584-4-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240926204455.963584-1-sjg@chromium.org> References: <20240926204455.963584-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This has been replaced with a new LED framework, so drop this old code and documentation. Signed-off-by: Simon Glass --- common/board_f.c | 22 -------------- doc/README.LED | 77 ------------------------------------------------ 2 files changed, 99 deletions(-) delete mode 100644 doc/README.LED diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..f161a690ec0 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -36,7 +36,6 @@ #include #include #include -#include #include #include #include @@ -53,27 +52,6 @@ DECLARE_GLOBAL_DATA_PTR; -/* - * TODO(sjg@chromium.org): IMO this code should be - * refactored to a single function, something like: - * - * void led_set_state(enum led_colour_t colour, int on); - */ -/************************************************************************ - * Coloured LED functionality - ************************************************************************ - * May be supplied by boards if desired - */ -__weak void coloured_LED_init(void) {} -__weak void red_led_on(void) {} -__weak void red_led_off(void) {} -__weak void green_led_on(void) {} -__weak void green_led_off(void) {} -__weak void yellow_led_on(void) {} -__weak void yellow_led_off(void) {} -__weak void blue_led_on(void) {} -__weak void blue_led_off(void) {} - /* * Why is gd allocated a register? Prior to reloc it might be better to * just pass it around to each function in this file? diff --git a/doc/README.LED b/doc/README.LED deleted file mode 100644 index c21c9d53ec3..00000000000 --- a/doc/README.LED +++ /dev/null @@ -1,77 +0,0 @@ -Status LED -======================================== - -This README describes the status LED API. - -The API is defined by the include file include/status_led.h - -The first step is to enable CONFIG_LED_STATUS in menuconfig: -> Device Drivers > LED Support. - -If the LED support is only for specific board, enable -CONFIG_LED_STATUS_BOARD_SPECIFIC in the menuconfig. - -Status LEDS 0 to 5 are enabled by the following configurations at menuconfig: -CONFIG_STATUS_LED0, CONFIG_STATUS_LED1, ... CONFIG_STATUS_LED5 - -The following should be configured for each of the enabled LEDs: -CONFIG_STATUS_LED_BIT -CONFIG_STATUS_LED_STATE -CONFIG_STATUS_LED_FREQ -Where is an integer 1 through 5 (empty for 0). - -CONFIG_STATUS_LED_BIT is passed into the __led_* functions to identify which LED -is being acted on. As such, the value choose must be unique with with respect to -the other CONFIG_STATUS_LED_BIT's. Mapping the value to a physical LED is the -reponsiblity of the __led_* function. - -CONFIG_STATUS_LED_STATE is the initial state of the LED. It should be set to one -of these values: CONFIG_LED_STATUS_OFF or CONFIG_LED_STATUS_ON. - -CONFIG_STATUS_LED_FREQ determines the LED blink frequency. -Values range from 2 to 10. - -Some other LED macros ---------------------- - -CONFIG_STATUS_LED_BOOT is the LED to light when the board is booting. -This must be a valid LED number (0-5). - -CONFIG_STATUS_LED_RED is the red LED. It is used to signal errors. This must be -a valid LED number (0-5). Other similar color LED's macros are -CONFIG_STATUS_LED_GREEN, CONFIG_STATUS_LED_YELLOW and CONFIG_STATUS_LED_BLUE. - -General LED functions ---------------------- -The following functions should be defined: - -__led_init is called once to initialize the LED to CONFIG_STATUS_LED_STATE. -One time start up code should be placed here. - -__led_set is called to change the state of the LED. - -__led_toggle is called to toggle the current state of the LED. - -Colour LED -======================================== - -Colour LED's are at present only used by ARM. - -The functions names explain their purpose. - -coloured_LED_init -red_LED_on -red_LED_off -green_LED_on -green_LED_off -yellow_LED_on -yellow_LED_off -blue_LED_on -blue_LED_off - -These are weakly defined in arch/arm/lib/board.c to noops. Where applicable, define -these functions in the board specific source. - -TBD : Describe older board dependent macros similar to what is done for - -TBD : Describe general support via asm/status_led.h -- 2.43.0