From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Devarsh Thakkar <devarsht@ti.com>,
Kever Yang <kever.yang@rock-chips.com>,
Manoj Sai <abbaraju.manojsai@amarulasolutions.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Sean Anderson <seanga2@gmail.com>
Subject: Re: [PATCH 01/19] spl: Reduce the size of the bl_len field
Date: Thu, 26 Sep 2024 17:23:07 -0600 [thread overview]
Message-ID: <20240926232307.GN4252@bill-the-cat> (raw)
In-Reply-To: <CAFLszTjtW8hBpYMTUXZKALPUuC=4QE8=DQLgOn52XEmj6qg7ng@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]
On Thu, Sep 26, 2024 at 11:36:17PM +0200, Simon Glass wrote:
> Hi Tom,
>
> On Thu, 26 Sept 2024 at 06:06, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Wed, Sep 25, 2024 at 02:55:27PM +0200, Simon Glass wrote:
> >
> > > This is a block length, so typicaly 512 bytes. Reduce the size to
> > > 16 bits to save space, before more fields are added in future work.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > ---
> > >
> > > include/spl.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > I don't think this works as intended:
> > 02: spl: Reduce the size of the bl_len field
> > arm: (for 1/1 boards) spl/u-boot-spl:all +8.0 spl/u-boot-spl:text +8.0
> > chiliboard : spl/u-boot-spl:all +8 spl/u-boot-spl:text +8
> > spl-u-boot-spl: add: 0/0, grow: 2/0 bytes: 8/0 (8)
> > function old new delta
> > spl_nand_load_image 60 64 +4
> > spl_mmc_load 320 324 +4
>
> Yes, unfortunately some ARM devices need more code to access a 16-bit
> value. Perhaps this optimisation is not worth it?
Seems not worth it, yeah.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-09-26 23:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 12:55 [PATCH 00/19] spl: Support a relocating jump between phases (VBE part F) Simon Glass
2024-09-25 12:55 ` [PATCH 01/19] spl: Reduce the size of the bl_len field Simon Glass
2024-09-26 4:06 ` Tom Rini
2024-09-26 21:36 ` Simon Glass
2024-09-26 23:23 ` Tom Rini [this message]
2024-09-25 12:55 ` [PATCH 02/19] spl: Provide a way of indicating the phase to load Simon Glass
2024-09-25 12:55 ` [PATCH 03/19] spl: Avoid including hash algorithms which are not wanted Simon Glass
2024-09-25 12:55 ` [PATCH 04/19] spl: Provide a way to mark code needed for relocation Simon Glass
2024-09-26 4:06 ` Tom Rini
2024-09-26 21:36 ` Simon Glass
2024-09-25 12:55 ` [PATCH 05/19] lib: Mark crc8 as relocation code Simon Glass
2024-09-25 12:55 ` [PATCH 06/19] lib: Mark lz4 " Simon Glass
2024-09-26 4:06 ` Tom Rini
2024-09-25 12:55 ` [PATCH 07/19] lib: Mark memcpy() and memmove() " Simon Glass
2024-09-25 12:55 ` [PATCH 08/19] spl: Add a type for the jumper function Simon Glass
2024-09-25 12:55 ` [PATCH 09/19] spl: Add support for a relocating jump to the next phase Simon Glass
2024-09-25 12:55 ` [PATCH 10/19] spl: Plumb in the relocating loader Simon Glass
2024-09-25 12:55 ` [PATCH 11/19] spl: Support jumping to VPL from TPL Simon Glass
2024-09-26 4:07 ` Tom Rini
2024-09-26 21:33 ` Simon Glass
2024-09-26 23:22 ` Tom Rini
2024-09-25 12:55 ` [PATCH 12/19] spl: Record the correct name of the next phase Simon Glass
2024-09-25 12:55 ` [PATCH 13/19] spl: Show how to fill in the size of the next image Simon Glass
2024-09-25 12:55 ` [PATCH 14/19] spl: Add debugging in spl_set_header_raw_uboot() Simon Glass
2024-09-25 12:55 ` [PATCH 15/19] arm: qemu: Allow SPL and TPL Simon Glass
2024-09-25 12:55 ` [PATCH 16/19] arm: Add a new qemu_arm64_tpl board Simon Glass
2024-09-25 12:55 ` [PATCH 17/19] arm: Provide an rcode section in ARMv8 link script Simon Glass
2024-09-25 12:55 ` [PATCH 18/19] arm: qemu_arm64_tpl: Enable the relocating loader Simon Glass
2024-09-25 12:55 ` [PATCH 19/19] CI: Add new test for reloc loader Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926232307.GN4252@bill-the-cat \
--to=trini@konsulko.com \
--cc=abbaraju.manojsai@amarulasolutions.com \
--cc=devarsht@ti.com \
--cc=kever.yang@rock-chips.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox