From: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
To: <trini@konsulko.com>, <sjg@chromium.org>, <bob.wolff68@gmail.com>,
<u-boot@lists.denx.de>
Subject: [PATCH v2 3/4] image-fit-sig: Remove padding check
Date: Fri, 27 Sep 2024 11:07:25 +0800 [thread overview]
Message-ID: <20240927030726.2211297-4-chiawei_wang@aspeedtech.com> (raw)
In-Reply-To: <20240927030726.2211297-1-chiawei_wang@aspeedtech.com>
The padding algorithm is not mandatory for all signing algorithm.
For example, ECDSA does not require a padding method.
For RSA requiring PKCS padding, the belonging info->crypto(), assigned
with rsa_verify_key(), also has the check on the validity of info->padding().
Thus, remove the info->padding check from the upper, general layer.
Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
boot/image-fit-sig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/image-fit-sig.c b/boot/image-fit-sig.c
index fe328df4a85..d06e6cc8ed6 100644
--- a/boot/image-fit-sig.c
+++ b/boot/image-fit-sig.c
@@ -95,7 +95,7 @@ static int fit_image_setup_verify(struct image_sign_info *info,
info->required_keynode = required_keynode;
printf("%s:%s", algo_name, info->keyname);
- if (!info->checksum || !info->crypto || !info->padding) {
+ if (!info->checksum || !info->crypto) {
*err_msgp = "Unknown signature algorithm";
return -1;
}
--
2.25.1
next prev parent reply other threads:[~2024-09-27 3:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 3:07 [PATCH v2 0/4] aspeed: ast2700: Add Caliptra ECDSA driver Chia-Wei Wang
2024-09-27 3:07 ` [PATCH v2 1/4] lib: ecdsa: Add ECDSA384 support Chia-Wei Wang
2024-09-27 3:07 ` [PATCH v2 2/4] lib: ecdsa: Create device tree node automatically Chia-Wei Wang
2024-09-27 3:07 ` Chia-Wei Wang [this message]
2024-09-27 3:07 ` [PATCH v2 4/4] drivers/crypto: aspeed: Add Caliptra ECDSA384 support Chia-Wei Wang
2024-10-11 17:34 ` [PATCH v2 0/4] aspeed: ast2700: Add Caliptra ECDSA driver Tom Rini
2024-10-14 2:07 ` ChiaWei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240927030726.2211297-4-chiawei_wang@aspeedtech.com \
--to=chiawei_wang@aspeedtech.com \
--cc=bob.wolff68@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox