Re: [PATCH 03/26] clk: imx8mm: Prevent clock critical path from disabling during reparent and set_rate

Marek Vasut
2024-09-13T10:09:45Z

On 9/13/24 11:55 AM, Dario Binacchi wrote:
> From: Michael Trimarchi <michael@amarulasolutions.com>
>
> This commit ensures that critical clock paths are not disabled during
> reparent and set_rate operations within the clock framework, paving the
> way for the inclusion of new features.
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> drivers/clk/imx/clk-imx8mm.c | 64 +++++++++++++++++++++++++++++-------
> 1 file changed, 52 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index a91c6767fac5..432348a15cad 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -27,11 +27,25 @@ static const char * const imx8mm_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "
> "sys_pll2_1000m", "sys_pll1_800m", "sys_pll1_400m",
> "audio_pll1_out", "sys_pll3_out", };
>
> +#ifndef CONFIG_SPL_BUILD
> +static const char * const imx8mm_noc_sels[] = {"clock-osc-24m", "sys_pll1_800m", "sys_pll3_out",
> + "sys_pll2_1000m", "sys_pll2_500m", "audio_pll1_out",
> + "video_pll1_out", "audio_pll2_out", };
> +
This seems to be adding a lot of new clock, such a change is not
described in the commit message.

What problem is this patch solving ? The commit message needs to be
updated, it does not seem to match the patch at all.