From: Christian Marangi <ansuelsmth@gmail.com>
To: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
AKASHI Takahiro <akashi.tkhro@gmail.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Etienne Carriere <etienne.carriere@foss.st.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Algapally Santosh Sagar <santoshsagar.algapally@amd.com>,
Sean Anderson <seanga2@gmail.com>,
Eddie James <eajames@linux.ibm.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Alexander Gendin <agendin@matrox.com>,
Yang Xiwen <forbidden405@outlook.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Arseniy Krasnov <avkrasnov@salutedevices.com>,
Heiko Schocher <hs@denx.de>,
Michael Trimarchi <michael@amarulasolutions.com>,
Martin Kurbanov <mmkurbanov@salutedevices.com>,
Alexey Romanov <avromanov@salutedevices.com>,
Artur Rojek <artur@conclusive.pl>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Leo Yu-Chi Liang <ycliang@andestech.com>,
Vasileios Amoiridis <vassilisamir@gmail.com>,
Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Michael Polyntsov <michael.polyntsov@iopsys.eu>,
Doug Zobel <douglas.zobel@climate.com>,
Marek Vasut <marex@denx.de>,
u-boot@lists.denx.de, John Crispin <john@phrozen.org>
Subject: [PATCH v5 07/11] mtd: implement support for LED activity
Date: Tue, 1 Oct 2024 14:24:40 +0200 [thread overview]
Message-ID: <20241001122511.8832-8-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20241001122511.8832-1-ansuelsmth@gmail.com>
Implement support for LED activity. If the feature is enabled,
make the defined ACTIVITY LED to signal mtd operations.
LED activity is implemented HERE and not in the subsystem side to limit
any performance degradation in case multiple call to MTD subsystem read/write
are done.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
cmd/mtd.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/cmd/mtd.c b/cmd/mtd.c
index 795aaa2b37d..f178d7bea61 100644
--- a/cmd/mtd.c
+++ b/cmd/mtd.c
@@ -10,6 +10,7 @@
#include <command.h>
#include <console.h>
+#include <led.h>
#if CONFIG_IS_ENABLED(CMD_MTD_OTP)
#include <hexdump.h>
#endif
@@ -558,6 +559,8 @@ static int do_mtd_io(struct cmd_tbl *cmdtp, int flag, int argc,
while (mtd_block_isbad(mtd, off))
off += mtd->erasesize;
+ led_activity_blink();
+
/* Loop over the pages to do the actual read/write */
while (remaining) {
/* Skip the block if it is bad */
@@ -585,6 +588,8 @@ static int do_mtd_io(struct cmd_tbl *cmdtp, int flag, int argc,
io_op.oobbuf += io_op.oobretlen;
}
+ led_activity_off();
+
if (!ret && dump)
mtd_dump_device_buf(mtd, start_off, buf, len, woob);
@@ -652,6 +657,8 @@ static int do_mtd_erase(struct cmd_tbl *cmdtp, int flag, int argc,
erase_op.addr = off;
erase_op.len = mtd->erasesize;
+ led_activity_blink();
+
while (len) {
if (!scrub) {
ret = mtd_block_isbad(mtd, erase_op.addr);
@@ -680,6 +687,8 @@ static int do_mtd_erase(struct cmd_tbl *cmdtp, int flag, int argc,
erase_op.addr += mtd->erasesize;
}
+ led_activity_off();
+
if (ret && ret != -EIO)
ret = CMD_RET_FAILURE;
else
--
2.45.2
next prev parent reply other threads:[~2024-10-01 13:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 12:24 [PATCH v5 00/11] led: introduce LED boot and activity function Christian Marangi
2024-10-01 12:24 ` [PATCH v5 01/11] led: toggle LED on initial SW blink Christian Marangi
2024-10-02 22:55 ` Simon Glass
2024-10-02 22:59 ` Christian Marangi
2024-10-03 6:22 ` Michael Nazzareno Trimarchi
2024-10-03 10:59 ` Christian Marangi
2024-10-01 12:24 ` [PATCH v5 02/11] dm: core: implement ofnode_options helpers Christian Marangi
2024-10-01 12:24 ` [PATCH v5 03/11] led: implement LED boot API Christian Marangi
2024-10-02 22:55 ` Simon Glass
2024-10-02 23:00 ` Christian Marangi
2024-10-03 17:30 ` Simon Glass
2024-11-02 19:33 ` Simon Glass
2024-11-02 19:36 ` Christian Marangi
2024-11-02 19:50 ` Simon Glass
2024-11-02 19:52 ` Christian Marangi
2024-11-03 14:46 ` Simon Glass
2024-11-04 23:13 ` Christian Marangi
2024-11-05 15:12 ` Simon Glass
2024-11-05 15:15 ` Christian Marangi
2024-10-01 12:24 ` [PATCH v5 04/11] common: board_r: rework BOOT LED handling Christian Marangi
2024-10-01 12:24 ` [PATCH v5 05/11] led: implement LED activity API Christian Marangi
2024-10-02 22:55 ` Simon Glass
2024-10-01 12:24 ` [PATCH v5 06/11] tftp: implement support for LED activity Christian Marangi
2024-10-01 12:24 ` Christian Marangi [this message]
2024-10-02 22:55 ` [PATCH v5 07/11] mtd: " Simon Glass
2024-10-01 12:24 ` [PATCH v5 08/11] ubi: " Christian Marangi
2024-10-01 12:24 ` [PATCH v5 09/11] doc: introduce led.rst documentation Christian Marangi
2024-10-01 12:24 ` [PATCH v5 10/11] test: dm: Add tests for LED boot and activity Christian Marangi
2024-10-01 12:24 ` [PATCH v5 11/11] test: dm: Expand ofnode options test with new helper Christian Marangi
2024-10-11 17:35 ` [PATCH v5 00/11] led: introduce LED boot and activity function Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241001122511.8832-8-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=agendin@matrox.com \
--cc=akashi.tkhro@gmail.com \
--cc=artur@conclusive.pl \
--cc=avkrasnov@salutedevices.com \
--cc=avromanov@salutedevices.com \
--cc=caleb.connolly@linaro.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=douglas.zobel@climate.com \
--cc=eajames@linux.ibm.com \
--cc=etienne.carriere@foss.st.com \
--cc=forbidden405@outlook.com \
--cc=hs@denx.de \
--cc=ilias.apalodimas@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=john@phrozen.org \
--cc=marex@denx.de \
--cc=michael.polyntsov@iopsys.eu \
--cc=michael@amarulasolutions.com \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=miquel.raynal@bootlin.com \
--cc=mkorpershoek@baylibre.com \
--cc=mmkurbanov@salutedevices.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=rfried.dev@gmail.com \
--cc=santoshsagar.algapally@amd.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vassilisamir@gmail.com \
--cc=xypron.glpk@gmx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox