Re: [PATCH v6 08/12] efi_loader: Disable ANSI output for tests

Tom Rini
2024-10-11T22:54:48Z

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

On Fri, Oct 11, 2024 at 04:18:07PM -0600, Simon Glass wrote:

[snip]
> No other subsystem generates ANSI characters when U-Boot starts. Why
> are we creating this problem in the EFI implementation?
>
> So please, I very-much want to have a way to stop this output from
> being generated, not to filter it afterwards. As above, we should
> design U-Boot for easy testing, not treat it as a black box. Please do
> seriously consider this as I believe this is an important testing
> principle being violated here.

This is, I think, a good point. Outside of user-facing interactive
code, we don't use ANSI sequences for printing information in
U-Boot anywhere else. Why are we doing it in the EFI_LOADER code outside
of personal preference? And, can we just not instead? It does confuse
matters (as my example showed) when problems do arise.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]