Re: [PATCH v6 08/12] efi_loader: Disable ANSI output for tests

Tom Rini
2024-10-11T22:28:18Z

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

On Fri, Oct 11, 2024 at 04:16:28PM -0600, Simon Glass wrote:

> Hi Heinrich, Tom,
>
> On Tue, 1 Oct 2024 at 16:18, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
[snip]
> > The relevant error message is:
> >
> > E Exception: Bad pattern found on console: spl_signon
> >
> > The error occurs because the substring
> >
> > U-Boot SPL 2024.10
> >
> > occurs multiple times during the reboot process. This is not expected in
> > wait_for_boot_prompt().
> >
> > The EFI test is resetting the board and then calling restart_uboot()
> > which by itself does another reset.
>
> We had this discussion a while back and I was very-much opposed to
> restarting U-Boot within a test. It has set a bad precedent and now
> several tests do it.
>
> This is another EFI thing that I would like to resolve at some point.
> As previously mentioned, I understand we might be one test to check
> that U-Boot does actually kick up a firmware update when started, but
> I don't think we should be restarting willy-nilly.

We should indeed not be restarting willy-nilly. And we don't. But the
test for "can we restart the system" must restart the system. That's the
test. It's not changing. Testing if we can restart the system by faking
the restart is not testing restarting the system.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]