Re: [PATCH v6 05/12] efi_loader: Show the vendor in helloworld

Simon Glass
2024-09-27T12:34:12Z

Hi Ilias,

On Fri, 27 Sept 2024 at 06:00, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> Hi Simon
>
>
> On Fri, 27 Sept 2024 at 01:01, Simon Glass <sjg@chromium.org> wrote:
> >
> > Show the vendor name so it is clear which firmware is being used, e.g.
> > whether U-Boot is providing the boot services.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
>
> I already sent my r-b for this. [0]. I am not sure Heinrich remarks were covered

Heinrich basically didn't see the point of this patch, but then
suggested printing out FirmwareRevision too. I did reply but didn't
hear back.

So I suggest we just go with this and we can expand it later. Or just
drop the patch.

>
> > ---
> >
> > (no changes since v2)
> >
> > Changes in v2:
> > - Reword commit message
> > - Use 'Firmware vendor' instead of just 'Vendor'
> >
> > lib/efi_loader/helloworld.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/lib/efi_loader/helloworld.c b/lib/efi_loader/helloworld.c
> > index 586177de0c8..c4d2afcb40a 100644
> > --- a/lib/efi_loader/helloworld.c
> > +++ b/lib/efi_loader/helloworld.c
> > @@ -237,6 +237,9 @@ efi_status_t EFIAPI efi_main(efi_handle_t handle,
> > (con_out, u"Missing device path for device handle\r\n");
> > goto out;
> > }
> > + con_out->output_string(con_out, u"Firmware vendor: ");
> > + con_out->output_string(con_out, systab->fw_vendor);
> > + con_out->output_string(con_out, u"\n");
> > con_out->output_string(con_out, u"Boot device: ");
> > ret = print_device_path(device_path, device_path_to_text);
> > if (ret != EFI_SUCCESS)
> > --
> > 2.43.0
> >
>
> [0] https://lore.kernel.org/u-boot/CAC_iWj+DtHbghAqJWiwm8ZVCXf3mCOOm13YpLSQGGBPcpgnWiQ@mail.gmail.com/

Regards,
Simon